)]}'
{"tools/deployment/common/setup-ceph-loopback-device.sh":[{"author":{"_account_id":24655,"name":"Wang.Peng","email":"wangpeng@yovole.com"},"change_message_id":"98cbdb26ce10f659d3c411dada3549d71ad51b83","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function setup_loopback_devices() {"},{"line_number":6,"context_line":"  osd_data_device\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1d0e0c11_4c7d3e1e","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":7},"updated":"2021-01-28 01:47:09.000000000","message":"Non-debug, remove it.","commit_id":"db0e7bc23e920efc5d3ef871261d42516b286548"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"a8a60746f7a252ae67185645f867d0a7c414bf24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function setup_loopback_devices() {"},{"line_number":6,"context_line":"  osd_data_device\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"f59499a5_6928c697","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":7},"in_reply_to":"1d0e0c11_4c7d3e1e","updated":"2021-02-05 15:58:34.000000000","message":"Done","commit_id":"db0e7bc23e920efc5d3ef871261d42516b286548"},{"author":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"change_message_id":"677cb1ef759074ee00648fadd585bee829339ba5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -ex"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function setup_loopback_devices() {"},{"line_number":6,"context_line":"  osd_data_device\u003d\"$1\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7de1ad3c_647d517e","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":7},"updated":"2021-02-07 03:41:29.000000000","message":"may we bring -e back please","commit_id":"a61f710b88324b02b7d6025b8c32229b76f05353"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"6df614e9d1effaee1512666fe9aebaa0c7c4f9ad","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  sudo systemctl enable loops-setup"},{"line_number":39,"context_line":"  # let\u0027s verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created successfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"38b8a1fc_87c172cd","line":41,"updated":"2021-02-09 15:30:00.000000000","message":"Nit: Remove space between losetup and | to be consistent with other places in the script (lines 68 and 79)","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"6234cf43b2f62b4ae70f9c3650ae4ecc00178d3c","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  sudo systemctl enable loops-setup"},{"line_number":39,"context_line":"  # let\u0027s verify the devices"},{"line_number":40,"context_line":"  sudo losetup -a"},{"line_number":41,"context_line":"  if losetup |grep -i $osd_data_device; then"},{"line_number":42,"context_line":"    echo \"ceph osd data disk got created successfully\""},{"line_number":43,"context_line":"  else"},{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"3b4cb849_ae730199","line":41,"in_reply_to":"38b8a1fc_87c172cd","updated":"2021-02-09 16:09:38.000000000","message":"thank  for catching this , shall i correct it on my next change ?","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"change_message_id":"6df614e9d1effaee1512666fe9aebaa0c7c4f9ad","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created successfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"could not find ceph osd wal/db  disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"335c10f0_fd483aaa","line":47,"updated":"2021-02-09 15:30:00.000000000","message":"Nit: Remove space between losetup and | to be consistent with other places in the script (lines 68 and 79)","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"533c519261e8072b5d7c97ea7d095b9180dacb15","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created successfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"could not find ceph osd wal/db  disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"d23db6d4_57144de5","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":46},"updated":"2021-02-09 15:56:42.000000000","message":"This comment isn\u0027t directly related to these changes, but it is indirectly related. Shouldn\u0027t we separate osd_wal_db_device into two devices, osd_wal_device and osd_db_device? The gate currently puts them on a single device, but it doesn\u0027t have to. Not a showstopper for this patch set in my opinion, but something that should probably be changed at some point.","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"6234cf43b2f62b4ae70f9c3650ae4ecc00178d3c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created successfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"could not find ceph osd wal/db  disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"a6153258_8538a760","line":47,"in_reply_to":"335c10f0_fd483aaa","updated":"2021-02-09 16:09:38.000000000","message":"thank  for catching this , shall i correct it on my next change ?","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"d4a8cc043b12ea6f7ce1bd7139559986c9638c6d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    echo \"could not find ceph osd data disk so exiting\""},{"line_number":45,"context_line":"    exit 1"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":"  if losetup |grep -i $osd_wal_db_device; then"},{"line_number":48,"context_line":"    echo \"ceph osd wal/db disk got created successfully\""},{"line_number":49,"context_line":"  else"},{"line_number":50,"context_line":"    echo \"could not find ceph osd wal/db  disk so exiting\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"d2256bd4_8771e207","line":47,"range":{"start_line":47,"start_character":2,"end_line":47,"end_character":46},"in_reply_to":"d23db6d4_57144de5","updated":"2021-02-09 16:05:49.000000000","message":"Steve, we are leaving that for ceph charts to partition this disk as we are giving inputs here \nhttps://github.com/openstack/openstack-helm-infra/blob/master/tools/deployment/osh-infra-logging/020-ceph.sh#L174-L179","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"afb02d4fd7c88cfb45801416583b26ac0084d217","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":": \"${CEPH_NAMESPACE:\u003d\"ceph\"}\""},{"line_number":86,"context_line":"# setup loopback devices for ceph osds"},{"line_number":87,"context_line":"setup_loopback_devices $OSD_DATA_DEVICE $OSD_DB_WAL_DEVICE"}],"source_content_type":"text/x-sh","patch_set":7,"id":"fc9b7443_f44a0414","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":23},"updated":"2021-02-09 19:32:34.000000000","message":"not really sure why there is a need to move this block to a function at this point, but I will bite  :)","commit_id":"b433245b3d2c01ebeaad8b92c4100ab0328e9ede"}]}