)]}'
{"id":"openstack%2Fopenstack-helm~762575","triplet_id":"openstack%2Fopenstack-helm~master~Id6a8115e52a08f0618d9252b3264999272272725","project":"openstack/openstack-helm","branch":"master","topic":"fix-keystone-delete","hashtags":[],"change_id":"Id6a8115e52a08f0618d9252b3264999272272725","subject":"keystone: do not delete secrets on deploy","status":"ABANDONED","created":"2020-11-12 20:27:15.000000000","updated":"2021-09-30 16:07:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"efb2f1a7146b8bd846398db56b293187f8e85cd9","_number":762575,"virtual_id_number":762575,"owner":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-12 21:24:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-12 21:24:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"865775bcb75214ad916f9f640256e90452058d63","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-11-12 20:27:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2c6dbf35e84e526f6e58898f6867d036a8492597","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 21:24:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a2e3cdb518984fbf9426bfe42ec19a8e : SUCCESS in 5m 03s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/bda4e82ae9e749f98ca02bc2ac5d7df5 : FAILURE in 3m 43s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/620f850a1398427bb08f5f7b4a325d50 : SUCCESS in 51m 20s\n- openstack-helm-cinder-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/1681b5e650e7416fa2ad94b22d90051d : SUCCESS in 46m 47s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/538ddf2eebd44aa49b18362aaecf0299 : SUCCESS in 43m 02s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/e9cf242ad9bb44819d5495531d1d29a5 : SUCCESS in 44m 31s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/67919a19520a42918e59212bd55d3626 : FAILURE in 39m 50s\n- openstack-helm-compute-kit-rocky-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/7312c3056ddf4df78b6b9a3cdf7065f9 : FAILURE in 40m 10s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a5cb2cfbce934c73a0b6a0abce3dd015 : FAILURE in 42m 55s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/dc4cbc28112c4f1bac79d4aaac247ea8 : FAILURE in 46m 35s","accounts_in_message":[],"_revision_number":1},{"id":"efb2f1a7146b8bd846398db56b293187f8e85cd9","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-09-30 16:07:35.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"228bdb3684ff1732fb480fb2d111563a1cec8190","revisions":{"228bdb3684ff1732fb480fb2d111563a1cec8190":{"kind":"REWORK","_number":1,"created":"2020-11-12 20:27:15.000000000","uploader":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"ref":"refs/changes/75/762575/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/75/762575/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/762575/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/762575/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/762575/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/75/762575/1"}}},"commit":{"parents":[{"commit":"42712e1d36137fab5742b181905141edadca618f","subject":"Pass ovs agent config to dhcp agent","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/42712e1d36137fab5742b181905141edadca618f"}]}],"author":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-11-12 20:25:15.000000000","tz":-300},"committer":{"name":"Mohammed Naser","email":"mnaser@vexxhost.com","date":"2020-11-12 20:25:15.000000000","tz":-300},"subject":"keystone: do not delete secrets on deploy","message":"keystone: do not delete secrets on deploy\n\nThe default hook-delete-policy for Helm is before-hook-creation[1]\nwhich corresponds to \"Delete the previous resource before a new hook\nis launched (default)\".\n\nThis will result in the secret being wiped on every deploy, the solution\nin here is to switch it to `hook-failed` which maps to \"Delete the\nresource if the hook failed during execution\" -- however, given that\nthis is a secret, it will never \u0027fail\u0027, keeping that resource untouched.\n\n[1]: https://helm.sh/docs/topics/charts_hooks/#hook-deletion-policies\n\nChange-Id: Id6a8115e52a08f0618d9252b3264999272272725\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/228bdb3684ff1732fb480fb2d111563a1cec8190"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/228bdb3684ff1732fb480fb2d111563a1cec8190"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}