)]}'
{"neutron/templates/deployment-server.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"4e0cc4207b3d13d0d9399f861855b9eda89e8453","unresolved":true,"context_lines":[{"line_number":211,"context_line":"              subPath: ml2_conf.ini"},{"line_number":212,"context_line":"              readOnly: true"},{"line_number":213,"context_line":"            {{- end }}"},{"line_number":214,"context_line":"            {{ if ( has \"sriovnicswitch\" .Values.network.backend ) }}"},{"line_number":215,"context_line":"            - name: neutron-etc"},{"line_number":216,"context_line":"              mountPath: /etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":217,"context_line":"              subPath: sriov_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4c063867_1ae0db12","line":214,"range":{"start_line":214,"start_character":25,"end_line":214,"end_character":39},"updated":"2021-01-08 17:18:31.000000000","message":"I don\u0027t see the need to update this to match the mechanism driver name, I much prefer to keep it as sriov, unless there is a valid reason to do so.","commit_id":"e4332d90b3c4b16cd655aa0a8ec598f76b9275ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"70137e8a92f7b151b7cd87accb266cfa8215da60","unresolved":true,"context_lines":[{"line_number":211,"context_line":"              subPath: ml2_conf.ini"},{"line_number":212,"context_line":"              readOnly: true"},{"line_number":213,"context_line":"            {{- end }}"},{"line_number":214,"context_line":"            {{ if ( has \"sriovnicswitch\" .Values.network.backend ) }}"},{"line_number":215,"context_line":"            - name: neutron-etc"},{"line_number":216,"context_line":"              mountPath: /etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":217,"context_line":"              subPath: sriov_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8a2b3428_6faaea85","line":214,"range":{"start_line":214,"start_character":25,"end_line":214,"end_character":39},"in_reply_to":"4c063867_1ae0db12","updated":"2021-01-08 21:34:49.000000000","message":"by default the list of mechanism drivers is taken from network:backend https://github.com/openstack/openstack-helm/blob/master/neutron/templates/configmap-etc.yaml#L154. Having non existed neutron driver will prevent it from starting. By doing this we allow user to set only network:backend and do not override it via conf:plugins.ml2_conf.ml2.mechanism_drivers","commit_id":"e4332d90b3c4b16cd655aa0a8ec598f76b9275ad"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"87c47a8b2bff2eda61da756c258cb3b5fd4b2468","unresolved":true,"context_lines":[{"line_number":211,"context_line":"              subPath: ml2_conf.ini"},{"line_number":212,"context_line":"              readOnly: true"},{"line_number":213,"context_line":"            {{- end }}"},{"line_number":214,"context_line":"            {{ if ( has \"sriovnicswitch\" .Values.network.backend ) }}"},{"line_number":215,"context_line":"            - name: neutron-etc"},{"line_number":216,"context_line":"              mountPath: /etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":217,"context_line":"              subPath: sriov_agent.ini"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4cac8b8a_a2b28dc8","line":214,"range":{"start_line":214,"start_character":25,"end_line":214,"end_character":39},"in_reply_to":"8a2b3428_6faaea85","updated":"2021-01-12 19:55:04.000000000","message":"so actually the problem seems to be where \"default $envAll.Values.network.backend\" is specified for mechanism_drivers.  The default is actually [] in neutron so the better solution is to remove that condition and just rely on what is actually specified in the mechanism_driver field in values.   Forcing a \"sriovnicswitch\" name as a network backend seems incorrect to me otherwise.","commit_id":"e4332d90b3c4b16cd655aa0a8ec598f76b9275ad"}]}
