)]}'
{"id":"openstack%2Fopenstack-helm~783119","triplet_id":"openstack%2Fopenstack-helm~master~Ib1415cadbbfab874a8d44ac6b5c6fba3c7502242","project":"openstack/openstack-helm","branch":"master","topic":"glance-policy-ossn-0088","hashtags":[],"change_id":"Ib1415cadbbfab874a8d44ac6b5c6fba3c7502242","subject":"Update glance default policy values","status":"MERGED","created":"2021-03-25 22:34:25.000000000","updated":"2021-03-26 16:23:27.000000000","submitted":"2021-03-26 16:19:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"783119-glance-policy-ossn-0088","meta_rev_id":"edb127577a7cc4177a583fb5fc8fbe05fa4c3b8d","_number":783119,"virtual_id_number":783119,"owner":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-26 16:19:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"recommended":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"all":[{"value":1,"date":"2021-03-26 00:51:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":2,"date":"2021-03-26 01:26:17.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2021-03-25 22:55:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":0,"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},{"value":1,"date":"2021-03-26 01:26:17.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"}],"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-25 22:55:14.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2021-03-25 23:36:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-26 00:51:40.000000000","updated_by":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"reviewer":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"state":"REVIEWER"},{"updated":"2021-03-26 01:26:17.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2021-03-26 12:54:59.000000000","updated_by":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"reviewer":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"state":"CC"}],"messages":[{"id":"cc54c1f09261899c42d4f65889f008d673fd7f75","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"date":"2021-03-25 22:34:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eb40f9c8e3150afa3578303dd15dd57686486543","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-03-25 22:55:14.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks like the recommendations were updated[0]. This is fine, although still doesn\u0027t really solve the issue, people can still shoot themselves in the foot but now they have to be admin to do so.\n\n\n[0] https://wiki.openstack.org/w/index.php?title\u003dOSSN/OSSN-0088\u0026oldid\u003d177901","accounts_in_message":[],"_revision_number":1},{"id":"2c280dafae8d8f62b649bf01b9d8590efa703987","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 23:36:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e6d33c421d94d9083eeb589d0632169 : SUCCESS in 4m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ce23a8c97c7e4bd1b427fee76767121f : SUCCESS in 5m 00s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/bb8bb907d3dc4d39861911f3fc73cc73 : SUCCESS in 4m 44s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/f3727f617d914cfdbedc2e85a190140e : SUCCESS in 45m 26s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/de132a6055674add84b796dd764b9e56 : SUCCESS in 42m 32s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/973f9d5f9f5e4940808a62b97cc42c59 : SUCCESS in 43m 35s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/24a5a89882a146f9900491387a87a105 : SUCCESS in 56m 02s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/28f890f209764d6cb6f179c1e2d815f1 : SUCCESS in 56m 41s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/56c68e53194944e7987445d1d63a3870 : SUCCESS in 56m 53s\n- openstack-helm-horizon-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/930cfeebd07e400797ff22da07ae4f13 : SUCCESS in 26m 14s","accounts_in_message":[],"_revision_number":1},{"id":"b828f04eb113c4c8749c68e5fef4fb201739820b","author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"date":"2021-03-26 00:51:40.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"939db86881975fab37ed44fac80c8e5af2687a75","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2021-03-26 01:26:17.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3b9723ef5ca003cf78c310de6979ea55469e0424","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 01:26:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"595f409f8914b536f83f543e52b8fc8a146307a6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 03:32:44.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4b79b478527b434d869a866f73ae8f7d : SUCCESS in 5m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0583c5998dc94f2899c574819898c0c4 : SUCCESS in 4m 26s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/245d528cfc084ec8b8236b867630e8f8 : SUCCESS in 5m 14s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/a7b10353e47a47498df5283b4a98fb35 : FAILURE in 6m 47s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/25611460b3034e2fb535ca4fcdbd818f : SUCCESS in 40m 38s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/9f5de1b82ef34672af29bb04899b1fd6 : SUCCESS in 44m 58s\n- openstack-helm-horizon-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/cfbf40be665d40f2bcc07151a674d946 : SUCCESS in 25m 16s\n- openstack-helm-multinode-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/593e29718eae4e27acc66cea265a139e : FAILURE in 2h 00m 58s\n- openstack-helm-multinode-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/cf3cf70eb6b943cda9a2cafe1468666d : SUCCESS in 1h 24m 03s","accounts_in_message":[],"_revision_number":1},{"id":"87fdb545c114c4bfb307fc5a83f3d45643c45df6","author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"date":"2021-03-26 12:54:59.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0d300fcb25ae498ab549d76c16be28c9b8fe3aef","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 13:50:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/27f73c239d9c46beab904aaec849a34a : SUCCESS in 5m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/67fabab4b4f9461a8fc1ed3963fd56eb : SUCCESS in 4m 10s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/99279c8e5f9a4e8faf204a874f36f9cc : SUCCESS in 5m 26s\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/0504481330af47bf893186d6e05a096e : SUCCESS in 45m 35s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/f15e13ff05b24aeb85a8a720b0e6b5fe : SUCCESS in 45m 46s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/6723b9ded68544dc81a2d705facc5be7 : SUCCESS in 41m 11s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/f81211303e214585ba46274e24c6024e : SUCCESS in 51m 51s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/01950bb355dd4155910eef92fe76d52e : SUCCESS in 50m 27s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/c4dd3e188c6d4701bed656731308fdb7 : SUCCESS in 50m 53s\n- openstack-helm-horizon-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/2b00607477b24c3a8e00f904474e12ce : SUCCESS in 26m 33s","accounts_in_message":[],"_revision_number":1},{"id":"07b159272060754eda4e29210afc1d863b4ab8f7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 13:50:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3a7458b108417e4448611273ba067cdb9907a0cc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 16:19:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96645e1ca4d6429bbcfc48379432216c : SUCCESS in 5m 29s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/59648b491e3f46aca27e9147cb7c8df4 : SUCCESS in 4m 35s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/55f60b91dec34cedb078b03deb4d3241 : SUCCESS in 8m 56s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/5781009ed6a84d0d81cc00cc2924e4ea : FAILURE in 30m 31s (non-voting)\n- openstack-helm-cinder-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/7c4c555f95054c608e34dd913b07f6a1 : SUCCESS in 47m 10s\n- openstack-helm-compute-kit-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/e25f6a97fa3c4208b1a291d426a9b699 : SUCCESS in 52m 19s\n- openstack-helm-horizon-stein-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/3c650fb0c7ca47d59ffbb90a9f3dfcf5 : SUCCESS in 30m 53s\n- openstack-helm-multinode-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/2714794912ee40eda158f41ac2ca05fe : SUCCESS in 1h 43m 24s\n- openstack-helm-multinode-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/2adcce2a5cf949f881459c5cf10f7240 : SUCCESS in 1h 42m 40s","accounts_in_message":[],"_revision_number":1},{"id":"f0f9b062ebbc2c4f1e5358472fbfa64c8682bae5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 16:19:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"edb127577a7cc4177a583fb5fc8fbe05fa4c3b8d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 16:23:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6f90096bf66e4f46a614e35fcc3a87c4 : SUCCESS in 1m 23s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4b2a7f9480e24164b107bcc960d237a8 : SUCCESS in 55s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8f38a1c45f78deb0f1f3858a601e2a487a2ef378","revisions":{"8f38a1c45f78deb0f1f3858a601e2a487a2ef378":{"kind":"REWORK","_number":1,"created":"2021-03-25 22:34:25.000000000","uploader":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"ref":"refs/changes/19/783119/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/19/783119/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/19/783119/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/19/783119/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/19/783119/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/19/783119/1"}}},"commit":{"parents":[{"commit":"bd476a66778ca11e2e4c6248e776943032cf8cf3","subject":"Merge \"Add helm.sh/hook related annotation for neutron\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/bd476a66778ca11e2e4c6248e776943032cf8cf3"}]}],"author":{"name":"guilhermesteinmuller","email":"gsteinmuller@vexxhost.com","date":"2021-03-25 22:32:08.000000000","tz":-180},"committer":{"name":"guilhermesteinmuller","email":"gsteinmuller@vexxhost.com","date":"2021-03-25 22:32:08.000000000","tz":-180},"subject":"Update glance default policy values","message":"Update glance default policy values\n\nCurrently, when users try to navigate through horizon\npanels or use the command-line interface that contains\ncalls to /api/glance/metadefs it will pop up insufficient\npermission errors due to the fact we are disabling [1]\nthe metadef APIs in glance addressing OSSN-0088 [2].\n\nAs a side effect on how we address the OSSN, all API calls\nto metadefs will be forbidden for any user, which is not recommended\nin production environments. However, we have the current\nrecommendation of the OSSN which allows CRUD of metadef to\nadmin only and provide read access to all users.\n\n[1] https://github.com/openstack/openstack-helm/commit/aab5ee77113c03865cc863f1a22a3730a86235c8\n[2] https://wiki.openstack.org/wiki/OSSN/OSSN-0088\n\nStory: 2008761\nTask: 42128\nChange-Id: Ib1415cadbbfab874a8d44ac6b5c6fba3c7502242\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8f38a1c45f78deb0f1f3858a601e2a487a2ef378"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8f38a1c45f78deb0f1f3858a601e2a487a2ef378"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}