)]}'
{"id":"openstack%2Fopenstack-helm~786821","triplet_id":"openstack%2Fopenstack-helm~master~If947be6cd400e32d3455f07a85f4263c4b17cb87","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"If947be6cd400e32d3455f07a85f4263c4b17cb87","subject":"Fix the nova-compute-ironic label issue","status":"MERGED","created":"2021-04-19 07:21:51.000000000","updated":"2021-04-20 06:32:46.000000000","submitted":"2021-04-20 05:43:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"786821","meta_rev_id":"607784ce053ed97fd2a495a37c5cecb813fd12b9","_number":786821,"virtual_id_number":786821,"owner":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":0,"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-20 05:43:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"recommended":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"all":[{"value":1,"date":"2021-04-19 14:12:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":2,"date":"2021-04-20 04:01:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"value":1,"date":"2021-04-19 12:29:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":2,"date":"2021-04-19 21:02:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-04-19 13:21:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"all":[{"value":0,"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":1,"date":"2021-04-20 04:01:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-19 07:57:33.000000000","updated_by":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-19 12:29:54.000000000","updated_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"reviewer":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"state":"REVIEWER"},{"updated":"2021-04-19 13:21:58.000000000","updated_by":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"reviewer":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"state":"REVIEWER"},{"updated":"2021-04-19 14:12:16.000000000","updated_by":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"reviewer":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"state":"REVIEWER"},{"updated":"2021-04-19 15:20:47.000000000","updated_by":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"reviewer":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"state":"REVIEWER"},{"updated":"2021-04-19 21:02:16.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"}],"messages":[{"id":"67025d9b2e415b65623f8bfc690d12133ff6bf9d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"date":"2021-04-19 07:21:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c53f4f155c752f5515d0506c31063161ea5d7df4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-19 08:14:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/abecc81d60cf42f5ba54eef60573be1f : SUCCESS in 5m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7620bb8d90194f4e8f5fdc99d645bb5c : SUCCESS in 4m 00s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/d5f45e778523413797703481cfd73bc5 : SUCCESS in 5m 07s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/77989b1a3ec2408eaf7f46dc47046b76 : SUCCESS in 42m 51s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/0c6ff43262c84161925752d00b02a175 : SUCCESS in 43m 45s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/17b81fd454bb474d8d9077dc0852957c : SUCCESS in 48m 16s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/9f434b76d6b04dfd8e85e6cf153eebd3 : SUCCESS in 47m 56s","accounts_in_message":[],"_revision_number":1},{"id":"006cfa26d09457c4b83cb63ffe67581e1f3b2645","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2021-04-19 12:29:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"463262ef7309f834f63f3859c8ad80405b4a3b31","author":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"date":"2021-04-19 13:21:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"393b7e664adee514f91d27b6be2abec01f83092c","author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"date":"2021-04-19 14:12:16.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0412a18e518f02ddec3bedba2b39d817a1d6b4db","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-04-19 21:02:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2c85b9a1e1244c4fbe8a723af42e993ebf37173f","author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"date":"2021-04-20 04:01:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI am ok with this change itself, but the chart seems lacking a bit in supporting compute ironic, I suspect you may bump into further issue is some of the dependency is not satisfied properly.  Maybe a value override for ironic is in order.  Some of the observations I made below is from here (https://fuel-ccp.readthedocs.io/en/latest/ironic.html)\n- It requires neutron-openvswitch-agent running on same host (currently no such dependency defined)\n- Is not possible to deploy nova-compute-ironic and regular nova-compute on same host (this may mean we should define a new node-selector-key for ironic so it can be separated from compute).","accounts_in_message":[],"_revision_number":1},{"id":"c5104bc268dc434bfbdb236fcd315da0c9490e18","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 04:02:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a6f50b7fc0adf82f865e1d2ab5398fcd7ecdfe71","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 05:43:12.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/20bff493984141e89d79f373f04a6c8f : SUCCESS in 5m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1a6a9251b9ef4b29bfc535e881b95ff0 : SUCCESS in 3m 56s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/4c15235e25494fa0bb61f7d9471e96bf : SUCCESS in 5m 17s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/c1ee138d992d4b5a99845f04f2e36db2 : FAILURE in 37m 16s (non-voting)\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/da419fd4b47746bbb6539858c7540321 : SUCCESS in 44m 42s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a174b2744b7843579c6cdd759f73b112 : SUCCESS in 47m 55s\n- openstack-helm-multinode-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/2336caa020df4e1abf06f27c569b2baf : SUCCESS in 1h 39m 22s\n- openstack-helm-multinode-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/26bded73284b4a80b88353cea83c0b8f : SUCCESS in 1h 29m 50s","accounts_in_message":[],"_revision_number":1},{"id":"400e87e3806f4adcf2ab2412ee3f9c4f492ea3fa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 05:43:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a47c74199a13cc4495545d145ca5302c756a50f8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-20 05:44:40.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dca72cd5f7534c088d6cd3eb39f9bc04 : SUCCESS in 1m 01s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f57c3979ef1749028adecd26521e77e3 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":1},{"id":"607784ce053ed97fd2a495a37c5cecb813fd12b9","author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"date":"2021-04-20 06:32:46.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review+2 Workflow+1\n\u003e \n\u003e I am ok with this change itself, but the chart seems lacking a bit in supporting compute ironic, I suspect you may bump into further issue is some of the dependency is not satisfied properly.  Maybe a value override for ironic is in order.  Some of the observations I made below is from here (https://fuel-ccp.readthedocs.io/en/latest/ironic.html)\n\u003e - It requires neutron-openvswitch-agent running on same host (currently no such dependency defined)\n\u003e - Is not possible to deploy nova-compute-ironic and regular nova-compute on same host (this may mean we should define a new node-selector-key for ironic so it can be separated from compute).\n\nYes, there are many problems with ironic . My local program uses the ironic-inspector project also. Ironic has made a lot of changes based on the R version, which is far from the community version. Therefore, I can only submit some obvious errors.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1fda67d9cd29ec6b348c69f8e0b55b5e4b91b266","revisions":{"1fda67d9cd29ec6b348c69f8e0b55b5e4b91b266":{"kind":"REWORK","_number":1,"created":"2021-04-19 07:21:51.000000000","uploader":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"ref":"refs/changes/21/786821/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/21/786821/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/21/786821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/21/786821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/21/786821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/21/786821/1"}}},"commit":{"parents":[{"commit":"46f4343f19c5f783380cf4444a9ffcb82bd4ceda","subject":"[Neutron] Update Rally tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/46f4343f19c5f783380cf4444a9ffcb82bd4ceda"}]}],"author":{"name":"jinyuan","email":"liujinyuan@inspur.com","date":"2021-04-19 07:18:00.000000000","tz":480},"committer":{"name":"jinyuan","email":"liujinyuan@inspur.com","date":"2021-04-19 07:21:37.000000000","tz":480},"subject":"Fix the nova-compute-ironic label issue","message":"Fix the nova-compute-ironic label issue\n\nThe nova-compute-ironic label is \"compute\", but the label chosen by affinity is \"compute-ironic\", which results in multiple replicas on the same node.\n\nChange-Id: If947be6cd400e32d3455f07a85f4263c4b17cb87\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1fda67d9cd29ec6b348c69f8e0b55b5e4b91b266"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1fda67d9cd29ec6b348c69f8e0b55b5e4b91b266"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}