)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"76ca253370581effb9ac27ecea95dbe4579a0fcc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Marlin Cremers \u003cmarlin@cbws.nl\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-23 23:59:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(nova): add serial console support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6db64661d7e7f5c3b2cffe38c00155a6dadd2f3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6e912435_860732d2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2021-04-23 22:12:41.000000000","message":"Can you add some more information about what adding console support here is good for?","commit_id":"afcc37381ef52c08484f2c02b361a6fd8f089d1a"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"0e928864647f4b85261286f35a72d2505e49fd15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marlin Cremers \u003cmarlin@cbws.nl\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-23 23:59:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(nova): add serial console support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6db64661d7e7f5c3b2cffe38c00155a6dadd2f3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"13875a73_2415df4a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"in_reply_to":"34ba81b9_1cf1e4e3","updated":"2021-04-23 22:58:48.000000000","message":"Done","commit_id":"afcc37381ef52c08484f2c02b361a6fd8f089d1a"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"30498c4ba5a7cc45c6f0f644cfebe4e75d1de635","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Marlin Cremers \u003cmarlin@cbws.nl\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-23 23:59:06 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(nova): add serial console support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6db64661d7e7f5c3b2cffe38c00155a6dadd2f3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"34ba81b9_1cf1e4e3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"in_reply_to":"6e912435_860732d2","updated":"2021-04-23 22:15:19.000000000","message":"Hey Gage,\n\nYes will do so!","commit_id":"afcc37381ef52c08484f2c02b361a6fd8f089d1a"}],"nova/templates/bin/_nova-compute-init.sh.tpl":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"46d560057b07e5f31231115853b5d2c3b9e9e2b3","unresolved":true,"context_lines":[{"line_number":54,"context_line":"[DEFAULT]"},{"line_number":55,"context_line":"my_ip  \u003d $hypervisor_address"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[serial_console]"},{"line_number":58,"context_line":"proxyclient_address \u003d $hypervisor_address"},{"line_number":59,"context_line":"EOF"},{"line_number":60,"context_line":"{{- if and ( empty .Values.conf.nova.DEFAULT.host ) ( .Values.pod.use_fqdn.compute ) }}"},{"line_number":61,"context_line":"tee \u003e /tmp/pod-shared/nova-compute-fqdn.conf \u003c\u003c EOF"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"933a469c_8643f1f0","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":41},"updated":"2021-04-26 14:48:41.000000000","message":"How about adding this entry into conf file only when serial console is enabled in values.yaml?","commit_id":"cee05ad5602ebe28641ec165f873a7d6a2d1f031"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"8eaebcb6d8b84193b5a541ccd79f210bf6b84102","unresolved":true,"context_lines":[{"line_number":54,"context_line":"[DEFAULT]"},{"line_number":55,"context_line":"my_ip  \u003d $hypervisor_address"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"[serial_console]"},{"line_number":58,"context_line":"proxyclient_address \u003d $hypervisor_address"},{"line_number":59,"context_line":"EOF"},{"line_number":60,"context_line":"{{- if and ( empty .Values.conf.nova.DEFAULT.host ) ( .Values.pod.use_fqdn.compute ) }}"},{"line_number":61,"context_line":"tee \u003e /tmp/pod-shared/nova-compute-fqdn.conf \u003c\u003c EOF"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"26c39718_f517e2a6","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":41},"in_reply_to":"933a469c_8643f1f0","updated":"2021-04-26 14:58:06.000000000","message":"Good one, will look into this as well!","commit_id":"cee05ad5602ebe28641ec165f873a7d6a2d1f031"}],"nova/templates/bin/_nova-console-proxy.sh.tpl":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"46d560057b07e5f31231115853b5d2c3b9e9e2b3","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"console_kind\u003d\"{{- .Values.console.console_kind -}}\""},{"line_number":20,"context_line":"if [ \"${console_kind}\" \u003d\u003d \"novnc\" ] ; then"},{"line_number":21,"context_line":"    exec nova-novncproxy \\"},{"line_number":22,"context_line":"        --config-file /etc/nova/nova.conf \\"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"81409f60_75a7ff13","side":"PARENT","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":51},"updated":"2021-04-26 14:48:41.000000000","message":"How about continue using this statement instead of exporting environment variable in all the console deployments?","commit_id":"16098031c5c8921ad353f89c7025a3f4c72b1a7e"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"8eaebcb6d8b84193b5a541ccd79f210bf6b84102","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -x"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"console_kind\u003d\"{{- .Values.console.console_kind -}}\""},{"line_number":20,"context_line":"if [ \"${console_kind}\" \u003d\u003d \"novnc\" ] ; then"},{"line_number":21,"context_line":"    exec nova-novncproxy \\"},{"line_number":22,"context_line":"        --config-file /etc/nova/nova.conf \\"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"216b13db_a2878be8","side":"PARENT","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":51},"in_reply_to":"81409f60_75a7ff13","updated":"2021-04-26 14:58:06.000000000","message":"The current implementation only supports one console kind, either novnc, spice or serial. By adding the CONSOLE_KIND variable to the different proxies we can actually support having both novnc and serial enabled at the same time.","commit_id":"16098031c5c8921ad353f89c7025a3f4c72b1a7e"},{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"46d560057b07e5f31231115853b5d2c3b9e9e2b3","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    exec nova-serialproxy\\"},{"line_number":25,"context_line":"        --config-file /etc/nova/nova.conf \\"},{"line_number":26,"context_line":"        --config-file /tmp/pod-shared/nova-serial.ini"},{"line_number":27,"context_line":"elif [ \"${CONSOLE_KIND}\" \u003d\u003d \"spice\" ] ; then"},{"line_number":28,"context_line":"    exec nova-spicehtml5proxy\\"},{"line_number":29,"context_line":"        --config-file /etc/nova/nova.conf \\"},{"line_number":30,"context_line":"        --config-file /tmp/pod-shared/nova-spice.ini"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"95e1bc13_eca3e117","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":44},"updated":"2021-04-26 14:48:41.000000000","message":"Does not this require exporting CONSOLE_KIND in spice proxy deployment manifest as well?","commit_id":"cee05ad5602ebe28641ec165f873a7d6a2d1f031"},{"author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"change_message_id":"8eaebcb6d8b84193b5a541ccd79f210bf6b84102","unresolved":true,"context_lines":[{"line_number":24,"context_line":"    exec nova-serialproxy\\"},{"line_number":25,"context_line":"        --config-file /etc/nova/nova.conf \\"},{"line_number":26,"context_line":"        --config-file /tmp/pod-shared/nova-serial.ini"},{"line_number":27,"context_line":"elif [ \"${CONSOLE_KIND}\" \u003d\u003d \"spice\" ] ; then"},{"line_number":28,"context_line":"    exec nova-spicehtml5proxy\\"},{"line_number":29,"context_line":"        --config-file /etc/nova/nova.conf \\"},{"line_number":30,"context_line":"        --config-file /tmp/pod-shared/nova-spice.ini"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"0ef8382f_229e3d00","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":44},"in_reply_to":"95e1bc13_eca3e117","updated":"2021-04-26 14:58:06.000000000","message":"Good one, will look into that!","commit_id":"cee05ad5602ebe28641ec165f873a7d6a2d1f031"}]}