)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e435500101c268450afad2c60fa7e9fdf11cb9b4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adjust nova\u0027s discover_hosts mechanism"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is no \"--by-service\", some hosts cannot be discovered automatically, which is very unfriendly to the discovery of baremetal."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3f01caaac1c2ed1b53eaec76ab1988e16073f0ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bd1c2a6e_0c5b421d","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":71},"updated":"2021-04-30 07:34:10.000000000","message":"reflow","commit_id":"c8dc0244c58b2fe6efc97ab727130fc13631501b"}],"nova/templates/bin/_cell-setup.sh.tpl":[{"author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"change_message_id":"8a02b4623848e6b561c51b7d56d6f77e5a4da472","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# accordingly. Support was complete in ocata (V14.x.x)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ \"${NOVA_VERSION%%.*}\" -gt \"14\" ]; then"},{"line_number":25,"context_line":"  nova-manage cell_v2 discover_hosts --by-service --verbose"},{"line_number":26,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"07d40090_23b4c486","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":49},"updated":"2021-04-27 14:43:49.000000000","message":"This seems applicable only for Ironic driver. Nova documentation does not talk about what happens when this option is used with libvirt.LibvirtDriver. \n\nHas this been validated with libvirt.LibvirtDriver? Would like \"--by-service\" be used only when Ironic is used.","commit_id":"2a789e0d8e2464b88d7135da6ccd353ad9f4dfc0"},{"author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"change_message_id":"92e0ebd98e38433005d8162c20d0d61fafd53090","unresolved":true,"context_lines":[{"line_number":22,"context_line":"# accordingly. Support was complete in ocata (V14.x.x)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ \"${NOVA_VERSION%%.*}\" -gt \"14\" ]; then"},{"line_number":25,"context_line":"  nova-manage cell_v2 discover_hosts --by-service --verbose"},{"line_number":26,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"97891b7c_b0d0f63c","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":49},"in_reply_to":"07d40090_23b4c486","updated":"2021-04-28 02:10:40.000000000","message":"You are right. In the previous version, Nova DisCover_Host will take this parameter by default, but now it is changed into only ironic, which is more standard. I will make some modifications here","commit_id":"2a789e0d8e2464b88d7135da6ccd353ad9f4dfc0"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e435500101c268450afad2c60fa7e9fdf11cb9b4","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"${NOVA_VERSION%%.*}\" -gt \"14\" ]; then"},{"line_number":29,"context_line":"  nova-manage cell_v2 discover_hosts --verbose \\"},{"line_number":30,"context_line":"  ${OPTIONS}"},{"line_number":31,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"2feeee92_727cfa71","line":30,"range":{"start_line":29,"start_character":47,"end_line":30,"end_character":12},"updated":"2021-04-30 07:34:10.000000000","message":"1 line?","commit_id":"c8dc0244c58b2fe6efc97ab727130fc13631501b"},{"author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"change_message_id":"762ef588899f3205d6b008a7411414443673e104","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"${NOVA_VERSION%%.*}\" -gt \"14\" ]; then"},{"line_number":29,"context_line":"  nova-manage cell_v2 discover_hosts --verbose \\"},{"line_number":30,"context_line":"  ${OPTIONS}"},{"line_number":31,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"942af94c_01077ae1","line":30,"range":{"start_line":29,"start_character":47,"end_line":30,"end_character":12},"in_reply_to":"2feeee92_727cfa71","updated":"2021-04-30 08:18:55.000000000","message":"It is one line. Ironic is sure that there is a problem with discover host, but I feel that this modification is still not very good. I will modify it when I have time. I will change it to WIP status first.","commit_id":"c8dc0244c58b2fe6efc97ab727130fc13631501b"}]}