)]}'
{"cinder/templates/bin/_bootstrap.sh.tpl":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5fe0c1e5cb8a045f05bdfac44c771829bf880bb1","unresolved":true,"context_lines":[{"line_number":59,"context_line":"type_defined\u003dtrue"},{"line_number":60,"context_line":"      {{- /* If the volume type to associate with is not defined, skip the qos */}}"},{"line_number":61,"context_line":"      {{- range $qos_properties.associates }}"},{"line_number":62,"context_line":"if ! openstack volume type show {{ . }}; then"},{"line_number":63,"context_line":"  type_defined\u003dfalse"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":"      {{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"8620c642_c156c30e","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":45},"updated":"2021-07-15 18:42:23.000000000","message":"is this supposed to be only for PURE?  also is it possible to combine this loop with the loop above, then you can just create the volume type and add qos if it is PURE","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"334452b1b06741d1a88193f0f07d23558a20de30","unresolved":true,"context_lines":[{"line_number":59,"context_line":"type_defined\u003dtrue"},{"line_number":60,"context_line":"      {{- /* If the volume type to associate with is not defined, skip the qos */}}"},{"line_number":61,"context_line":"      {{- range $qos_properties.associates }}"},{"line_number":62,"context_line":"if ! openstack volume type show {{ . }}; then"},{"line_number":63,"context_line":"  type_defined\u003dfalse"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":"      {{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"96ed20e7_bb5bec52","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":45},"in_reply_to":"5e65871b_b3da5fbe","updated":"2021-07-15 22:40:12.000000000","message":"ok I see this may be needed for BF, but I am just saying the loop above you is showing or creating types that is not there, so seems safe to me to simply add the qos code up above is all I am saying.","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"607e648a0d1b387baeb89634d43b6d2f1eb9ceb5","unresolved":true,"context_lines":[{"line_number":59,"context_line":"type_defined\u003dtrue"},{"line_number":60,"context_line":"      {{- /* If the volume type to associate with is not defined, skip the qos */}}"},{"line_number":61,"context_line":"      {{- range $qos_properties.associates }}"},{"line_number":62,"context_line":"if ! openstack volume type show {{ . }}; then"},{"line_number":63,"context_line":"  type_defined\u003dfalse"},{"line_number":64,"context_line":"fi"},{"line_number":65,"context_line":"      {{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5e65871b_b3da5fbe","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":45},"in_reply_to":"8620c642_c156c30e","updated":"2021-07-15 19:09:58.000000000","message":"No. It can be used for different other types as well\nI need the logic for \"if the type is not defined, don\u0027t create the qos.\" So I have to add this logic after all the types are created.","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"}],"cinder/values.yaml":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"5fe0c1e5cb8a045f05bdfac44c771829bf880bb1","unresolved":true,"context_lines":[{"line_number":361,"context_line":"    name:"},{"line_number":362,"context_line":"      group:"},{"line_number":363,"context_line":"      volume_backend_name:"},{"line_number":364,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":365,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":366,"context_line":"  # with real names."},{"line_number":367,"context_line":"  # volume_qos:"},{"line_number":368,"context_line":"  #   qos_name_1:"},{"line_number":369,"context_line":"  #     consumer: front-end"},{"line_number":370,"context_line":"  #     properties:"},{"line_number":371,"context_line":"  #       key_1: value_1"},{"line_number":372,"context_line":"  #       key_2: value_2"},{"line_number":373,"context_line":"  #     associates:"},{"line_number":374,"context_line":"  #       - volume_type_1"},{"line_number":375,"context_line":"  #       - volume_type_2"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"network:"},{"line_number":378,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"60c83c69_5647dd37","line":375,"range":{"start_line":364,"start_character":2,"end_line":375,"end_character":25},"updated":"2021-07-15 18:42:23.000000000","message":"Is there a need to separate out different qos config based on volume type?  in case we may want qos only on certain type, or maybe we want different qos mapping for different type?","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"},{"author":{"_account_id":18236,"name":"Sophie Huang","email":"sophieh01@yahoo.com","username":"SophieHuang"},"change_message_id":"607e648a0d1b387baeb89634d43b6d2f1eb9ceb5","unresolved":true,"context_lines":[{"line_number":361,"context_line":"    name:"},{"line_number":362,"context_line":"      group:"},{"line_number":363,"context_line":"      volume_backend_name:"},{"line_number":364,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":365,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":366,"context_line":"  # with real names."},{"line_number":367,"context_line":"  # volume_qos:"},{"line_number":368,"context_line":"  #   qos_name_1:"},{"line_number":369,"context_line":"  #     consumer: front-end"},{"line_number":370,"context_line":"  #     properties:"},{"line_number":371,"context_line":"  #       key_1: value_1"},{"line_number":372,"context_line":"  #       key_2: value_2"},{"line_number":373,"context_line":"  #     associates:"},{"line_number":374,"context_line":"  #       - volume_type_1"},{"line_number":375,"context_line":"  #       - volume_type_2"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"network:"},{"line_number":378,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c03c1c84_858f7623","line":375,"range":{"start_line":364,"start_character":2,"end_line":375,"end_character":25},"in_reply_to":"60c83c69_5647dd37","updated":"2021-07-15 19:09:58.000000000","message":"The current design allows both one qos per type and one qos for multiple types.","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"334452b1b06741d1a88193f0f07d23558a20de30","unresolved":true,"context_lines":[{"line_number":361,"context_line":"    name:"},{"line_number":362,"context_line":"      group:"},{"line_number":363,"context_line":"      volume_backend_name:"},{"line_number":364,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":365,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":366,"context_line":"  # with real names."},{"line_number":367,"context_line":"  # volume_qos:"},{"line_number":368,"context_line":"  #   qos_name_1:"},{"line_number":369,"context_line":"  #     consumer: front-end"},{"line_number":370,"context_line":"  #     properties:"},{"line_number":371,"context_line":"  #       key_1: value_1"},{"line_number":372,"context_line":"  #       key_2: value_2"},{"line_number":373,"context_line":"  #     associates:"},{"line_number":374,"context_line":"  #       - volume_type_1"},{"line_number":375,"context_line":"  #       - volume_type_2"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"network:"},{"line_number":378,"context_line":"  api:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"016946db_7ffc7143","line":375,"range":{"start_line":364,"start_character":2,"end_line":375,"end_character":25},"in_reply_to":"c03c1c84_858f7623","updated":"2021-07-15 22:40:12.000000000","message":"can you also add an example override for this?  That will help clarify how this may work.","commit_id":"08ef65bb890206e81a64c119b5c653d26576bf7f"}]}