)]}'
{"id":"openstack%2Fopenstack-helm~801043","triplet_id":"openstack%2Fopenstack-helm~master~If92f5d038badda5d8a771894d2b27232b7f5e396","project":"openstack/openstack-helm","branch":"master","topic":"auto-detect-worker","hashtags":[],"change_id":"If92f5d038badda5d8a771894d2b27232b7f5e396","subject":"Auto detect workers number of metadata_workers and osapi_compute_workers","status":"ABANDONED","created":"2021-07-16 10:14:42.000000000","updated":"2021-07-28 08:56:24.000000000","total_comment_count":6,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"35865ff830688fa91dda71aa48528d9000f21832","_number":801043,"virtual_id_number":801043,"owner":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-07-16 15:41:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-07-27 17:22:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"value":-1,"date":"2021-07-16 16:44:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-16 11:02:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-16 15:48:37.000000000","updated_by":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2021-07-16 15:48:37.000000000","updated_by":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2021-07-16 16:44:43.000000000","updated_by":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"reviewer":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"state":"REVIEWER"},{"updated":"2021-07-27 17:22:41.000000000","updated_by":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"reviewer":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"state":"REVIEWER"}],"messages":[{"id":"d2128ece39f9053537f0b903ec8cf7ddadc7ba4a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-16 10:14:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c9d56a478fbb10915dd9f472ce5773e8046a7d5e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-16 11:02:52.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/24d41720903b46e3b2400e0eede6468f : SUCCESS in 7m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/648160d08e6f4e2b98346c08d1814405 : SUCCESS in 4m 43s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/6859c375126b40b99eddd1312f5ca520 : SUCCESS in 6m 27s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/cbe5027061c340a6b690f7d2661dc51f : SUCCESS in 46m 41s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/0882bad5793d460ab47da677379e8d49 : SUCCESS in 46m 13s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/d65a539636d94c2eb214a2542f62718f : FAILURE in 44m 59s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/84a53a2e53b14d28b1077bb99b3aea6e : FAILURE in 45m 53s","accounts_in_message":[],"_revision_number":1},{"id":"e67f776a7e94e701d6315fcb8fa63000d0f0a387","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-16 12:25:58.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"7519726a8cdaa638d29f551841ea6c5f97d8ddd2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-16 13:11:34.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df9a258214c6457bbbf32d3915c55419 : SUCCESS in 5m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d790f71e047444079d5789fa5dd35a13 : SUCCESS in 4m 23s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/d710bdc4ffa24212bd1f3bd366c07fef : SUCCESS in 5m 02s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/92cd531e4e184aee803c70bb67ab8bcc : SUCCESS in 42m 12s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a7a2a4f3ea564152832fc57992f40fe3 : SUCCESS in 44m 35s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/5c287773b5374ec7a6748bca0669e769 : FAILURE in 43m 15s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/243948bfa5484620b0ee4b43b611dc79 : FAILURE in 42m 01s","accounts_in_message":[],"_revision_number":1},{"id":"0c7ac67913de93adfcb791df181d17e64bc0656e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-16 14:46:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"540fd0e0a552f3e04e6f81b08b01638c9c872d7f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-16 15:41:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8247f7543434078af18991cc716403b : SUCCESS in 6m 21s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/cd1378e8d3214f458ae37405b4df3a5f : SUCCESS in 4m 27s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/0b917e116fcc4ec8ab7255ba0dcda464 : SUCCESS in 5m 26s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/b1fbb80c6c14463ca65ee55f51837b5b : SUCCESS in 48m 05s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/43f8b2be3ec143a3ab371b895ca68978 : SUCCESS in 44m 29s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/3220acc4c2e74007b59cb4400b98142b : SUCCESS in 53m 05s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/0037ba6faed5490fa1542c60f0eaaed1 : SUCCESS in 48m 38s","accounts_in_message":[],"_revision_number":2},{"id":"6e8338386d29de1dc0a817b3fc72438aeba6ece1","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-16 15:48:37.000000000","message":"Patch Set 2:\n\nCan you please check this patch that gets the worker count for metadata_workers and osapi_compute_workers. I have made changes with regarding to the comments that have been made in the patch https://review.opendev.org/c/openstack/openstack-helm/+/797514. About the comment you mentioned about that if the application being deployed in huge meachine, worker count be +20, the only suggestion i can think of is, either we leave the default count to 1 for both or have the auto in values and client can assign the workers count in values.yaml. Can you give me some thoughts on it please?","accounts_in_message":[],"_revision_number":2},{"id":"4814ca484ceb2f89fc7f6b6d17f82fc12149772a","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-07-16 16:03:54.000000000","message":"Patch Set 2:\n\nWhy is this needed though?\n\nThe default is ncpu, and you can override the values on your deployment for whatever value you need.","accounts_in_message":[],"_revision_number":2},{"id":"6eaf7dec8da9e8852bb207f944e93ccbbd9431ed","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-07-16 16:04:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a708eef6c488f755546a11e8a93bb86105b35cdd","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-16 16:23:01.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e Patch Set 2:\n\u003e \n\u003e Why is this needed though?\n\u003e \n\u003e The default is ncpu, and you can override the values on your deployment for whatever value you need.\n\n\u003e About the reason we need this is, as currently nova chart have metadata_workers and osapi_compute_workers 1 by default in values.yaml. REF: https://opendev.org/openstack/openstack-helm/src/branch/master/nova/values.yaml#L1693-L1694. This value will render the worker count as 1 in nova.conf and nova-compute.conf file leaving out the possibility of using the workers count as (nproc). As for specific reason for us to need this is this we want the more easier way to have the workers count when we are rolling out the openstack in different cloud or environment.","accounts_in_message":[],"_revision_number":2},{"id":"653d5d9804c023c07bdec0649d2c2060be56d24f","author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"date":"2021-07-16 16:44:43.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"25686a7a5c9902d683f2b2c35c4a95cd088b9b1b","author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"date":"2021-07-16 16:51:00.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"782844db4f1027e4a6036cfd0d07ad004761d3e8","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-20 08:17:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"a00ed7a88948117b3ab4e1088b536e4b78b0ca6a","author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"date":"2021-07-27 17:22:41.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nRecently, we have observed a high number of connection timeouts between nova osapi and rabbitmq when the number of osapi_compute_workers is set \u003e 1.  There seems to be some issue with how heartbeats are handled (or mis-handled) in such cases.  The investigation is still ongoing.","accounts_in_message":[],"_revision_number":2},{"id":"c28f693a67f513a278973ab2ec8c58d0daf5edb9","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-28 08:55:08.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Recently, we have observed a high number of connection timeouts between nova osapi and rabbitmq when the number of osapi_compute_workers is set \u003e 1.  There seems to be some issue with how heartbeats are handled (or mis-handled) in such cases.  The investigation is still ongoing.\n\n\u003e Thank you for your reply. I have gone through the discussion on the channel and find that having one process per pod is good. So i will be abandoning this PS. Also i have found that some module have the worker process different then 1. I will make the PS for them while changing them to 1 so that we can run one process per pod. Thank You","accounts_in_message":[],"_revision_number":2},{"id":"35865ff830688fa91dda71aa48528d9000f21832","tag":"autogenerated:gerrit:abandon","author":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"date":"2021-07-28 08:56:24.000000000","message":"Abandoned\n\nAs per the discussion in the channel, having one process per pod and scaling it seems to be best solution. For that reason, this PS along with the one for heat will be abandoned.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"513e7866693574259ec37ac85f2e1671849dae51","revisions":{"79ad81dac12891d03ef99395ce92b263e96c4daa":{"kind":"REWORK","_number":1,"created":"2021-07-16 10:14:42.000000000","uploader":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"ref":"refs/changes/43/801043/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/43/801043/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/1"}}},"commit":{"parents":[{"commit":"27e12b88ad41ed0f092cbedd58664232eb34fe7c","subject":"Fix neutron-openvswitch-agent-init script","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/27e12b88ad41ed0f092cbedd58664232eb34fe7c"}]}],"author":{"name":"xuxant02@gmail.com","email":"xuxant02@gmail.com","date":"2021-07-16 10:06:11.000000000","tz":345},"committer":{"name":"xuxant02@gmail.com","email":"xuxant02@gmail.com","date":"2021-07-16 10:09:09.000000000","tz":345},"subject":"Auto detect workers number of metadata_workers and osapi_compute_workers","message":"Auto detect workers number of metadata_workers and osapi_compute_workers\n\nAdded init script that will calculate the numbers of workers count to be used\nin metadata_workers and osapi_compute_workers. When value auto is provided to\nthese two keys, workers count will be calculated by script. Workers count is\nvalue return by nproc(cpu_count) divided by 4. Other int value can be provided\nif workers count is not needed to calculated automatically.\n\nChange-Id: If92f5d038badda5d8a771894d2b27232b7f5e396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/79ad81dac12891d03ef99395ce92b263e96c4daa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/79ad81dac12891d03ef99395ce92b263e96c4daa"}]},"branch":"refs/heads/master"},"513e7866693574259ec37ac85f2e1671849dae51":{"kind":"REWORK","_number":2,"created":"2021-07-16 14:46:40.000000000","uploader":{"_account_id":33130,"name":"Susanta gautam","email":"xuxant02@gmail.com","username":"sgautam"},"ref":"refs/changes/43/801043/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/43/801043/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/43/801043/2"}}},"commit":{"parents":[{"commit":"27e12b88ad41ed0f092cbedd58664232eb34fe7c","subject":"Fix neutron-openvswitch-agent-init script","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/27e12b88ad41ed0f092cbedd58664232eb34fe7c"}]}],"author":{"name":"xuxant02@gmail.com","email":"xuxant02@gmail.com","date":"2021-07-16 10:06:11.000000000","tz":345},"committer":{"name":"xuxant02@gmail.com","email":"xuxant02@gmail.com","date":"2021-07-16 14:46:25.000000000","tz":345},"subject":"Auto detect workers number of metadata_workers and osapi_compute_workers","message":"Auto detect workers number of metadata_workers and osapi_compute_workers\n\nAdded init script that will calculate the numbers of workers count to be used\nin metadata_workers and osapi_compute_workers. When value auto is provided to\nthese two keys, workers count will be calculated by script. Workers count is\nvalue return by nproc(cpu_count) divided by 4. Other int value can be provided\nif workers count is not needed to calculated automatically.\n\nChange-Id: If92f5d038badda5d8a771894d2b27232b7f5e396\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/513e7866693574259ec37ac85f2e1671849dae51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/513e7866693574259ec37ac85f2e1671849dae51"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}