)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a3f5da6fe5a290b03a6be2bfa3604f409e081722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c2396b0_5a633293","updated":"2021-11-09 19:37:38.000000000","message":"I realize it\u0027s WIP, but since you asked me to look, I have just a couple of minor comments. But I like this change, it makes alot of sense.","commit_id":"57028418f07f64ea2052008259105c8609ab527a"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"de2446bc1af2c620573469504363fa5f0d040fa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ae96a5a_cb05acc1","updated":"2021-11-10 15:09:38.000000000","message":"Looks like there is already some solution in place for this:\nhttps://review.opendev.org/c/openstack/openstack-helm/+/815086\nhttps://review.opendev.org/c/openstack/openstack-helm/+/815700","commit_id":"57028418f07f64ea2052008259105c8609ab527a"}],"nova/templates/bin/_cell-compute-count-init.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a3f5da6fe5a290b03a6be2bfa3604f409e081722","unresolved":true,"context_lines":[{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# This runs in a cell setup init container. It counts the number of compute nodes."},{"line_number":20,"context_line":"COMPUTE_NODES\u003d$(kubectl get nodes -o custom-columns\u003dNAME:.metadata.name -l openstack-compute-node\u003denabled --no-headers | sort)"},{"line_number":21,"context_line":"/bin/echo $COMPUTE_NODES \u003e /tmp/compute_nodes.txt"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"a2bc7bdc_7305254b","line":20,"range":{"start_line":20,"start_character":72,"end_line":20,"end_character":105},"updated":"2021-11-09 19:37:38.000000000","message":"I think we\u0027d want to use whatever label is defined in labels.agent.compute:node_selector_key (\"openstack-compute-node\" is the upstream value) instead of hardcoding this.","commit_id":"57028418f07f64ea2052008259105c8609ab527a"}],"nova/templates/bin/_cell-setup-init.sh.tpl":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"a3f5da6fe5a290b03a6be2bfa3604f409e081722","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  exit 1"},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"COMPUTE_SERVICES\u003d$(openstack compute service list --service nova-compute -f value -c State | grep -c \"^up$\")"},{"line_number":26,"context_line":"while [[ $COMPUTE_SERVICES -lt $COMPUTE_HOSTS ]]; do"},{"line_number":27,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":28,"context_line":"  sleep 10"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"fa5a20dc_905e589d","line":25,"range":{"start_line":25,"start_character":105,"end_line":25,"end_character":106},"updated":"2021-11-09 19:37:38.000000000","message":"for some reason, the \"$\" in the RE doesn\u0027t match any lines, even if all the computes are up. same comment for line 29.","commit_id":"57028418f07f64ea2052008259105c8609ab527a"}]}