)]}'
{"id":"openstack%2Fopenstack-helm~804586","triplet_id":"openstack%2Fopenstack-helm~master~I9800120f58376c755e666a77f0bf5476d9d9337e","project":"openstack/openstack-helm","branch":"master","topic":"tunnel-loopback","hashtags":[],"change_id":"I9800120f58376c755e666a77f0bf5476d9d9337e","subject":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection","status":"ABANDONED","created":"2021-08-15 14:04:21.000000000","updated":"2022-05-16 20:45:00.000000000","total_comment_count":4,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"0528793256a652dcf86292423019d18947bcd32c","_number":804586,"virtual_id_number":804586,"owner":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-08-15 15:02:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"all":[{"value":1,"date":"2021-08-16 16:33:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-15 14:10:04.000000000","updated_by":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2021-08-15 14:10:04.000000000","updated_by":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"reviewer":{"_account_id":18511,"name":"Brian Wickersham","email":"bkw86@bellsouth.net","username":"bw6938"},"state":"REVIEWER"},{"updated":"2021-08-15 14:10:04.000000000","updated_by":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2021-08-15 15:02:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-16 16:33:29.000000000","updated_by":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"reviewer":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"state":"REVIEWER"}],"messages":[{"id":"321a9b16e035afd908cbe3438ac3411b5534b0e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-15 14:04:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f2abc82ab8a7df041c1de056a1e5554f8141985","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-15 14:06:57.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"9ea88b640014fd4a685218390dd8d95e20024495","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-15 14:07:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"acfd1dfe42bbd5b35b33bb58ceba6a2d78b811ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-15 14:11:02.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"ff3efc5b509abffe74e56e9f29767739e43db1a4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-15 15:02:32.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e668d0eab8b42edab9d0974d53c6e5d : SUCCESS in 5m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a7dfcb257abb408896431007a1a0e9a9 : SUCCESS in 3m 55s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/b1671bef8df7492ab617724fb32bb139 : SUCCESS in 5m 14s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/45729294e09a4bd2a3d8b1e65163ba4d : SUCCESS in 45m 27s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/91931b6d248d4f76835d87b4b86a9b1c : SUCCESS in 43m 25s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/9d9cd9e50dc544f2b8f8766c360b50dc : SUCCESS in 51m 06s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/41320edcc77e467db8b47f1672e2bb42 : SUCCESS in 47m 30s","accounts_in_message":[],"_revision_number":4},{"id":"a8521a4606f1e8e62ac67c5207ae9e0dc1932569","author":{"_account_id":18256,"name":"Hemachandra Reddy","email":"hemachandra.reddy@att.com","username":"hr858f"},"date":"2021-08-16 16:33:29.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"ee69182aae7823d25aa9ae369b65433a4afa976f","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-16 16:44:00.000000000","message":"Patch Set 4:\n\nI am not familiar with the Open vSwitch agent (as Open vSwitch is not compatible with FRR based EVPN yet). \n\nI could add it to https://github.com/openstack/openstack-helm/blob/master/neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl#L68 as that function is used here https://github.com/openstack/openstack-helm/blob/master/neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl#L430 but I am not sure if it would bring unexpected consequences for other uses of that function.","accounts_in_message":[],"_revision_number":4},{"id":"7e7deb226b42d302d0212b51ee5a0f4c82be12aa","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-16 16:48:11.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nReplying on the patchset comment instead","accounts_in_message":[],"_revision_number":4},{"id":"d0c48730a83d63f01b0259141558cf06a7404071","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2021-08-20 15:16:11.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9e54893e706e21451ecf7f107e1b48b13738804b","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-08-25 08:34:05.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"36ce46e02090289158ff9ba7d76892bdb3b031f4","author":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"date":"2021-09-23 14:23:18.000000000","message":"Patch Set 4:\n\nChris could you maybe check whether the jq solution I proposed is to your liking so I can include it in the patchset or leave it out and continue with review.","accounts_in_message":[],"_revision_number":4},{"id":"0528793256a652dcf86292423019d18947bcd32c","tag":"autogenerated:gerrit:abandon","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2022-05-16 20:45:00.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"7972cfd44b6042ad5cd530fee60683a105e01304","revisions":{"f2537e19735bf77ed37260c72024aefaded52c93":{"kind":"REWORK","_number":1,"created":"2021-08-15 14:04:21.000000000","uploader":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"ref":"refs/changes/86/804586/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/804586/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/1"}}},"commit":{"parents":[{"commit":"3a5c7afba134edd270bfe2f38adfb93fea14b05f","subject":"[nova] add missing \u0027runlock\u0027 hostMount when enable_scsi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3a5c7afba134edd270bfe2f38adfb93fea14b05f"}]}],"author":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 13:52:48.000000000","tz":120},"committer":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 14:04:19.000000000","tz":120},"subject":"fix: exclude 127.0.0.1 from tunnel ip detection","message":"fix: exclude 127.0.0.1 from tunnel ip detection\n\nChange-Id: I9800120f58376c755e666a77f0bf5476d9d9337e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f2537e19735bf77ed37260c72024aefaded52c93"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/f2537e19735bf77ed37260c72024aefaded52c93"}]},"branch":"refs/heads/master"},"741c4cc652ad4c6734f707b89fca2d7b8d41bd5d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-08-15 14:06:57.000000000","uploader":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"ref":"refs/changes/86/804586/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/804586/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/2"}}},"commit":{"parents":[{"commit":"3a5c7afba134edd270bfe2f38adfb93fea14b05f","subject":"[nova] add missing \u0027runlock\u0027 hostMount when enable_scsi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3a5c7afba134edd270bfe2f38adfb93fea14b05f"}]}],"author":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 13:52:48.000000000","tz":120},"committer":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 14:06:49.000000000","tz":120},"subject":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection","message":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection\n\nThe tunnel ip detection script includes 127.0.0.1 as a valid option\nwhen selecting the tunnel IP addresses. This causes issues when using\nanycast addresses on the loopback interface.\n\nThis change excludes 127.0.0.1 from the selection so only other\naddresses remain. This should not cause issues for existing users\nas its not possible to setup VXLAN tunnels to other nodes with\n127.0.0.1 as tunnel endpoint.\n\nChange-Id: I9800120f58376c755e666a77f0bf5476d9d9337e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/741c4cc652ad4c6734f707b89fca2d7b8d41bd5d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/741c4cc652ad4c6734f707b89fca2d7b8d41bd5d"}]},"branch":"refs/heads/master"},"b981cbb683b7f7a83501dc1c6272d568cefbc899":{"kind":"REWORK","_number":3,"created":"2021-08-15 14:07:55.000000000","uploader":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"ref":"refs/changes/86/804586/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/804586/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/3"}}},"commit":{"parents":[{"commit":"3a5c7afba134edd270bfe2f38adfb93fea14b05f","subject":"[nova] add missing \u0027runlock\u0027 hostMount when enable_scsi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3a5c7afba134edd270bfe2f38adfb93fea14b05f"}]}],"author":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 13:52:48.000000000","tz":120},"committer":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 14:07:44.000000000","tz":120},"subject":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection","message":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection\n\nThe tunnel ip detection script includes 127.0.0.1 as a valid option\nwhen selecting the tunnel IP addresses. This causes issues when using\nanycast addresses on the loopback interface.\n\nThis change excludes 127.0.0.1 from the selection so only other\naddresses remain. This should not cause issues for existing users\nas its not possible to setup VXLAN tunnels to other nodes with\n127.0.0.1 as tunnel endpoint.\n\nChange-Id: I9800120f58376c755e666a77f0bf5476d9d9337e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b981cbb683b7f7a83501dc1c6272d568cefbc899"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b981cbb683b7f7a83501dc1c6272d568cefbc899"}]},"branch":"refs/heads/master"},"7972cfd44b6042ad5cd530fee60683a105e01304":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-08-15 14:11:02.000000000","uploader":{"_account_id":17440,"name":"Marlin Cremers","display_name":"Marlin Cremers","email":"marlin@cbws.nl","username":"mcremers"},"ref":"refs/changes/86/804586/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/86/804586/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/86/804586/4"}}},"commit":{"parents":[{"commit":"3a5c7afba134edd270bfe2f38adfb93fea14b05f","subject":"[nova] add missing \u0027runlock\u0027 hostMount when enable_scsi","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/3a5c7afba134edd270bfe2f38adfb93fea14b05f"}]}],"author":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 13:52:48.000000000","tz":120},"committer":{"name":"Marlin Cremers","email":"marlin@cbws.nl","date":"2021-08-15 14:10:54.000000000","tz":120},"subject":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection","message":"fix(neutron): exclude 127.0.0.1 from tunnel ip detection\n\nThe tunnel ip detection script includes 127.0.0.1 as a valid option\nwhen selecting the tunnel IP addresses. This causes issues when using\nanycast addresses on the loopback interface.\n\nThis change excludes 127.0.0.1 from the selection so only other\naddresses remain. This should not cause issues for existing users\nas it\u0027s not possible to setup VXLAN tunnels to other nodes when\nusing 127.0.0.1 as tunnel endpoint.\n\nChange-Id: I9800120f58376c755e666a77f0bf5476d9d9337e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7972cfd44b6042ad5cd530fee60683a105e01304"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7972cfd44b6042ad5cd530fee60683a105e01304"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}