)]}'
{"id":"openstack%2Fopenstack-helm~813300","triplet_id":"openstack%2Fopenstack-helm~master~Ie438b449a3d9853d786215d40a39c32d164e9950","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"Ie438b449a3d9853d786215d40a39c32d164e9950","subject":"Helm 3 - Fix Additional Job Labels","status":"MERGED","created":"2021-10-10 16:45:47.000000000","updated":"2021-10-10 19:30:47.000000000","submitted":"2021-10-10 19:29:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"813300","meta_rev_id":"f18b1b3a97f8f26afe6da3aa9ac1b30145c12069","_number":813300,"virtual_id_number":813300,"owner":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-10-10 19:29:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":2,"date":"2021-10-10 17:05:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":2,"date":"2021-10-10 19:05:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-10-10 18:15:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":1,"date":"2021-10-10 18:41:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"all":[{"value":1,"date":"2021-10-10 18:22:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"value":0,"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"value":0,"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},{"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-10 17:01:43.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2021-10-10 17:02:30.000000000","updated_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"reviewer":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"state":"REVIEWER"},{"updated":"2021-10-10 18:04:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-10-10 18:15:21.000000000","updated_by":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"reviewer":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"state":"REVIEWER"},{"updated":"2021-10-10 18:41:32.000000000","updated_by":{"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"},"reviewer":{"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"},"state":"REVIEWER"}],"messages":[{"id":"b1173b582f543014419b722dfbb8cf5e689f9140","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-10-10 16:45:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0f488cafbbca98b9402a40e9eb7680109a936bc5","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-10-10 17:01:43.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nSingle approving, simple change","accounts_in_message":[],"_revision_number":1},{"id":"45e104d7cd89842e190c81dfbb6222aca7df9ccb","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2021-10-10 17:02:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ba9e16a6c778552b95b8bf21d7f873473a6a523c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"date":"2021-10-10 17:04:55.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c65f3f7c6bd018221a7cdfd8528185aea80f8e7","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-10-10 17:05:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2b7c37e8546427215caa588a5835fd4cc05f1713","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-10 18:04:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fef3ddf77d8a4768bb8cdcd00c460d70 : SUCCESS in 5m 27s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/85cf70ee6b74446b9aeb22de4ebf3e48 : SUCCESS in 3m 53s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e5819307695f4684b79caf61b844c46f : SUCCESS in 5m 21s\n- openstack-helm-helm3-lint https://zuul.opendev.org/t/openstack/build/075b5fc04e274a57befc32d6eed3862a : SUCCESS in 2m 19s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/a3bce3213eb94cf5ab4ff2d4b58171ea : SUCCESS in 44m 12s\n- openstack-helm-cinder-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/c5fdbdabd53e44fea471b16166f96b87 : SUCCESS in 42m 35s\n- openstack-helm-cinder-victoria-ubuntu_focal https://zuul.opendev.org/t/openstack/build/d4ef0fc1dde24a5ea9b56c11f3342c24 : SUCCESS in 43m 15s\n- openstack-helm-cinder-wallaby-ubuntu_focal https://zuul.opendev.org/t/openstack/build/50f8f18bd22449aeacc4bc2acdada1a5 : SUCCESS in 40m 42s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/488955850d42407a933259ace643e929 : SUCCESS in 54m 07s\n- openstack-helm-compute-kit-ussuri-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/40307233cfcc4513b04d1dffd8ce24e0 : SUCCESS in 44m 21s\n- openstack-helm-compute-kit-victoria-ubuntu_focal https://zuul.opendev.org/t/openstack/build/797aa6639a2046c39b0090703ece236b : SUCCESS in 51m 22s\n- openstack-helm-compute-kit-wallaby-ubuntu_focal https://zuul.opendev.org/t/openstack/build/f97a137306564ed18611fea1b9007a50 : SUCCESS in 52m 03s","accounts_in_message":[],"_revision_number":2},{"id":"2186427452e2c9965e9c47702290353fac8a17d3","author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"date":"2021-10-10 18:15:21.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"97a75cd604925ed91fc47a8b76316db0d1a76b4c","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2021-10-10 18:22:10.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"48de3012d0f1fa04451eccb0617db03cb7f43285","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-10 18:22:35.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9bfba6a7d88363f5aa357627958e3984964231e8","author":{"_account_id":28778,"name":"Dan Crank","email":"danielcrank@microsoft.com","username":"dancrank"},"date":"2021-10-10 18:41:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c758b1cfb8d79356cff296f8954d13c109634121","author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"date":"2021-10-10 19:05:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fd79c18941fc8b77a41390f300d4799bcb9fe55a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-10 19:29:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/288c6a5d46ed4a59a027fc90244360e6 : SUCCESS in 5m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d6cc4decee89461da1af3a576314e6a7 : SUCCESS in 4m 09s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e4ceb1276e9a4d9bab6dd173c213fb10 : SUCCESS in 5m 33s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/dcf841adf24345fbbe8f760a44da51a3 : SUCCESS in 1h 02m 18s\n- openstack-helm-cinder-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/96f0bcf01df049828ab5cc98d66345ab : SUCCESS in 41m 30s\n- openstack-helm-compute-kit-train-ubuntu_bionic https://zuul.opendev.org/t/openstack/build/c39be2879c4c4833bcbfe5917d9a5546 : SUCCESS in 50m 21s","accounts_in_message":[],"_revision_number":2},{"id":"60e132c8eb8a19f86f1822b63fab4159f0c0bfc7","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-10 19:29:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"f18b1b3a97f8f26afe6da3aa9ac1b30145c12069","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-10 19:30:47.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7c99cbc42fc54db3aa91c50c001c4f62 : SUCCESS in 1m 23s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/0b7054b9dc9641c1bb1e3e295d64e958 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7803000a545687ec40b0ddc41d46a6b377dea45f","revisions":{"ed19ebfd2df5b1f23ef4c88e7ea38cd65590e12a":{"kind":"REWORK","_number":1,"created":"2021-10-10 16:45:47.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/00/813300/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/00/813300/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/1"}}},"commit":{"parents":[{"commit":"1e651dc3c38e1e261ec59d9955af2f905f446e02","subject":"Helm 3 - Fix Job Labels","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1e651dc3c38e1e261ec59d9955af2f905f446e02"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-10-10 16:43:58.000000000","tz":-300},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-10-10 16:43:58.000000000","tz":-300},"subject":"Helm 3 - Fix Additional Job Labels","message":"Helm 3 - Fix Additional Job Labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus, for Job templates previously missed, this adds labels matching\nthe underlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: Ie438b449a3d9853d786215d40a39c32d164e9950\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ed19ebfd2df5b1f23ef4c88e7ea38cd65590e12a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ed19ebfd2df5b1f23ef4c88e7ea38cd65590e12a"}]},"branch":"refs/heads/master"},"7803000a545687ec40b0ddc41d46a6b377dea45f":{"kind":"REWORK","_number":2,"created":"2021-10-10 17:04:55.000000000","uploader":{"_account_id":28275,"name":"Darren DeJaeger","email":"darren.dejaeger@gmail.com","username":"darren.dejaeger"},"ref":"refs/changes/00/813300/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/00/813300/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/00/813300/2"}}},"commit":{"parents":[{"commit":"1e651dc3c38e1e261ec59d9955af2f905f446e02","subject":"Helm 3 - Fix Job Labels","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1e651dc3c38e1e261ec59d9955af2f905f446e02"}]}],"author":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-10-10 16:43:58.000000000","tz":-300},"committer":{"name":"DeJaeger, Darren (dd118r)","email":"dd118r@att.com","date":"2021-10-10 17:04:49.000000000","tz":-300},"subject":"Helm 3 - Fix Additional Job Labels","message":"Helm 3 - Fix Additional Job Labels\n\nIf labels are not specified on a Job, kubernetes defaults them\nto include the labels of their underlying Pod template. Helm 3\ninjects metadata into all resources [0] including a\n`app.kubernetes.io/managed-by: Helm` label. Thus when kubernetes\nsees a Job\u0027s labels they are no longer empty and thus do not get\ndefaulted to the underlying Pod template\u0027s labels. This is a\nproblem since Job labels are depended on by\n- Armada pre-upgrade delete hooks\n- Armada wait logic configurations\n- kubernetes-entrypoint dependencies\n\nThus, for Job templates previously missed, this adds labels matching\nthe underlying Pod template to retain the same labels that were\npresent with Helm 2.\n\n[0]: https://github.com/helm/helm/pull/7649\n\nChange-Id: Ie438b449a3d9853d786215d40a39c32d164e9950\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7803000a545687ec40b0ddc41d46a6b377dea45f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7803000a545687ec40b0ddc41d46a6b377dea45f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}