)]}'
{"nova/templates/bin/_cell-setup-init.sh.tpl":[{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"829489c8d517280484947cff97cfe82c2ba5af83","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"until openstack compute service list --service nova-compute -f value -c State | grep -q \"^up$\" ;do"},{"line_number":20,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":21,"context_line":"  sleep 10"},{"line_number":22,"context_line":"done"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- if .Values.jobs.cell_setup.extended_wait.enabled }}"},{"line_number":25,"context_line":"iteration\u003d{{ .Values.jobs.cell_setup.extended_wait.iteration }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"31aec2ce_b1ae31c8","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":4},"updated":"2021-10-22 14:48:33.000000000","message":"This should be moved after the new code.","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"f373ea5b8ba6111ea682d0c914fdc3c6e7cdd485","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"until openstack compute service list --service nova-compute -f value -c State | grep -q \"^up$\" ;do"},{"line_number":20,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":21,"context_line":"  sleep 10"},{"line_number":22,"context_line":"done"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- if .Values.jobs.cell_setup.extended_wait.enabled }}"},{"line_number":25,"context_line":"iteration\u003d{{ .Values.jobs.cell_setup.extended_wait.iteration }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"17261e1e_2a57e2c9","line":22,"range":{"start_line":19,"start_character":0,"end_line":22,"end_character":4},"in_reply_to":"31aec2ce_b1ae31c8","updated":"2021-10-22 16:28:57.000000000","message":"Done","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"829489c8d517280484947cff97cfe82c2ba5af83","unresolved":true,"context_lines":[{"line_number":31,"context_line":"do"},{"line_number":32,"context_line":"  still_down\u003d$(openstack compute service list --service nova-compute -f value -c State | grep \"^down$\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [[ -z \"$still_down\" ]]"},{"line_number":35,"context_line":"  then"},{"line_number":36,"context_line":"    # No more down"},{"line_number":37,"context_line":"    extra_wait\u003dfalse"},{"line_number":38,"context_line":"  else"},{"line_number":39,"context_line":"    sleep \"$duration\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    if [[ \"$iteration\" -gt 1 ]]"},{"line_number":42,"context_line":"    then"},{"line_number":43,"context_line":"      ((iteration\u003diteration-1))"},{"line_number":44,"context_line":"    else"},{"line_number":45,"context_line":"      extra_wait\u003dfalse"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"  fi"},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"133e2912_803d74ca","line":46,"range":{"start_line":34,"start_character":0,"end_line":46,"end_character":6},"updated":"2021-10-22 14:48:33.000000000","message":"Just personal preference but its up to you\n  if [[ -z \"$still_down\" ]]\n  then\n    # No more down\n    extra_wait\u003dfalse\n  elif [[ \"$iteration\" -gt 0 ]]\n    ((iteration\u003diteration-1))\n    sleep \"$duration\"\n  else\n    extra_wait\u003dfalse\n  fi","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"f373ea5b8ba6111ea682d0c914fdc3c6e7cdd485","unresolved":false,"context_lines":[{"line_number":31,"context_line":"do"},{"line_number":32,"context_line":"  still_down\u003d$(openstack compute service list --service nova-compute -f value -c State | grep \"^down$\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if [[ -z \"$still_down\" ]]"},{"line_number":35,"context_line":"  then"},{"line_number":36,"context_line":"    # No more down"},{"line_number":37,"context_line":"    extra_wait\u003dfalse"},{"line_number":38,"context_line":"  else"},{"line_number":39,"context_line":"    sleep \"$duration\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    if [[ \"$iteration\" -gt 1 ]]"},{"line_number":42,"context_line":"    then"},{"line_number":43,"context_line":"      ((iteration\u003diteration-1))"},{"line_number":44,"context_line":"    else"},{"line_number":45,"context_line":"      extra_wait\u003dfalse"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"  fi"},{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"5c767c9c_62058a77","line":46,"range":{"start_line":34,"start_character":0,"end_line":46,"end_character":6},"in_reply_to":"133e2912_803d74ca","updated":"2021-10-22 16:28:57.000000000","message":"Keep as is for now.","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"829489c8d517280484947cff97cfe82c2ba5af83","unresolved":true,"context_lines":[{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# For Info"},{"line_number":51,"context_line":"openstack compute service list --service nova-compute"},{"line_number":52,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"79098191_891a6338","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":1},"updated":"2021-10-22 14:48:33.000000000","message":"Not sure how it will help.","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"8615dcbaeda500e4fe856829da1533eedbe33977","unresolved":false,"context_lines":[{"line_number":48,"context_line":"done"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# For Info"},{"line_number":51,"context_line":"openstack compute service list --service nova-compute"},{"line_number":52,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"492e4747_04599c27","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":1},"in_reply_to":"79098191_891a6338","updated":"2021-10-22 16:28:07.000000000","message":"Updated the comments; it\u0027s to capture any nodes still down for the case iteration was exhausted.","commit_id":"014d6463c7b357d98189826abbf65964663c38ae"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"477b6ab4372595d8acc4e5b23c83b84ccb2a21b8","unresolved":true,"context_lines":[{"line_number":47,"context_line":"openstack compute service list --service nova-compute"},{"line_number":48,"context_line":"{{- end }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"until openstack compute service list --service nova-compute -f value -c State | grep -q \"^up$\" ;do"},{"line_number":51,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":52,"context_line":"  sleep 10"},{"line_number":53,"context_line":"done"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"b1e52ae5_a45753bc","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":4},"updated":"2021-10-25 19:56:10.000000000","message":"I actually like your check and iteration better this code here.  I would actually like to just replace this block of code totally and enable your check by default.","commit_id":"2486ec99f66b46f00812b6653fb981e5695e76b6"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"169f330a42ed6725629ba01a633ba7ecb982f513","unresolved":true,"context_lines":[{"line_number":47,"context_line":"openstack compute service list --service nova-compute"},{"line_number":48,"context_line":"{{- end }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"until openstack compute service list --service nova-compute -f value -c State | grep -q \"^up$\" ;do"},{"line_number":51,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":52,"context_line":"  sleep 10"},{"line_number":53,"context_line":"done"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"f961f6f7_ac5f1f04","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":4},"in_reply_to":"b1e52ae5_a45753bc","updated":"2021-10-26 17:32:15.000000000","message":"We do need to make sure atleat one compute is up at the end.","commit_id":"2486ec99f66b46f00812b6653fb981e5695e76b6"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"db1bed11f625225b6c894a31d11d71b5836baa75","unresolved":true,"context_lines":[{"line_number":47,"context_line":"openstack compute service list --service nova-compute"},{"line_number":48,"context_line":"{{- end }}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"until openstack compute service list --service nova-compute -f value -c State | grep -q \"^up$\" ;do"},{"line_number":51,"context_line":"  echo \"Waiting for Nova Compute processes to register\""},{"line_number":52,"context_line":"  sleep 10"},{"line_number":53,"context_line":"done"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"2471d368_18bc8ffc","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":4},"in_reply_to":"f961f6f7_ac5f1f04","updated":"2021-10-26 20:11:04.000000000","message":"what are the possible values for state, is there something beyond \"UP|DOWN\"?  I thought his new code check to make sure no computes are in DOWN state already, which kinda imply all are UP? \n\nOk I see we could potentially just loop ourselves out of the loop via set number of iterations, so maybe it\u0027s fine to keep it.","commit_id":"2486ec99f66b46f00812b6653fb981e5695e76b6"},{"author":{"_account_id":24780,"name":"Sangeet Gupta","email":"sg774j@att.com","username":"sgupta"},"change_message_id":"169f330a42ed6725629ba01a633ba7ecb982f513","unresolved":true,"context_lines":[{"line_number":43,"context_line":"      openstack compute service list --service nova-compute"},{"line_number":44,"context_line":"    fi"},{"line_number":45,"context_line":"  fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"08cd6b19_338e1b9d","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":1},"updated":"2021-10-26 17:32:15.000000000","message":"We need to check and make sure atlease one nova-compute is up. What if in above iteration none noav-compute came up and we would pass success.","commit_id":"c0337712a49bc4a65b420a2d7cd458a5b7c10e7f"}]}