)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e542d67d6efbb51d6cf7c22821fe724445a641dd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check for number of computes in cell-setup-init script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  This PS further enhances (1) to check for number of computes"},{"line_number":10,"context_line":"to handle case where computes are up, but the total count of"},{"line_number":11,"context_line":"computes is not equal to number of expected computes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(1) https://review.opendev.org/c/openstack/openstack-helm/+/815086"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"79bb0421_d9f14993","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":10},"updated":"2021-11-01 15:55:54.000000000","message":"fmt","commit_id":"f6e6e2fcdb3c28c9ca09124aba7ef70a5498172d"}],"nova/templates/bin/_cell-setup-init.sh.tpl":[{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"3ccefc41c2d079dde658f6083dafaaffa4623f89","unresolved":true,"context_lines":[{"line_number":34,"context_line":"do"},{"line_number":35,"context_line":"  nova_computes\u003d$(openstack compute service list --service nova-compute -f value -c State)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if [[ -z \"$(echo $nova_computes | grep down)\" ]]"},{"line_number":38,"context_line":"  then"},{"line_number":39,"context_line":"    # No more down. Lets check for expected num of computes"},{"line_number":40,"context_line":"    actual_computes\u003d$(echo $nova_computes | wc -w)"},{"line_number":41,"context_line":"    if [[ \"$actual_computes\" -ge \"$expected_computes\" ]]"},{"line_number":42,"context_line":"    then"},{"line_number":43,"context_line":"      # All expected nodes are up"},{"line_number":44,"context_line":"      extra_wait\u003dfalse"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if [[ \"$extra_wait\" \u003d\u003d true ]]"},{"line_number":49,"context_line":"  then"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"e3570ca7_2a7cea75","line":46,"range":{"start_line":37,"start_character":0,"end_line":46,"end_character":4},"updated":"2021-11-02 15:01:23.000000000","message":"Can you explain rationale more here?  If no nova-compute is in \"down\" state at this point, is there a scenario where some \"extra\" nova-compute may still appear shortly after? \n\nAnd what are the values of \"state\"?  is it just \"up/down\"?  Are there other transitory states?\n\nThis feels like 3 separate ad-hoc checks being lumped together incoherently, I recommend to just rework these 3 checks together into a single more coherent logic checks.","commit_id":"f6e6e2fcdb3c28c9ca09124aba7ef70a5498172d"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"90ddc3c8f47b0d07bac33cbb1b1757453141083f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"do"},{"line_number":35,"context_line":"  nova_computes\u003d$(openstack compute service list --service nova-compute -f value -c State)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if [[ -z \"$(echo $nova_computes | grep down)\" ]]"},{"line_number":38,"context_line":"  then"},{"line_number":39,"context_line":"    # No more down. Lets check for expected num of computes"},{"line_number":40,"context_line":"    actual_computes\u003d$(echo $nova_computes | wc -w)"},{"line_number":41,"context_line":"    if [[ \"$actual_computes\" -ge \"$expected_computes\" ]]"},{"line_number":42,"context_line":"    then"},{"line_number":43,"context_line":"      # All expected nodes are up"},{"line_number":44,"context_line":"      extra_wait\u003dfalse"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if [[ \"$extra_wait\" \u003d\u003d true ]]"},{"line_number":49,"context_line":"  then"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"b3a0906d_c43a8e7e","line":46,"range":{"start_line":37,"start_character":0,"end_line":46,"end_character":4},"in_reply_to":"381d8070_d55faaf8","updated":"2021-11-03 17:13:51.000000000","message":"This is interesting info, but if that\u0027s the reality on the ground, it does help explain the context of all these checks.  It may make sense to add all these rationale as a comment, or maybe like I suggest before, combine all these checks into simply\n\nwhile ( \"number of computes UP\" \u003c \"expected computes\" ) || ( \"extra_wait\" )\n  do \n     wait\n     check and update number of computes UP\n     update \"extra_wait\" per logic\nend","commit_id":"f6e6e2fcdb3c28c9ca09124aba7ef70a5498172d"},{"author":{"_account_id":33282,"name":"Huy Tran","email":"huy.q.tran@ericsson.com","username":"ht095u"},"change_message_id":"80ea2fcc944e93ee962c67acbc263320594eec09","unresolved":false,"context_lines":[{"line_number":34,"context_line":"do"},{"line_number":35,"context_line":"  nova_computes\u003d$(openstack compute service list --service nova-compute -f value -c State)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  if [[ -z \"$(echo $nova_computes | grep down)\" ]]"},{"line_number":38,"context_line":"  then"},{"line_number":39,"context_line":"    # No more down. Lets check for expected num of computes"},{"line_number":40,"context_line":"    actual_computes\u003d$(echo $nova_computes | wc -w)"},{"line_number":41,"context_line":"    if [[ \"$actual_computes\" -ge \"$expected_computes\" ]]"},{"line_number":42,"context_line":"    then"},{"line_number":43,"context_line":"      # All expected nodes are up"},{"line_number":44,"context_line":"      extra_wait\u003dfalse"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"  fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  if [[ \"$extra_wait\" \u003d\u003d true ]]"},{"line_number":49,"context_line":"  then"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"381d8070_d55faaf8","line":46,"range":{"start_line":37,"start_character":0,"end_line":46,"end_character":4},"in_reply_to":"e3570ca7_2a7cea75","updated":"2021-11-02 16:24:36.000000000","message":"Per testing results, it\u0027s quite often that not all the compute nodes are present at the time this init script is being executed, regardless of the state. I believe the state is just up/down.","commit_id":"f6e6e2fcdb3c28c9ca09124aba7ef70a5498172d"}],"nova/templates/job-cell-setup.yaml":[{"author":{"_account_id":30449,"name":"jinyuanliu","email":"liujinyuan@inspur.com","username":"jinyuanliu"},"change_message_id":"138cf049ecadc62931de7b26e9852b1233abe440","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- if .Values.manifests.job_cell_setup }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{{- $serviceAccountName :\u003d \"nova-cell-setup\" -}}"},{"line_number":19,"context_line":"{{ tuple $envAll \"cell_setup\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: batch/v1"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ce020d8d_4b53d7c2","line":18,"range":{"start_line":18,"start_character":39,"end_line":18,"end_character":48},"updated":"2021-10-29 01:19:49.000000000","message":"reflow","commit_id":"b89bd1b93ecf30eb8ef30eeb7abd62901037a2b5"}]}