)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"ad69303590657c772b122a7834d29c122e0782be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7be16636_81aacd07","updated":"2022-02-22 20:08:21.000000000","message":"One of the reasons we don\u0027t have an \"all-in-one\" script is because there\u0027s so much variation between linux distros that the script becomes huge with specific settings, like this one is already. There\u0027s also no way to test these scripts and we already have enough trouble keeping the simple ones up to date. Many of the settings here will also not work for everyone, it greatly depends on where the user is deploying to, if there is a firewall/dns/etc.\n\nIf we were to follow a way of doing this, a chart that deploys everything would be a better path forward here.","commit_id":"c71d2b692a0beba550c9232d9437aeda4a4e13ea"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"8e77482f07c73280210b7bd29b9746a7bf4218a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85acd2e7_5339c428","in_reply_to":"7be16636_81aacd07","updated":"2022-02-22 21:50:17.000000000","message":"Agree! I meant to use [DNM] or [DNR], this is just a placeholder until the umbrella chart is working. Basically the umbrella chart will do the equivalent of what\u0027s being done here.","commit_id":"c71d2b692a0beba550c9232d9437aeda4a4e13ea"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"a344daa9f4bd45642f8bbddf43e1290427bfcf9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c48e480c_3543c707","in_reply_to":"85acd2e7_5339c428","updated":"2022-02-22 23:24:39.000000000","message":"Sounds good!","commit_id":"c71d2b692a0beba550c9232d9437aeda4a4e13ea"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c496e04b_df096ec5","updated":"2022-03-15 18:23:19.000000000","message":"Updated the script according to the comments","commit_id":"96cbee696842fd9c0699408622a886af730b5749"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"1a855755679e638f4083e9f881258bcabf135aca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d10d97c1_24dacc83","updated":"2022-03-15 18:28:44.000000000","message":"lgtm","commit_id":"96cbee696842fd9c0699408622a886af730b5749"}],"tools/deployment/developer/victoria/deploy-openstack-helm.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"09d7661c8283223af393e9ea11761ff7358ed46c","unresolved":true,"context_lines":[{"line_number":197,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal"},{"line_number":198,"context_line":"export OSH_TEST_TIMEOUT\u003d1200"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# Replacement for openstack-helm-infra/playbooks/osh-infra-gate-runner.yaml, since it has Zuul-exclusive roles."},{"line_number":201,"context_line":"apt -y install --no-install-recommends \\"},{"line_number":202,"context_line":"  python3-pip \\"},{"line_number":203,"context_line":"  libssl-dev \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"c7b79df0_1ee1b56c","line":200,"updated":"2022-02-23 23:26:30.000000000","message":"where are these packages used in the following scripts? I did not think they called any ansible?","commit_id":"c71d2b692a0beba550c9232d9437aeda4a4e13ea"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":197,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal"},{"line_number":198,"context_line":"export OSH_TEST_TIMEOUT\u003d1200"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"# Replacement for openstack-helm-infra/playbooks/osh-infra-gate-runner.yaml, since it has Zuul-exclusive roles."},{"line_number":201,"context_line":"apt -y install --no-install-recommends \\"},{"line_number":202,"context_line":"  python3-pip \\"},{"line_number":203,"context_line":"  libssl-dev \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"a5024f64_326f3ebb","line":200,"in_reply_to":"c7b79df0_1ee1b56c","updated":"2022-03-09 19:12:08.000000000","message":"We were trying to replicate the gating automation since that was a known working starting point.\nPlaybooks like `osh-infra-gate-runner` include Ansible roles that are exclusive to Zuul, ex:\nhttps://zuul-ci.org/docs/zuul-jobs/python-roles.html\nWe wanted to replicate the gate automation without using Zuul, so we found the rough equivalent shell commands to do this in another shell script in the repo.","commit_id":"c71d2b692a0beba550c9232d9437aeda4a4e13ea"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":30,"context_line":": ${CLEAN_VM:\u003dtrue}\r"},{"line_number":31,"context_line":"# OpenStack release\r"},{"line_number":32,"context_line":": ${OPENSTACK_RELEASE:\u003dvictoria}\r"},{"line_number":33,"context_line":"# Target environment ubuntu version\r"},{"line_number":34,"context_line":": ${UBUNTU_VERSION:\u003dbionic}\r"},{"line_number":35,"context_line":"# Path to your SSH private key\r"},{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"8c3fe219_77e431d6","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":20},"updated":"2022-03-09 19:12:08.000000000","message":"Target VM","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":30,"context_line":": ${CLEAN_VM:\u003dtrue}\r"},{"line_number":31,"context_line":"# OpenStack release\r"},{"line_number":32,"context_line":": ${OPENSTACK_RELEASE:\u003dvictoria}\r"},{"line_number":33,"context_line":"# Target environment ubuntu version\r"},{"line_number":34,"context_line":": ${UBUNTU_VERSION:\u003dbionic}\r"},{"line_number":35,"context_line":"# Path to your SSH private key\r"},{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5ed54763_14d4a6c5","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":20},"in_reply_to":"8c3fe219_77e431d6","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":31,"context_line":"# OpenStack release\r"},{"line_number":32,"context_line":": ${OPENSTACK_RELEASE:\u003dvictoria}\r"},{"line_number":33,"context_line":"# Target environment ubuntu version\r"},{"line_number":34,"context_line":": ${UBUNTU_VERSION:\u003dbionic}\r"},{"line_number":35,"context_line":"# Path to your SSH private key\r"},{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"},{"line_number":37,"context_line":"# Path to your SSH public key\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9824a4f8_57e2b9a7","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":18},"updated":"2022-03-09 19:12:08.000000000","message":"rename to VM_UBUNTU_VERSION for clarity","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# OpenStack release\r"},{"line_number":32,"context_line":": ${OPENSTACK_RELEASE:\u003dvictoria}\r"},{"line_number":33,"context_line":"# Target environment ubuntu version\r"},{"line_number":34,"context_line":": ${UBUNTU_VERSION:\u003dbionic}\r"},{"line_number":35,"context_line":"# Path to your SSH private key\r"},{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"},{"line_number":37,"context_line":"# Path to your SSH public key\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a309515b_fc51ba5b","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":18},"in_reply_to":"9824a4f8_57e2b9a7","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"},{"line_number":37,"context_line":"# Path to your SSH public key\r"},{"line_number":38,"context_line":": ${SSH_PUBLIC_KEY_PATH:\u003d~/.ssh/id_rsa.pub}\r"},{"line_number":39,"context_line":"# Copy local openstack-helm-infra repo in your vm\r"},{"line_number":40,"context_line":": ${USE_LOCAL_OSH_INFRA_REPO:\u003dtrue}\r"},{"line_number":41,"context_line":"# Copy local openstack-helm repo in your vm\r"},{"line_number":42,"context_line":": ${USE_LOCAL_OSH_REPO:\u003dtrue}\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"# set memory for host VM\r"},{"line_number":45,"context_line":": ${RAM:\u003d32000} \r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"b1fdabaf_7928c146","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":29},"updated":"2022-03-09 19:12:08.000000000","message":"Have these be paths to local repos instead. Default can be blank/empty.\nThen if user supplies non-blank value, make a check to ensure the user-supplied directories exist. And exit with error if not.","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":36,"context_line":": ${SSH_PRIVATE_KEY_PATH:\u003d~/.ssh/id_rsa}\r"},{"line_number":37,"context_line":"# Path to your SSH public key\r"},{"line_number":38,"context_line":": ${SSH_PUBLIC_KEY_PATH:\u003d~/.ssh/id_rsa.pub}\r"},{"line_number":39,"context_line":"# Copy local openstack-helm-infra repo in your vm\r"},{"line_number":40,"context_line":": ${USE_LOCAL_OSH_INFRA_REPO:\u003dtrue}\r"},{"line_number":41,"context_line":"# Copy local openstack-helm repo in your vm\r"},{"line_number":42,"context_line":": ${USE_LOCAL_OSH_REPO:\u003dtrue}\r"},{"line_number":43,"context_line":"\r"},{"line_number":44,"context_line":"# set memory for host VM\r"},{"line_number":45,"context_line":": ${RAM:\u003d32000} \r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"83e18446_3f668730","line":42,"range":{"start_line":39,"start_character":0,"end_line":42,"end_character":29},"in_reply_to":"b1fdabaf_7928c146","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":155,"context_line":"  # enable ipv4 forwarding\r"},{"line_number":156,"context_line":"  sysctl net.ipv4.ip_forward\u003d1\r"},{"line_number":157,"context_line":"# check if vm supports virtualization\r"},{"line_number":158,"context_line":"kvmcheck\u003d$(echo $(egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo))\r"},{"line_number":159,"context_line":"if [ $kvmcheck -gt 0 ]; then\r"},{"line_number":160,"context_line":"echo \"supports kvm virtualization\"\r"},{"line_number":161,"context_line":"else \r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"72bb76ae_bbe78449","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":8},"updated":"2022-03-09 19:12:08.000000000","message":"You can also use `kvm-ok` for this","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  # enable ipv4 forwarding\r"},{"line_number":156,"context_line":"  sysctl net.ipv4.ip_forward\u003d1\r"},{"line_number":157,"context_line":"# check if vm supports virtualization\r"},{"line_number":158,"context_line":"kvmcheck\u003d$(echo $(egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo))\r"},{"line_number":159,"context_line":"if [ $kvmcheck -gt 0 ]; then\r"},{"line_number":160,"context_line":"echo \"supports kvm virtualization\"\r"},{"line_number":161,"context_line":"else \r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3778683d_cd015ac8","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":8},"in_reply_to":"72bb76ae_bbe78449","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":155,"context_line":"  # enable ipv4 forwarding\r"},{"line_number":156,"context_line":"  sysctl net.ipv4.ip_forward\u003d1\r"},{"line_number":157,"context_line":"# check if vm supports virtualization\r"},{"line_number":158,"context_line":"kvmcheck\u003d$(echo $(egrep -c \u0027(vmx|svm)\u0027 /proc/cpuinfo))\r"},{"line_number":159,"context_line":"if [ $kvmcheck -gt 0 ]; then\r"},{"line_number":160,"context_line":"echo \"supports kvm virtualization\"\r"},{"line_number":161,"context_line":"else \r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"f2b23fb0_55ce044a","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":8},"in_reply_to":"72bb76ae_bbe78449","updated":"2022-03-11 19:58:47.000000000","message":"I meant `kvm-ok` package but what you have is also fine because they both do the same thing.","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":188,"context_line":"  time_waited\u003d0\r"},{"line_number":189,"context_line":"  timeout\u003d300\r"},{"line_number":190,"context_line":"  while [[ $time_waited -lt $timeout ]]; do\r"},{"line_number":191,"context_line":"    ipaddr\u003d\"$(virsh domifaddr victoria | grep -i $mac | tail -1 | awk \u0027{print $4}\u0027 | cut -d \u0027/\u0027 -f1)\"\r"},{"line_number":192,"context_line":"    if [[ -n $ipaddr ]]; then\r"},{"line_number":193,"context_line":"      if ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr date \u003e /dev/null; then\r"},{"line_number":194,"context_line":"\techo VM ready to accept SSH connection\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1fc314f7_567b6903","line":191,"range":{"start_line":191,"start_character":30,"end_line":191,"end_character":38},"updated":"2022-03-09 19:12:08.000000000","message":"$OPENSTACK_RELEASE","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  time_waited\u003d0\r"},{"line_number":189,"context_line":"  timeout\u003d300\r"},{"line_number":190,"context_line":"  while [[ $time_waited -lt $timeout ]]; do\r"},{"line_number":191,"context_line":"    ipaddr\u003d\"$(virsh domifaddr victoria | grep -i $mac | tail -1 | awk \u0027{print $4}\u0027 | cut -d \u0027/\u0027 -f1)\"\r"},{"line_number":192,"context_line":"    if [[ -n $ipaddr ]]; then\r"},{"line_number":193,"context_line":"      if ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr date \u003e /dev/null; then\r"},{"line_number":194,"context_line":"\techo VM ready to accept SSH connection\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"b9443bce_610ffe25","line":191,"range":{"start_line":191,"start_character":30,"end_line":191,"end_character":38},"in_reply_to":"1fc314f7_567b6903","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":203,"context_line":"cat \u003c\u003c\u0027END\u0027 \u003e tgthost_script.sh\r"},{"line_number":204,"context_line":"#!/bin/bash\r"},{"line_number":205,"context_line":"\r"},{"line_number":206,"context_line":"# Install az cli\r"},{"line_number":207,"context_line":"curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash\r"},{"line_number":208,"context_line":"\r"},{"line_number":209,"context_line":"# Disable local nameserver to prevent conflicts with k8s nameserver\r"},{"line_number":210,"context_line":"systemctl stop systemd-resolved\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"8cdf3bbd_461fba5c","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":54},"updated":"2022-03-09 19:12:08.000000000","message":"make this idempotent. In other words, only do this if az cli is not already installed","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":203,"context_line":"cat \u003c\u003c\u0027END\u0027 \u003e tgthost_script.sh\r"},{"line_number":204,"context_line":"#!/bin/bash\r"},{"line_number":205,"context_line":"\r"},{"line_number":206,"context_line":"# Install az cli\r"},{"line_number":207,"context_line":"curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash\r"},{"line_number":208,"context_line":"\r"},{"line_number":209,"context_line":"# Disable local nameserver to prevent conflicts with k8s nameserver\r"},{"line_number":210,"context_line":"systemctl stop systemd-resolved\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6da9e099_e97bb791","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":54},"in_reply_to":"8cdf3bbd_461fba5c","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":241,"context_line":"fi\r"},{"line_number":242,"context_line":"\r"},{"line_number":243,"context_line":"# Set release / distro info\r"},{"line_number":244,"context_line":"export OPENSTACK_RELEASE\u003dvictoria\r"},{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"e083c6a9_bead40d5","line":244,"range":{"start_line":244,"start_character":7,"end_line":244,"end_character":24},"updated":"2022-03-09 19:12:08.000000000","message":"Rename this variable to VM_NAME everywhere except for where it is used inside the tgthost script","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":241,"context_line":"fi\r"},{"line_number":242,"context_line":"\r"},{"line_number":243,"context_line":"# Set release / distro info\r"},{"line_number":244,"context_line":"export OPENSTACK_RELEASE\u003dvictoria\r"},{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dac5b0e1_891d9ba9","line":244,"range":{"start_line":244,"start_character":7,"end_line":244,"end_character":24},"in_reply_to":"e083c6a9_bead40d5","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"},{"line_number":248,"context_line":"echo \"export OS_CLOUD\u003dopenstack_helm\" \u003e\u003e ~/.bashrc\r"},{"line_number":249,"context_line":"\r"},{"line_number":250,"context_line":"# Replacement for openstack-helm-infra/playbooks/osh-infra-gate-runner.yaml, since it has Zuul-exclusive roles.\r"},{"line_number":251,"context_line":"apt -y install --no-install-recommends \\\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"026220a6_44854251","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":50},"updated":"2022-03-09 19:12:08.000000000","message":"Make this idempotent. In other words, only add this line if it doesn\u0027t already exist. Otherwise this file will keep growing in size every time the script is run.","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"},{"line_number":248,"context_line":"echo \"export OS_CLOUD\u003dopenstack_helm\" \u003e\u003e ~/.bashrc\r"},{"line_number":249,"context_line":"\r"},{"line_number":250,"context_line":"# Replacement for openstack-helm-infra/playbooks/osh-infra-gate-runner.yaml, since it has Zuul-exclusive roles.\r"},{"line_number":251,"context_line":"apt -y install --no-install-recommends \\\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"21c7efa4_4c2eae1d","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":50},"in_reply_to":"026220a6_44854251","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":275,"context_line":"# Start scripts from \"openstack-helm-compute-kit\" job in openstack-helm repo\r"},{"line_number":276,"context_line":"cd openstack-helm;\r"},{"line_number":277,"context_line":"./tools/deployment/common/install-packages.sh;\r"},{"line_number":278,"context_line":"./tools/gate/deploy-k8s.sh; \r"},{"line_number":279,"context_line":"./tools/deployment/common/setup-client.sh; \r"},{"line_number":280,"context_line":"if ! type kubectl \u003e\u0026 /dev/null; then\r"},{"line_number":281,"context_line":"  echo \u0027kubectl not installed, exiting!\u0027\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"95520085_87468f22","line":278,"range":{"start_line":278,"start_character":27,"end_line":278,"end_character":28},"updated":"2022-03-09 19:12:08.000000000","message":"EOL whitespace","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":275,"context_line":"# Start scripts from \"openstack-helm-compute-kit\" job in openstack-helm repo\r"},{"line_number":276,"context_line":"cd openstack-helm;\r"},{"line_number":277,"context_line":"./tools/deployment/common/install-packages.sh;\r"},{"line_number":278,"context_line":"./tools/gate/deploy-k8s.sh; \r"},{"line_number":279,"context_line":"./tools/deployment/common/setup-client.sh; \r"},{"line_number":280,"context_line":"if ! type kubectl \u003e\u0026 /dev/null; then\r"},{"line_number":281,"context_line":"  echo \u0027kubectl not installed, exiting!\u0027\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"392bae08_2b572679","line":278,"range":{"start_line":278,"start_character":27,"end_line":278,"end_character":28},"in_reply_to":"95520085_87468f22","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"cf017fd18d7060ebcef18b505c65ef9561672766","unresolved":true,"context_lines":[{"line_number":276,"context_line":"cd openstack-helm;\r"},{"line_number":277,"context_line":"./tools/deployment/common/install-packages.sh;\r"},{"line_number":278,"context_line":"./tools/gate/deploy-k8s.sh; \r"},{"line_number":279,"context_line":"./tools/deployment/common/setup-client.sh; \r"},{"line_number":280,"context_line":"if ! type kubectl \u003e\u0026 /dev/null; then\r"},{"line_number":281,"context_line":"  echo \u0027kubectl not installed, exiting!\u0027\r"},{"line_number":282,"context_line":"  exit 1\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"247f50ac_846849c0","line":279,"range":{"start_line":279,"start_character":42,"end_line":279,"end_character":43},"updated":"2022-03-09 19:12:08.000000000","message":"EOL whitespace","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":276,"context_line":"cd openstack-helm;\r"},{"line_number":277,"context_line":"./tools/deployment/common/install-packages.sh;\r"},{"line_number":278,"context_line":"./tools/gate/deploy-k8s.sh; \r"},{"line_number":279,"context_line":"./tools/deployment/common/setup-client.sh; \r"},{"line_number":280,"context_line":"if ! type kubectl \u003e\u0026 /dev/null; then\r"},{"line_number":281,"context_line":"  echo \u0027kubectl not installed, exiting!\u0027\r"},{"line_number":282,"context_line":"  exit 1\r"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dca2cf79_304a8fdf","line":279,"range":{"start_line":279,"start_character":42,"end_line":279,"end_character":43},"in_reply_to":"247f50ac_846849c0","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"af9e623f5e65d956712a81679f307e11468cf15a"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":204,"context_line":"#!/bin/bash\r"},{"line_number":205,"context_line":"\r"},{"line_number":206,"context_line":"# Install az cli \r"},{"line_number":207,"context_line":"if command -v az; then echo az cli already installed; else curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash; fi\r"},{"line_number":208,"context_line":"\r"},{"line_number":209,"context_line":"# Disable local nameserver to prevent conflicts with k8s nameserver\r"},{"line_number":210,"context_line":"systemctl stop systemd-resolved\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"c2093327_aa57639d","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":117},"updated":"2022-03-11 19:58:47.000000000","message":"Expand this out, don\u0027t compact if/then/else statements to a single line","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":204,"context_line":"#!/bin/bash\r"},{"line_number":205,"context_line":"\r"},{"line_number":206,"context_line":"# Install az cli \r"},{"line_number":207,"context_line":"if command -v az; then echo az cli already installed; else curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash; fi\r"},{"line_number":208,"context_line":"\r"},{"line_number":209,"context_line":"# Disable local nameserver to prevent conflicts with k8s nameserver\r"},{"line_number":210,"context_line":"systemctl stop systemd-resolved\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"957bb72a_e97443a4","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":117},"in_reply_to":"c2093327_aa57639d","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"},{"line_number":248,"context_line":"OS_CLOUD_CHECK\u003d$(echo $(cat ~/.bashrc | grep \"export OS_CLOUD\u003dopenstack_helm\"))\r"},{"line_number":249,"context_line":"if [[ -z \"$OS_CLOUD_CHECK\" ]]; then\r"},{"line_number":250,"context_line":" echo \"export OS_CLOUD\u003dopenstack_helm\" \u003e\u003e ~/.bashrc;\r"},{"line_number":251,"context_line":"fi\r"},{"line_number":252,"context_line":"\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3ed5e402_f55106e3","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":35},"updated":"2022-03-11 19:58:47.000000000","message":"You can replace these two lines with the following to be more concise:\n\nif ! grep \"export OS_CLOUD\u003dopenstack_helm\" ~/.bashrc; then","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":245,"context_line":"export CONTAINER_DISTRO_VERSION\u003dfocal\r"},{"line_number":246,"context_line":"export OSH_TEST_TIMEOUT\u003d1200\r"},{"line_number":247,"context_line":"export OS_CLOUD\u003dopenstack_helm\r"},{"line_number":248,"context_line":"OS_CLOUD_CHECK\u003d$(echo $(cat ~/.bashrc | grep \"export OS_CLOUD\u003dopenstack_helm\"))\r"},{"line_number":249,"context_line":"if [[ -z \"$OS_CLOUD_CHECK\" ]]; then\r"},{"line_number":250,"context_line":" echo \"export OS_CLOUD\u003dopenstack_helm\" \u003e\u003e ~/.bashrc;\r"},{"line_number":251,"context_line":"fi\r"},{"line_number":252,"context_line":"\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"25e58a28_106de662","line":249,"range":{"start_line":248,"start_character":0,"end_line":249,"end_character":35},"in_reply_to":"3ed5e402_f55106e3","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":257,"context_line":"  python3-dev \\\r"},{"line_number":258,"context_line":"  build-essential \\\r"},{"line_number":259,"context_line":"  jq \\\r"},{"line_number":260,"context_line":"  curl \r"},{"line_number":261,"context_line":"\r"},{"line_number":262,"context_line":"pip3 install --upgrade pip\r"},{"line_number":263,"context_line":"pip3 install --upgrade setuptools\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"b434fcaf_65cd500a","line":260,"range":{"start_line":260,"start_character":6,"end_line":260,"end_character":7},"updated":"2022-03-11 19:58:47.000000000","message":"Whitespace","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":257,"context_line":"  python3-dev \\\r"},{"line_number":258,"context_line":"  build-essential \\\r"},{"line_number":259,"context_line":"  jq \\\r"},{"line_number":260,"context_line":"  curl \r"},{"line_number":261,"context_line":"\r"},{"line_number":262,"context_line":"pip3 install --upgrade pip\r"},{"line_number":263,"context_line":"pip3 install --upgrade setuptools\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"f52eb2e7_da23e272","line":260,"range":{"start_line":260,"start_character":6,"end_line":260,"end_character":7},"in_reply_to":"b434fcaf_65cd500a","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":307,"context_line":"if [[ $USE_VM \u003d true ]]; then\r"},{"line_number":308,"context_line":"  # Run target script in VM\r"},{"line_number":309,"context_line":"  scp -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" tgthost_script.sh root@$ipaddr:~\r"},{"line_number":310,"context_line":"  \r"},{"line_number":311,"context_line":"  # local copies of openstack-helm and openstack-helm-infra repos\r"},{"line_number":312,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_REPO\" ]]; then \r"},{"line_number":313,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_REPO\" ]]; then\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dd17c782_747897b9","line":310,"range":{"start_line":310,"start_character":0,"end_line":310,"end_character":2},"updated":"2022-03-11 19:58:47.000000000","message":"whitespace","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":307,"context_line":"if [[ $USE_VM \u003d true ]]; then\r"},{"line_number":308,"context_line":"  # Run target script in VM\r"},{"line_number":309,"context_line":"  scp -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" tgthost_script.sh root@$ipaddr:~\r"},{"line_number":310,"context_line":"  \r"},{"line_number":311,"context_line":"  # local copies of openstack-helm and openstack-helm-infra repos\r"},{"line_number":312,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_REPO\" ]]; then \r"},{"line_number":313,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_REPO\" ]]; then\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"992396fa_4c86d746","line":310,"range":{"start_line":310,"start_character":0,"end_line":310,"end_character":2},"in_reply_to":"dd17c782_747897b9","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":311,"context_line":"  # local copies of openstack-helm and openstack-helm-infra repos\r"},{"line_number":312,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_REPO\" ]]; then \r"},{"line_number":313,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_REPO\" ]]; then\r"},{"line_number":314,"context_line":"    echo $USE_LOCAL_OSH_REPO\r"},{"line_number":315,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_REPO root@$ipaddr:~\r"},{"line_number":316,"context_line":"    else\r"},{"line_number":317,"context_line":"    echo path : $USE_LOCAL_OSH_REPO does not exist;\r"},{"line_number":318,"context_line":"    exit 1;\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"0c8eb35e_a3a359e2","line":315,"range":{"start_line":314,"start_character":0,"end_line":315,"end_character":134},"updated":"2022-03-11 19:58:47.000000000","message":"Indent these lines that fall under the \"if\" statement above (2 more spaces)","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  # local copies of openstack-helm and openstack-helm-infra repos\r"},{"line_number":312,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_REPO\" ]]; then \r"},{"line_number":313,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_REPO\" ]]; then\r"},{"line_number":314,"context_line":"    echo $USE_LOCAL_OSH_REPO\r"},{"line_number":315,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_REPO root@$ipaddr:~\r"},{"line_number":316,"context_line":"    else\r"},{"line_number":317,"context_line":"    echo path : $USE_LOCAL_OSH_REPO does not exist;\r"},{"line_number":318,"context_line":"    exit 1;\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"f9786f61_a5ad200c","line":315,"range":{"start_line":314,"start_character":0,"end_line":315,"end_character":134},"in_reply_to":"0c8eb35e_a3a359e2","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":314,"context_line":"    echo $USE_LOCAL_OSH_REPO\r"},{"line_number":315,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_REPO root@$ipaddr:~\r"},{"line_number":316,"context_line":"    else\r"},{"line_number":317,"context_line":"    echo path : $USE_LOCAL_OSH_REPO does not exist;\r"},{"line_number":318,"context_line":"    exit 1;\r"},{"line_number":319,"context_line":"    fi\r"},{"line_number":320,"context_line":"  fi\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"8764aca5_80c97429","line":317,"range":{"start_line":317,"start_character":0,"end_line":317,"end_character":51},"updated":"2022-03-11 19:58:47.000000000","message":"Indent these lines that fall under the \"else\" statement above (2 more spaces)","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    echo $USE_LOCAL_OSH_REPO\r"},{"line_number":315,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_REPO root@$ipaddr:~\r"},{"line_number":316,"context_line":"    else\r"},{"line_number":317,"context_line":"    echo path : $USE_LOCAL_OSH_REPO does not exist;\r"},{"line_number":318,"context_line":"    exit 1;\r"},{"line_number":319,"context_line":"    fi\r"},{"line_number":320,"context_line":"  fi\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"c479c0a8_1e2a3ac2","line":317,"range":{"start_line":317,"start_character":0,"end_line":317,"end_character":51},"in_reply_to":"8764aca5_80c97429","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":321,"context_line":"\r"},{"line_number":322,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_INFRA_REPO\" ]]; then \r"},{"line_number":323,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_INFRA_REPO\" ]]; then\r"},{"line_number":324,"context_line":"    echo $USE_LOCAL_OSH_INFRA_REPO\r"},{"line_number":325,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":326,"context_line":"    else\r"},{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"793abb10_d26ae143","line":325,"range":{"start_line":324,"start_character":0,"end_line":325,"end_character":140},"updated":"2022-03-11 19:58:47.000000000","message":"as above","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":321,"context_line":"\r"},{"line_number":322,"context_line":"  if [[ -n \"$USE_LOCAL_OSH_INFRA_REPO\" ]]; then \r"},{"line_number":323,"context_line":"    if  [[ -d \"$USE_LOCAL_OSH_INFRA_REPO\" ]]; then\r"},{"line_number":324,"context_line":"    echo $USE_LOCAL_OSH_INFRA_REPO\r"},{"line_number":325,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":326,"context_line":"    else\r"},{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bfe43bbf_16bdf2a5","line":325,"range":{"start_line":324,"start_character":0,"end_line":325,"end_character":140},"in_reply_to":"793abb10_d26ae143","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":324,"context_line":"    echo $USE_LOCAL_OSH_INFRA_REPO\r"},{"line_number":325,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":326,"context_line":"    else\r"},{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"},{"line_number":329,"context_line":"    fi\r"},{"line_number":330,"context_line":"  fi  \r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f8b5f06_4cf70825","line":327,"range":{"start_line":327,"start_character":0,"end_line":327,"end_character":57},"updated":"2022-03-11 19:58:47.000000000","message":"as above","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    echo $USE_LOCAL_OSH_INFRA_REPO\r"},{"line_number":325,"context_line":"    scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":326,"context_line":"    else\r"},{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"},{"line_number":329,"context_line":"    fi\r"},{"line_number":330,"context_line":"  fi  \r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"b27e06eb_a804e27c","line":327,"range":{"start_line":327,"start_character":0,"end_line":327,"end_character":57},"in_reply_to":"7f8b5f06_4cf70825","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"afb3e6a19b05f6479f477c2412e025bb5715bd63","unresolved":true,"context_lines":[{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"},{"line_number":329,"context_line":"    fi\r"},{"line_number":330,"context_line":"  fi  \r"},{"line_number":331,"context_line":"\r"},{"line_number":332,"context_line":"  ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr \"nohup ~/tgthost_script.sh \u003e\u0026 ~/logfile \u0026\"\r"},{"line_number":333,"context_line":"  ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr \"cat ~/logfile\"\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"59d470aa_0ea40af2","line":330,"range":{"start_line":330,"start_character":4,"end_line":330,"end_character":6},"updated":"2022-03-11 19:58:47.000000000","message":"EOL whitespace","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":328,"context_line":"    exit 1;\r"},{"line_number":329,"context_line":"    fi\r"},{"line_number":330,"context_line":"  fi  \r"},{"line_number":331,"context_line":"\r"},{"line_number":332,"context_line":"  ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr \"nohup ~/tgthost_script.sh \u003e\u0026 ~/logfile \u0026\"\r"},{"line_number":333,"context_line":"  ssh -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" root@$ipaddr \"cat ~/logfile\"\r"}],"source_content_type":"text/x-sh","patch_set":3,"id":"152d2a88_96422d45","line":330,"range":{"start_line":330,"start_character":4,"end_line":330,"end_character":6},"in_reply_to":"59d470aa_0ea40af2","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"093a30a9d3fef68fad42710767b80a8f720ba44c"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"03bd473e826304e9695a03b617b362e27faa1c5a","unresolved":true,"context_lines":[{"line_number":330,"context_line":"      scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":331,"context_line":"    else\r"},{"line_number":332,"context_line":"      echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":333,"context_line":"      exit 1;\r"},{"line_number":334,"context_line":"    fi\r"},{"line_number":335,"context_line":"  fi\r"},{"line_number":336,"context_line":"\r"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1e7a9500_6fb46a78","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":13},"updated":"2022-03-15 07:21:17.000000000","message":"You can remove semicolons when they are at the end of the line. They are only needed if you are running multiple commands on the same line.","commit_id":"c042b6c1c6a0538a17439f74561a02febf8e7742"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"36044eb3b9f0538b0a9593b591944acc57ed8f09","unresolved":false,"context_lines":[{"line_number":330,"context_line":"      scp -r -i $SSH_PRIVATE_KEY_PATH -o \"StrictHostKeyChecking\u003dno\" -o \"UserKnownHostsFile\u003d/dev/null\" $USE_LOCAL_OSH_INFRA_REPO root@$ipaddr:~\r"},{"line_number":331,"context_line":"    else\r"},{"line_number":332,"context_line":"      echo path : $USE_LOCAL_OSH_INFRA_REPO does not exist;\r"},{"line_number":333,"context_line":"      exit 1;\r"},{"line_number":334,"context_line":"    fi\r"},{"line_number":335,"context_line":"  fi\r"},{"line_number":336,"context_line":"\r"}],"source_content_type":"text/x-sh","patch_set":4,"id":"387ae5fc_f791cea7","line":333,"range":{"start_line":333,"start_character":12,"end_line":333,"end_character":13},"in_reply_to":"1e7a9500_6fb46a78","updated":"2022-03-15 18:23:19.000000000","message":"Done","commit_id":"c042b6c1c6a0538a17439f74561a02febf8e7742"}]}