)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"aef3a680381749858fbb62da1644f6d7afe8fbdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"179debbf_93d033bf","updated":"2022-04-07 17:08:54.000000000","message":"recheck","commit_id":"a12d38464b3cf2cde4aac6c51968d7afb9c4cf0b"}],"zuul.d/jobs-openstack-helm.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"51230d957049408a6dafaa6a17aefd8b1d926531","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        - ./tools/deployment/common/install-packages.sh"},{"line_number":177,"context_line":"        - ./tools/gate/deploy-k8s.sh"},{"line_number":178,"context_line":"        - - ./tools/deployment/common/setup-client.sh"},{"line_number":179,"context_line":"        - - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":180,"context_line":"          - ./tools/deployment/component/compute-kit/openvswitch.sh"},{"line_number":181,"context_line":"        - ./tools/deployment/component/compute-kit/libvirt.sh"},{"line_number":182,"context_line":"        - ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":183,"context_line":"        - - export OSH_TEST_TIMEOUT\u003d1200;./tools/deployment/common/run-helm-tests.sh neutron"},{"line_number":184,"context_line":"          - ./tools/deployment/common/run-helm-tests.sh nova;"},{"line_number":185,"context_line":"            ./tools/deployment/common/run-helm-tests.sh glance;"},{"line_number":186,"context_line":"            ./tools/deployment/common/run-helm-tests.sh keystone;"},{"line_number":187,"context_line":"        - ./tools/deployment/developer/common/170-setup-gateway.sh"},{"line_number":188,"context_line":"        - - ./tools/deployment/developer/common/900-use-it.sh"},{"line_number":189,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"50dd7222_751b1e29","line":186,"range":{"start_line":179,"start_character":0,"end_line":186,"end_character":65},"updated":"2022-04-06 15:41:50.000000000","message":"you will need mariadb here before any of the openstack services will deploy.","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"7d8a3cc03c25a626791cab5cecc1a91606228451","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        - ./tools/deployment/common/install-packages.sh"},{"line_number":177,"context_line":"        - ./tools/gate/deploy-k8s.sh"},{"line_number":178,"context_line":"        - - ./tools/deployment/common/setup-client.sh"},{"line_number":179,"context_line":"        - - ./tools/deployment/component/common/rabbitmq.sh"},{"line_number":180,"context_line":"          - ./tools/deployment/component/compute-kit/openvswitch.sh"},{"line_number":181,"context_line":"        - ./tools/deployment/component/compute-kit/libvirt.sh"},{"line_number":182,"context_line":"        - ./tools/deployment/component/compute-kit/compute-kit.sh"},{"line_number":183,"context_line":"        - - export OSH_TEST_TIMEOUT\u003d1200;./tools/deployment/common/run-helm-tests.sh neutron"},{"line_number":184,"context_line":"          - ./tools/deployment/common/run-helm-tests.sh nova;"},{"line_number":185,"context_line":"            ./tools/deployment/common/run-helm-tests.sh glance;"},{"line_number":186,"context_line":"            ./tools/deployment/common/run-helm-tests.sh keystone;"},{"line_number":187,"context_line":"        - ./tools/deployment/developer/common/170-setup-gateway.sh"},{"line_number":188,"context_line":"        - - ./tools/deployment/developer/common/900-use-it.sh"},{"line_number":189,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ac3eb27_1f0cc4c0","line":186,"range":{"start_line":179,"start_character":0,"end_line":186,"end_character":65},"in_reply_to":"50dd7222_751b1e29","updated":"2022-04-07 15:30:30.000000000","message":"Done","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"9f6da77c8c345ef9c22342e568973b0a31207d74","unresolved":true,"context_lines":[{"line_number":167,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"- job:"},{"line_number":170,"context_line":"    name: openstack-helm-compute-kit-umbrella"},{"line_number":171,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":172,"context_line":"    vars:"},{"line_number":173,"context_line":"      run_helm_tests: \"no\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0f965daf_455dc9cf","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":45},"updated":"2022-04-08 19:48:40.000000000","message":"If the umbrella chart is deploying existing charts, we might not need to run this\non every patchset if we\u0027re not actively changing the umbrella chart since this is basically doing the same thing as the existing jobs.\n\nWe can look into adding a files entry here for this job to only run it when someone touches the umbrella chart, or move it to periodic. This can be done in a future change.","commit_id":"0da3bfb941eb9d332667cdd93ad40e38eb811578"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"b091e868f7d361ac1666f0d71e2d31b57d9f7e21","unresolved":false,"context_lines":[{"line_number":167,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"- job:"},{"line_number":170,"context_line":"    name: openstack-helm-compute-kit-umbrella"},{"line_number":171,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":172,"context_line":"    vars:"},{"line_number":173,"context_line":"      run_helm_tests: \"no\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"793d5b73_5cb41d1d","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":45},"in_reply_to":"0f965daf_455dc9cf","updated":"2022-04-08 19:52:36.000000000","message":"I think its needed because a change not related to the umbrella chart could break the deployment for the umbrella even if someone isn\u0027t working on the umbrella chart specifically","commit_id":"0da3bfb941eb9d332667cdd93ad40e38eb811578"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"e5cf88334044e1d2bb1b8414201d6fb83a58fd35","unresolved":true,"context_lines":[{"line_number":167,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"- job:"},{"line_number":170,"context_line":"    name: openstack-helm-compute-kit-umbrella"},{"line_number":171,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":172,"context_line":"    vars:"},{"line_number":173,"context_line":"      run_helm_tests: \"no\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f13c4d23_f0d072ef","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":45},"in_reply_to":"0f965daf_455dc9cf","updated":"2022-04-08 19:53:16.000000000","message":"I would say it should run anytime Umbrella chart is updated itself, or any of the charts contained in the umbrella. Otherwise for example someone could revert Graham\u0027s PS which conditionally changes {{ Release.name }} to {{ Chart.name }} in the subcharts and not know they have broken the umbrella chart.\n\nBut I agree it does not need to run for charts that are not contained in the umbrella.","commit_id":"0da3bfb941eb9d332667cdd93ad40e38eb811578"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"e21314f51a26b555a2b1dccabdba5ef570a0c0ac","unresolved":false,"context_lines":[{"line_number":167,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"- job:"},{"line_number":170,"context_line":"    name: openstack-helm-compute-kit-umbrella"},{"line_number":171,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":172,"context_line":"    vars:"},{"line_number":173,"context_line":"      run_helm_tests: \"no\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"260a705d_adf2a9d2","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":45},"in_reply_to":"39b47721_68c7d793","updated":"2022-04-08 20:02:16.000000000","message":"Yeah, just trying to avoid having a large number of tests per chart that can balloon up quickly.","commit_id":"0da3bfb941eb9d332667cdd93ad40e38eb811578"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"ad24ac0b3687df49a4402a4ef45b87e56d3c94f1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"          - ./tools/deployment/common/force-cronjob-run.sh"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"- job:"},{"line_number":170,"context_line":"    name: openstack-helm-compute-kit-umbrella"},{"line_number":171,"context_line":"    parent: openstack-helm-chart-deploy"},{"line_number":172,"context_line":"    vars:"},{"line_number":173,"context_line":"      run_helm_tests: \"no\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"39b47721_68c7d793","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":45},"in_reply_to":"f13c4d23_f0d072ef","updated":"2022-04-08 19:59:15.000000000","message":"I hope Craig explained it well that test of changes is required because it can affect Umbrella chart.","commit_id":"0da3bfb941eb9d332667cdd93ad40e38eb811578"}],"zuul.d/project.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"611f6c7223d87815ab2963282408f34228ae4e91","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      - release-notes-jobs-python3"},{"line_number":22,"context_line":"    check:"},{"line_number":23,"context_line":"      jobs:"},{"line_number":24,"context_line":"        - openstack-helm-lint"},{"line_number":25,"context_line":"        - openstack-helm-bandit"},{"line_number":26,"context_line":"        - openstack-helm-cinder-train-ubuntu_bionic"},{"line_number":27,"context_line":"        - openstack-helm-cinder-ussuri-ubuntu_bionic"},{"line_number":28,"context_line":"        - openstack-helm-cinder-victoria-ubuntu_focal"},{"line_number":29,"context_line":"        - openstack-helm-cinder-wallaby-ubuntu_focal"},{"line_number":30,"context_line":"        # - openstack-helm-cinder-xena-ubuntu_focal"},{"line_number":31,"context_line":"        - openstack-helm-compute-kit-train-ubuntu_bionic"},{"line_number":32,"context_line":"        - openstack-helm-compute-kit-ussuri-ubuntu_bionic"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit-victoria-ubuntu_focal"},{"line_number":34,"context_line":"        - openstack-helm-umbrella-compute-kit-victoria-ubuntu_focal"},{"line_number":35,"context_line":"        - openstack-helm-compute-kit-wallaby-ubuntu_focal"},{"line_number":36,"context_line":"        # - openstack-helm-compute-kit-xena-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ebda44db_a927f354","line":33,"range":{"start_line":24,"start_character":0,"end_line":33,"end_character":58},"updated":"2022-04-06 15:42:49.000000000","message":"I recommend commenting these jobs out (all but the one you are adding), while you test your new job to avoid wasting resources and also saving you runtime between checks.","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"7d8a3cc03c25a626791cab5cecc1a91606228451","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - release-notes-jobs-python3"},{"line_number":22,"context_line":"    check:"},{"line_number":23,"context_line":"      jobs:"},{"line_number":24,"context_line":"        - openstack-helm-lint"},{"line_number":25,"context_line":"        - openstack-helm-bandit"},{"line_number":26,"context_line":"        - openstack-helm-cinder-train-ubuntu_bionic"},{"line_number":27,"context_line":"        - openstack-helm-cinder-ussuri-ubuntu_bionic"},{"line_number":28,"context_line":"        - openstack-helm-cinder-victoria-ubuntu_focal"},{"line_number":29,"context_line":"        - openstack-helm-cinder-wallaby-ubuntu_focal"},{"line_number":30,"context_line":"        # - openstack-helm-cinder-xena-ubuntu_focal"},{"line_number":31,"context_line":"        - openstack-helm-compute-kit-train-ubuntu_bionic"},{"line_number":32,"context_line":"        - openstack-helm-compute-kit-ussuri-ubuntu_bionic"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit-victoria-ubuntu_focal"},{"line_number":34,"context_line":"        - openstack-helm-umbrella-compute-kit-victoria-ubuntu_focal"},{"line_number":35,"context_line":"        - openstack-helm-compute-kit-wallaby-ubuntu_focal"},{"line_number":36,"context_line":"        # - openstack-helm-compute-kit-xena-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa00c1b9_9513b52e","line":33,"range":{"start_line":24,"start_character":0,"end_line":33,"end_character":58},"in_reply_to":"ebda44db_a927f354","updated":"2022-04-07 15:30:30.000000000","message":"Done","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"611f6c7223d87815ab2963282408f34228ae4e91","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        - openstack-helm-compute-kit-ussuri-ubuntu_bionic"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit-victoria-ubuntu_focal"},{"line_number":34,"context_line":"        - openstack-helm-umbrella-compute-kit-victoria-ubuntu_focal"},{"line_number":35,"context_line":"        - openstack-helm-compute-kit-wallaby-ubuntu_focal"},{"line_number":36,"context_line":"        # - openstack-helm-compute-kit-xena-ubuntu_focal"},{"line_number":37,"context_line":"        - openstack-helm-horizon-train-ubuntu_bionic"},{"line_number":38,"context_line":"        - openstack-helm-keystone-ldap"},{"line_number":39,"context_line":"    gate:"},{"line_number":40,"context_line":"      jobs:"},{"line_number":41,"context_line":"        - openstack-helm-lint"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba326329_81b2d384","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":38},"updated":"2022-04-06 15:42:49.000000000","message":"ditto","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"},{"author":{"_account_id":32090,"name":"Graham Steffaniak","email":"graham.steffaniak@att.com","username":"gs909v"},"change_message_id":"7d8a3cc03c25a626791cab5cecc1a91606228451","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        - openstack-helm-compute-kit-ussuri-ubuntu_bionic"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit-victoria-ubuntu_focal"},{"line_number":34,"context_line":"        - openstack-helm-umbrella-compute-kit-victoria-ubuntu_focal"},{"line_number":35,"context_line":"        - openstack-helm-compute-kit-wallaby-ubuntu_focal"},{"line_number":36,"context_line":"        # - openstack-helm-compute-kit-xena-ubuntu_focal"},{"line_number":37,"context_line":"        - openstack-helm-horizon-train-ubuntu_bionic"},{"line_number":38,"context_line":"        - openstack-helm-keystone-ldap"},{"line_number":39,"context_line":"    gate:"},{"line_number":40,"context_line":"      jobs:"},{"line_number":41,"context_line":"        - openstack-helm-lint"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb29f50b_6896c11c","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":38},"in_reply_to":"ba326329_81b2d384","updated":"2022-04-07 15:30:30.000000000","message":"Done","commit_id":"9f9adce90e8ec1aca69b3dd2d9cfeccaafe460f6"}]}