)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"change_message_id":"9332e556b1ac92d0010810f6d72e786caff62933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"071430b2_599e1779","updated":"2022-04-07 14:26:31.000000000","message":"this was tested in production and works as expected","commit_id":"ca280be518cf540a2507569fc3b00bd3e73a3698"}],"neutron/templates/bin/_neutron-openvswitch-agent-init.sh.tpl":[{"author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"change_message_id":"5bdf18ddb25aede2cf662b8c02def42e4eace7a0","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":"  elif [[ -n \"${bridge_ip}\" \u0026\u0026 -n \"${bridge_prefix}\" ]]; then"},{"line_number":132,"context_line":"    echo \"Bridge \u0027${bridge_name}\u0027 already has IP assigned. Keeping the same:: IP:[${bridge_ip}]; Prefix:[${bridge_prefix}]...\""},{"line_number":133,"context_line":"  else"},{"line_number":134,"context_line":"    echo \"Interface ${name} has invalid IP address. IP:[${ip}]; Prefix:[${prefix}]...\""},{"line_number":135,"context_line":"    exit 1"},{"line_number":136,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"cce788dd_83c48644","line":133,"updated":"2022-04-07 22:29:34.000000000","message":"i think we should add another elif before this to cover interfaces which has no ip to be migrated to the bridge. \n\nSomething similar to this:\n\n   .....\nelif [[ -z \"${bridge_ip}\" \u0026\u0026 -z \"${ip}\" ]]; then\n    echo \"Interface and bridge has no ips configured...\"\nelse\n   .....\n\nthat way we cover all use cases for ip migration:\n\n- migrate ip to bridge\n- keep ip in bridges if configured\n- dont do anything in case the interface and bridge are not meant to have an ip","commit_id":"ca280be518cf540a2507569fc3b00bd3e73a3698"},{"author":{"_account_id":28008,"name":"Guilherme","display_name":"Guilherme Steinmüller","email":"gsteinmuller@vexxhost.com","username":"guilhermesp"},"change_message_id":"420bc05c7a75218e2094ca5dd9c627fbb7399cac","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":"  elif [[ -n \"${bridge_ip}\" \u0026\u0026 -n \"${bridge_prefix}\" ]]; then"},{"line_number":132,"context_line":"    echo \"Bridge \u0027${bridge_name}\u0027 already has IP assigned. Keeping the same:: IP:[${bridge_ip}]; Prefix:[${bridge_prefix}]...\""},{"line_number":133,"context_line":"  else"},{"line_number":134,"context_line":"    echo \"Interface ${name} has invalid IP address. IP:[${ip}]; Prefix:[${prefix}]...\""},{"line_number":135,"context_line":"    exit 1"},{"line_number":136,"context_line":"  fi"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"d2a70626_0bedf6e8","line":133,"in_reply_to":"cce788dd_83c48644","updated":"2022-04-08 14:47:11.000000000","message":"Done","commit_id":"ca280be518cf540a2507569fc3b00bd3e73a3698"}]}