)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"902bd039a541dcbe143da09b9142d35373b27343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5c5e2c7d_f49d687f","updated":"2022-05-02 21:26:01.000000000","message":"i","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"}],"cinder/values.yaml":[{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"902bd039a541dcbe143da09b9142d35373b27343","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"f0969ec0_742819a3","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"updated":"2022-05-02 21:26:01.000000000","message":"i\u0027m having troubles reconciling this structure with values_overrides. what is \"group:\"?\n\nhow would you grant access to more than one project in the same domain?","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"aa784c06d52a80a57f704a3f867ce4439a0f4694","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"af302af9_6b12950c","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"in_reply_to":"00db9de3_4619d61a","updated":"2022-05-02 21:43:39.000000000","message":"isn\u0027t that a duplicate key? i think in this case probably only projectB would get access.\n\n(yes, ignore the previous comments about the pre-existing stuff, although it might be nice to cleanup.)","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"43ee9e028b31f730acd1755c9832f1ec88eda7dd","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"dce7be8c_29dc16a2","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"in_reply_to":"333d4479_0ef5a72d","updated":"2022-05-03 13:46:08.000000000","message":"This is a good point. What do you think about:\ngrant_access:\n  domainA:\n    - projectA\n    - projectB\n  domainB:\n    - projectC\n    - projectD","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"},{"author":{"_account_id":28719,"name":"Phil Sphicas","email":"phil.sphicas@att.com","username":"ps3910"},"change_message_id":"88d145f3423bc56efe4333530228feeff5c6276b","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"333d4479_0ef5a72d","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"in_reply_to":"3bfb7f59_875b7774","updated":"2022-05-03 00:02:04.000000000","message":"I\u0027m just looking at the duplicated map keys in the YAML, which are not allowed by the YAML spec. The way Helm handles it, I believe that the second value with key \u0027mydomain\u0027 will overwrite the first.\n\nThese two end up being effectively the same:\n\n  grant_access:\n    mydomain: projectA\n    mydomain: projectB\n\n  grant_access:\n    mydomain: projectB","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"78762a7ac4a4c17b9b9ba451785604ef6bb269e2","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3bfb7f59_875b7774","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"in_reply_to":"af302af9_6b12950c","updated":"2022-05-02 21:50:42.000000000","message":"Not really. This is translated into:\nopenstack volume type set --project-domain mydomain --project projectA\nopenstack volume type set --project-domain mydomain --project projectB\nand finally will be represented as:\n\u003c...\u003e\n| access_project_ids | 1d77622a9e1748569f1969f6e1c1c5f3, 5a84e6ac41f74dacab1a3c69fa748d80 |\n\u003c...\u003e\nThe domain part allows us to identify the project ID even if two different domains have a project with the same name (which is impossible by default since Pike I believe) But if we are using the name instead of ID, this is a recommended practice to provide a domain.","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"},{"author":{"_account_id":32433,"name":"Vladimir Sigunov","email":"vladimir.sigunov@att.com","username":"vs422h"},"change_message_id":"ec58e07b22e8e853968167ff2860326c6429fc9b","unresolved":true,"context_lines":[{"line_number":364,"context_line":"  enabled: true"},{"line_number":365,"context_line":"  ks_user: admin"},{"line_number":366,"context_line":"  bootstrap_conf_backends: true"},{"line_number":367,"context_line":"  volume_types:"},{"line_number":368,"context_line":"    name:"},{"line_number":369,"context_line":"      group:"},{"line_number":370,"context_line":"      volume_backend_name:"},{"line_number":371,"context_line":"      # access_type: \"private\""},{"line_number":372,"context_line":"      # If you set up access_type to private, only the creator"},{"line_number":373,"context_line":"      # will get an access to the volume type. You can extend"},{"line_number":374,"context_line":"      # the access to your volume type by providing a list of"},{"line_number":375,"context_line":"      # domain names and projects as shown below"},{"line_number":376,"context_line":"      # grant_access:"},{"line_number":377,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":378,"context_line":"      #   \u003cdomain name\u003e: \u003cproject name\u003e"},{"line_number":379,"context_line":"  # Volume QoS if any. By default, None QoS is created."},{"line_number":380,"context_line":"  # Below values with a number at the end need to be replaced"},{"line_number":381,"context_line":"  # with real names."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"00db9de3_4619d61a","line":378,"range":{"start_line":367,"start_character":0,"end_line":378,"end_character":39},"in_reply_to":"f0969ec0_742819a3","updated":"2022-05-02 21:40:44.000000000","message":"group was merged previously: https://opendev.org/openstack/openstack-helm/src/branch/master/cinder/values.yaml#L369\nSimply didn\u0027t touch it.\n\nFor different projects inside the same domain the structure is the same:\ngrant_access:\n  mydomain: projectA\n  mydomain: projectB","commit_id":"656e00bde68b2fa7f901cccfac4c40003e643a64"}]}