)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c3ac7df0645f261183fedb600f7177ef9a0d9963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"946fa9b2_3f276585","updated":"2022-06-11 20:27:17.000000000","message":"I couldn\u0027t find the output of the script you modified (it\u0027s here somewhere), but looking in one of the other libvirt log files we can see that HugePages_Total did not exist in /proc/meminfo, assuming it\u0027s using similar comparison logic.\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c87/845299/11/check/openstack-helm-compute-kit-ussuri-ubuntu_bionic/c878384/primary/pod-logs/openstack/libvirt-libvirt-default-d6bl9/libvirt.txt\n\n++ cat /proc/meminfo\n++ grep HugePages_Total\n++ tr -cd \u0027[:digit:]\u0027\n+ hp_count\u003d0\n+ \u0027[\u0027 00 -gt 0 \u0027]\u0027","commit_id":"2129f8ea3d80ed25ff432a2a0a20980ed7986191"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"79179f0b0aea13fdc74141d79bf33dbbe1e13a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c7d6d386_7822709c","updated":"2022-06-10 21:19:28.000000000","message":"Thanks Dylan, lgtm","commit_id":"2129f8ea3d80ed25ff432a2a0a20980ed7986191"}],"tools/deployment/component/common/openstack.sh":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"3b6fb70e42dbc2d80fb37bc197b000d1863ab3b8","unresolved":true,"context_lines":[{"line_number":19,"context_line":": \"${RUN_HELM_TESTS:\u003d\"no\"}\""},{"line_number":20,"context_line":": \"${CEPH_ENABLED:\u003d\"false\"}\""},{"line_number":21,"context_line":": \"${OSH_EXTRA_HELM_ARGS:\u003d\"\"}\""},{"line_number":22,"context_line":": \"${OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP:\u003d\"\"}\""},{"line_number":23,"context_line":"release\u003dopenstack"},{"line_number":24,"context_line":"namespace\u003d$release"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"d356b03d_2d2923ee","line":22,"updated":"2022-06-10 14:51:10.000000000","message":"nitpick: I\u0027d remove this line because a user couldn\u0027t actually control providing this because we\u0027ll override it on line 86.\n\nThe other vars here someone could provide and we wouldn\u0027t override them.","commit_id":"f7f122899a935223424385b32a74917a111be41b"},{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"e500c32b5a827198d3499b20fae3e9072b533231","unresolved":false,"context_lines":[{"line_number":19,"context_line":": \"${RUN_HELM_TESTS:\u003d\"no\"}\""},{"line_number":20,"context_line":": \"${CEPH_ENABLED:\u003d\"false\"}\""},{"line_number":21,"context_line":": \"${OSH_EXTRA_HELM_ARGS:\u003d\"\"}\""},{"line_number":22,"context_line":": \"${OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP:\u003d\"\"}\""},{"line_number":23,"context_line":"release\u003dopenstack"},{"line_number":24,"context_line":"namespace\u003d$release"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"338bb71c_631f1fc7","line":22,"in_reply_to":"d356b03d_2d2923ee","updated":"2022-06-10 14:54:24.000000000","message":"Ah you know what, I\u0027d added that forgetting that bash can handle empty variables just fine. You\u0027re totally right","commit_id":"f7f122899a935223424385b32a74917a111be41b"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"0ac998598e5e5045ba4170d2716d0f8dc925730c","unresolved":true,"context_lines":[{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"if [ `grep -i HugePages_Total /proc/meminfo | awk \u0027{print $2}\u0027` -ne 0 ]; then"},{"line_number":85,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"16824444_8a17791b","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":6},"updated":"2022-06-10 15:05:46.000000000","message":"I would suggest do not use \\`\\`\nTh best practice and safe way to $() in Bash3\nAlso, awk has imbedded search, so pipe is redundant there.","commit_id":"ddbef71d17c6fd7eb861665ac37eca69cf76798e"},{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"f7d13c4745c4bc58271b02246b711b1ce8633f9b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"if [ `grep -i HugePages_Total /proc/meminfo | awk \u0027{print $2}\u0027` -ne 0 ]; then"},{"line_number":85,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"b36501e1_c03bc9bb","line":84,"range":{"start_line":84,"start_character":5,"end_line":84,"end_character":6},"in_reply_to":"16824444_8a17791b","updated":"2022-06-10 15:35:39.000000000","message":"Done","commit_id":"ddbef71d17c6fd7eb861665ac37eca69cf76798e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee46ff9b17955011583132871d41afe0759c2d25","unresolved":true,"context_lines":[{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"if [ $(awk \u0027/HugePages_Total/{print $2}\u0027 /proc/meminfo) -ne 0 ]; then"},{"line_number":85,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"d5b34a59_9265ed3b","line":84,"updated":"2022-06-10 20:18:51.000000000","message":"Should assign this to a local, then check for zero string too, something like\n\n[ ! -z \"$hpgs\" \u0026\u0026 $hpgs -ne 0 ]\n\nOr maybe a single if works?\n\n[ \"x$hpgs\" !\u003d \"x0\" ]\n\nMy guess is Ussuri is booting an even older kernel that doesn\u0027t have any output in /proc/meminfo for this.","commit_id":"494e42e675d40ba90fc0dec8dd7f10a929b5132f"},{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"03b9efcdc0ab62b63fb806a5021240e9dad98394","unresolved":false,"context_lines":[{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"if [ $(awk \u0027/HugePages_Total/{print $2}\u0027 /proc/meminfo) -ne 0 ]; then"},{"line_number":85,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"12c77d6f_49ade701","line":84,"in_reply_to":"4f230478_9524f817","updated":"2022-06-10 21:02:32.000000000","message":"Done","commit_id":"494e42e675d40ba90fc0dec8dd7f10a929b5132f"},{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"081ded8fa96d3c642e687224f558c9d285a3dbda","unresolved":true,"context_lines":[{"line_number":81,"context_line":"fi"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"if [ $(awk \u0027/HugePages_Total/{print $2}\u0027 /proc/meminfo) -ne 0 ]; then"},{"line_number":85,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":86,"context_line":"fi"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"4f230478_9524f817","line":84,"in_reply_to":"d5b34a59_9265ed3b","updated":"2022-06-10 20:43:10.000000000","message":"Awesome, great catch, thank you! Giving that a shot.","commit_id":"494e42e675d40ba90fc0dec8dd7f10a929b5132f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"74ec65b1ae8acd73bdb07774cd03531b4aa89919","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"hgpgs_available\u003d$(awk \u0027/HugePages_Total/{print $2}\u0027 /proc/meminfo)"},{"line_number":85,"context_line":"if [ ! -z $hgpgs_available \u0026\u0026 $hgpgs_available -ne 0 ]; then"},{"line_number":86,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"05378704_29934193","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":26},"updated":"2022-06-10 20:53:54.000000000","message":"Should put \"\" around this as if it\u0027s empty will cause problems, or do like L77 does with a string compare.","commit_id":"5e0473d45f34f9ac072106387ee51e4943a944d1"},{"author":{"_account_id":34668,"name":"Dylan Murphy","email":"v-dymurphy@microsoft.com","username":"dmurphy-igms"},"change_message_id":"03b9efcdc0ab62b63fb806a5021240e9dad98394","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Check if Hugepages is enabled"},{"line_number":84,"context_line":"hgpgs_available\u003d$(awk \u0027/HugePages_Total/{print $2}\u0027 /proc/meminfo)"},{"line_number":85,"context_line":"if [ ! -z $hgpgs_available \u0026\u0026 $hgpgs_available -ne 0 ]; then"},{"line_number":86,"context_line":"  OSH_EXTRA_HELM_ARGS_LIBVIRT_CGROUP\u003d\"--set libvirt.conf.kubernetes.cgroup\u003d.\""},{"line_number":87,"context_line":"fi"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-sh","patch_set":10,"id":"73bc39d0_eedebf2a","line":85,"range":{"start_line":85,"start_character":10,"end_line":85,"end_character":26},"in_reply_to":"05378704_29934193","updated":"2022-06-10 21:02:32.000000000","message":"Done","commit_id":"5e0473d45f34f9ac072106387ee51e4943a944d1"}]}