)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"238ad92ecd02cb2e4821747ebfdf92e74f72b890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ab419e61_e2c729db","updated":"2022-07-15 14:49:52.000000000","message":"assuming this isn\u0027t ready/tested?","commit_id":"853c2b966de9f4afcdd4fec62fcd8e9234c78f78"},{"author":{"_account_id":35024},"change_message_id":"48064ae4008493d36924644a7e9d32fda4c1d2e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5dfbffb3_398eb6ec","updated":"2022-07-15 19:30:23.000000000","message":"-1 just for the \u0027keypair list\u0027 comment.","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":35024},"change_message_id":"eb62e150b9b4528a71be5b318065f603701d6350","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"42e3b30c_62af7258","updated":"2022-07-19 15:08:41.000000000","message":"recheck - xena job unstable","commit_id":"d11f018d02a8659f2e2d0388b2337c2f407de11a"},{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"7a09e4779f02a1de8c55f7f6e0fc61d3dce2c3e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c7a2c7d8_ab5974ac","updated":"2022-07-22 14:20:42.000000000","message":"recheck","commit_id":"5644b08c5c0c06896331f0d787b51ce5e052baca"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"fb66f2c6f4a3a39e03bd136d1c3ecc757dc071af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9af8f694_a51d3004","updated":"2022-07-22 05:13:33.000000000","message":"recheck - unstable glance endpoint during heat run","commit_id":"5644b08c5c0c06896331f0d787b51ce5e052baca"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"d6a2ea1c26f4f46710e7ece3b9a47cebc60e8945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b4a9c120_a6110800","updated":"2022-07-19 19:32:48.000000000","message":"recheck - xena","commit_id":"5644b08c5c0c06896331f0d787b51ce5e052baca"}],"tools/deployment/developer/common/900-use-it.sh":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"238ad92ecd02cb2e4821747ebfdf92e74f72b890","unresolved":true,"context_lines":[{"line_number":19,"context_line":": ${OSH_EXT_SUBNET_NAME:\u003d\"public-subnet\"}"},{"line_number":20,"context_line":": ${OSH_EXT_SUBNET:\u003d\"172.24.4.0/24\"}"},{"line_number":21,"context_line":": ${OSH_BR_EX_ADDR:\u003d\"172.24.4.1/24\"}"},{"line_number":22,"context_line":"openstsack stack list | grep  -q \"heat-public-net-deployment\" || \\"},{"line_number":23,"context_line":"  openstack stack create --wait \\"},{"line_number":24,"context_line":"    --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":25,"context_line":"    --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"0451505a_3c1f5fd4","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":11},"updated":"2022-07-15 14:49:52.000000000","message":"spelling?","commit_id":"853c2b966de9f4afcdd4fec62fcd8e9234c78f78"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"311933a148f4e5627f00d61d61d899c041d70bd3","unresolved":false,"context_lines":[{"line_number":19,"context_line":": ${OSH_EXT_SUBNET_NAME:\u003d\"public-subnet\"}"},{"line_number":20,"context_line":": ${OSH_EXT_SUBNET:\u003d\"172.24.4.0/24\"}"},{"line_number":21,"context_line":": ${OSH_BR_EX_ADDR:\u003d\"172.24.4.1/24\"}"},{"line_number":22,"context_line":"openstsack stack list | grep  -q \"heat-public-net-deployment\" || \\"},{"line_number":23,"context_line":"  openstack stack create --wait \\"},{"line_number":24,"context_line":"    --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":25,"context_line":"    --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"c6e39a39_a88229dc","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":11},"in_reply_to":"0451505a_3c1f5fd4","updated":"2022-07-15 18:24:02.000000000","message":"Done","commit_id":"853c2b966de9f4afcdd4fec62fcd8e9234c78f78"},{"author":{"_account_id":35024},"change_message_id":"48064ae4008493d36924644a7e9d32fda4c1d2e7","unresolved":true,"context_lines":[{"line_number":19,"context_line":": ${OSH_EXT_SUBNET_NAME:\u003d\"public-subnet\"}"},{"line_number":20,"context_line":": ${OSH_EXT_SUBNET:\u003d\"172.24.4.0/24\"}"},{"line_number":21,"context_line":": ${OSH_BR_EX_ADDR:\u003d\"172.24.4.1/24\"}"},{"line_number":22,"context_line":"openstack stack list | grep  -q \"heat-public-net-deployment\" || \\"},{"line_number":23,"context_line":"  openstack stack create --wait \\"},{"line_number":24,"context_line":"    --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":25,"context_line":"    --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5bcc13df_71931acb","line":22,"updated":"2022-07-15 19:30:23.000000000","message":"Using list w/grep is Ok, will just point out an alternative, but don\u0027t need to change.\n\n\u0027openstack stack show heat-public-net-deployment -q\u0027 is probably better since the grep could technically match a stack with this substring, although it\u0027s unlikely to exist. I think the -q would go at the end so you don\u0027t generate a \"resource does not exist\" output.\n\nSame would apply below.","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"87894247602b8705a66c8b4f6a5532a40b43917e","unresolved":false,"context_lines":[{"line_number":19,"context_line":": ${OSH_EXT_SUBNET_NAME:\u003d\"public-subnet\"}"},{"line_number":20,"context_line":": ${OSH_EXT_SUBNET:\u003d\"172.24.4.0/24\"}"},{"line_number":21,"context_line":": ${OSH_BR_EX_ADDR:\u003d\"172.24.4.1/24\"}"},{"line_number":22,"context_line":"openstack stack list | grep  -q \"heat-public-net-deployment\" || \\"},{"line_number":23,"context_line":"  openstack stack create --wait \\"},{"line_number":24,"context_line":"    --parameter network_name\u003d${OSH_EXT_NET_NAME} \\"},{"line_number":25,"context_line":"    --parameter physical_network_name\u003dpublic \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"a376ea88_103e1f0c","line":22,"in_reply_to":"5bcc13df_71931acb","updated":"2022-07-19 16:47:49.000000000","message":"Done","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":35024},"change_message_id":"48064ae4008493d36924644a7e9d32fda4c1d2e7","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Setup SSH Keypair in Nova"},{"line_number":53,"context_line":"mkdir -p ${HOME}/.ssh"},{"line_number":54,"context_line":"openstack keypair list \"${OSH_VM_KEY_STACK}\" | grep  -q \"heat-basic-vm-deployment\" || \\"},{"line_number":55,"context_line":"  openstack keypair create --private-key ${HOME}/.ssh/osh_key ${OSH_VM_KEY_STACK}"},{"line_number":56,"context_line":"chmod 600 ${HOME}/.ssh/osh_key"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"d8529522_69e72d26","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":44},"updated":"2022-07-15 19:30:23.000000000","message":"\u0027keypair list\u0027 does not take a required argument, it will just be ignored","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"87894247602b8705a66c8b4f6a5532a40b43917e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Setup SSH Keypair in Nova"},{"line_number":53,"context_line":"mkdir -p ${HOME}/.ssh"},{"line_number":54,"context_line":"openstack keypair list \"${OSH_VM_KEY_STACK}\" | grep  -q \"heat-basic-vm-deployment\" || \\"},{"line_number":55,"context_line":"  openstack keypair create --private-key ${HOME}/.ssh/osh_key ${OSH_VM_KEY_STACK}"},{"line_number":56,"context_line":"chmod 600 ${HOME}/.ssh/osh_key"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1376eb9b_0da548fa","line":54,"range":{"start_line":54,"start_character":23,"end_line":54,"end_character":44},"in_reply_to":"d8529522_69e72d26","updated":"2022-07-19 16:47:49.000000000","message":"Done","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":35024},"change_message_id":"48064ae4008493d36924644a7e9d32fda4c1d2e7","unresolved":true,"context_lines":[{"line_number":122,"context_line":"  openstack stack create --wait \\"},{"line_number":123,"context_line":"    --parameter instance_uuid\u003d${INSTANCE_ID} \\"},{"line_number":124,"context_line":"    -t ./tools/gate/files/heat-vm-volume-attach.yaml \\"},{"line_number":125,"context_line":"    heat-vm-volume-attach"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  # Get the devices that are present on the instance"},{"line_number":128,"context_line":"  DEVS_POST_ATTACH\u003d$(mktemp)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fd5a4353_18933fd3","line":125,"updated":"2022-07-15 19:30:23.000000000","message":"nit: you didn\u0027t indent this block like in the other changes above, helps to show it\u0027s related to L120","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"87894247602b8705a66c8b4f6a5532a40b43917e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  openstack stack create --wait \\"},{"line_number":123,"context_line":"    --parameter instance_uuid\u003d${INSTANCE_ID} \\"},{"line_number":124,"context_line":"    -t ./tools/gate/files/heat-vm-volume-attach.yaml \\"},{"line_number":125,"context_line":"    heat-vm-volume-attach"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  # Get the devices that are present on the instance"},{"line_number":128,"context_line":"  DEVS_POST_ATTACH\u003d$(mktemp)"}],"source_content_type":"text/x-sh","patch_set":5,"id":"843d536e_a355a7fa","line":125,"in_reply_to":"fd5a4353_18933fd3","updated":"2022-07-19 16:47:49.000000000","message":"Done","commit_id":"872c33b5ef46114d42aa5d48c79dae7d6d7a6a80"},{"author":{"_account_id":35024},"change_message_id":"d5ed30fe19a430149b3003907be6310f44b9476c","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Setup SSH Keypair in Nova"},{"line_number":53,"context_line":"mkdir -p ${HOME}/.ssh"},{"line_number":54,"context_line":"openstack keypair list"},{"line_number":55,"context_line":"openstack keypair list | grep  -q \"heat-basic-vm-deployment\" || \\"},{"line_number":56,"context_line":"  openstack keypair create --private-key ${HOME}/.ssh/osh_key ${OSH_VM_KEY_STACK}"},{"line_number":57,"context_line":"chmod 600 ${HOME}/.ssh/osh_key"}],"source_content_type":"text/x-sh","patch_set":7,"id":"77d3a6f9_843b7324","line":54,"updated":"2022-07-15 20:56:39.000000000","message":"Duplicate line","commit_id":"1aa49e2e10e017e58e19bf4ec10b2539beb62550"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"87894247602b8705a66c8b4f6a5532a40b43917e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Setup SSH Keypair in Nova"},{"line_number":53,"context_line":"mkdir -p ${HOME}/.ssh"},{"line_number":54,"context_line":"openstack keypair list"},{"line_number":55,"context_line":"openstack keypair list | grep  -q \"heat-basic-vm-deployment\" || \\"},{"line_number":56,"context_line":"  openstack keypair create --private-key ${HOME}/.ssh/osh_key ${OSH_VM_KEY_STACK}"},{"line_number":57,"context_line":"chmod 600 ${HOME}/.ssh/osh_key"}],"source_content_type":"text/x-sh","patch_set":7,"id":"57407436_db2eb077","line":54,"in_reply_to":"77d3a6f9_843b7324","updated":"2022-07-19 16:47:49.000000000","message":"Done","commit_id":"1aa49e2e10e017e58e19bf4ec10b2539beb62550"},{"author":{"_account_id":35024},"change_message_id":"d5ed30fe19a430149b3003907be6310f44b9476c","unresolved":true,"context_lines":[{"line_number":118,"context_line":"  DEVS_PRE_ATTACH\u003d$(mktemp)"},{"line_number":119,"context_line":"  ssh -i ${HOME}/.ssh/osh_key cirros@${FLOATING_IP} lsblk \u003e ${DEVS_PRE_ATTACH}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  openstack stack list"},{"line_number":122,"context_line":"  openstack stack list | grep  -q \"heat-vm-volume-attach\" || \\"},{"line_number":123,"context_line":"  # Create and attach a block device to the instance"},{"line_number":124,"context_line":"    openstack stack create --wait \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"6989ec3f_44374ea9","line":121,"updated":"2022-07-15 20:56:39.000000000","message":"Here too, unless the point was to print them all out","commit_id":"1aa49e2e10e017e58e19bf4ec10b2539beb62550"},{"author":{"_account_id":21991,"name":"Kostyantyn Kalynovskyi","email":"kkalinovskiy@gmail.com","username":"kkalynovskyi"},"change_message_id":"87894247602b8705a66c8b4f6a5532a40b43917e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  DEVS_PRE_ATTACH\u003d$(mktemp)"},{"line_number":119,"context_line":"  ssh -i ${HOME}/.ssh/osh_key cirros@${FLOATING_IP} lsblk \u003e ${DEVS_PRE_ATTACH}"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  openstack stack list"},{"line_number":122,"context_line":"  openstack stack list | grep  -q \"heat-vm-volume-attach\" || \\"},{"line_number":123,"context_line":"  # Create and attach a block device to the instance"},{"line_number":124,"context_line":"    openstack stack create --wait \\"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3afa74ef_1a213ed9","line":121,"in_reply_to":"6989ec3f_44374ea9","updated":"2022-07-19 16:47:49.000000000","message":"yea, it was test. removed now","commit_id":"1aa49e2e10e017e58e19bf4ec10b2539beb62550"}]}