)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"9ab01640b4da448ab9370334d80ef07f0a9e6afc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8d63f6df_f2b43589","updated":"2022-08-04 20:05:53.000000000","message":"LGTM\n\nquestion: Do you know if this works automatically for the keystone jobs like ks-user? I would assume so. Just curious if you\u0027ve tried it.","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":35024},"change_message_id":"05efdf23a66ed29f000ac32fb9928308483495ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e37a542f_7dc331fb","updated":"2022-08-05 14:47:29.000000000","message":"Thanks for finding that Sharath, will push a new patch in a little bit.","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"8d21a756b1b69e54489e9c9c381fbebadcb41e9e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2bd644a_5557d792","updated":"2022-08-05 03:19:52.000000000","message":"Will need to submit a new patch-set by adding secret_registry component in values.yaml of all charts ","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"a9586dee548c6213b5d78423d9b0d87c0ab7d4dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c71c9cd2_61e52795","in_reply_to":"3b3f1d7e_84b8020a","updated":"2022-08-04 22:02:09.000000000","message":"I think we need to add a new component secret_registry in manifests: section for each chart in values.yaml in order to create a secret that holds the provided credentials (It is mentioned in the proposed spec).","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"326ac41e3369411179ce2236f1fb0e1b60acaa30","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3b3f1d7e_84b8020a","in_reply_to":"74a751d2_4044f1bd","updated":"2022-08-04 20:56:40.000000000","message":"I had checked by describing a selected pod for each OSH chart and observed the events and confirmed that test kubernetes-entry-point image is pulled from our internal ACR. Didn\u0027t check the jobs.","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":35024},"change_message_id":"549b6b951898012244a326a8eaf3c0a4292e7526","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74a751d2_4044f1bd","in_reply_to":"8d63f6df_f2b43589","updated":"2022-08-04 20:27:16.000000000","message":"Dustin - I added Sharath since he tested it and can maybe confirm, but AFAIK the deployment succeeded.","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":35024},"change_message_id":"161f963eaf7f5a6bd742866bf9fcec2fe4346afb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8da089a0_bda67c89","in_reply_to":"c2bd644a_5557d792","updated":"2022-08-05 16:08:08.000000000","message":"Done","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":35024},"change_message_id":"30e0a1efa0ee3602a281d70c194e633072615dff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bffea95f_fc179d7d","in_reply_to":"c71c9cd2_61e52795","updated":"2022-08-05 16:08:40.000000000","message":"Done","commit_id":"5dabe1a988eeb4f1fd4028d377393853ed8ee2b8"},{"author":{"_account_id":34623,"name":"Sharath Sangireddy","display_name":"Sharath Sangireddy","email":"v-sharatsang@microsoft.com","username":"sharatsang"},"change_message_id":"9d6be171ed2a56742ccd2cca87646e3abea19656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b27e98ba_fe7197e5","updated":"2022-08-05 20:47:10.000000000","message":"Confirmed that it works for keystone jobs like ks-user","commit_id":"fea67ec3cb3784bcc3b7713a2c8a0311b4fcd673"},{"author":{"_account_id":35024},"change_message_id":"6d89840202c66aedf590ccbac060f74e1a0ecf7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02be6e36_0334f578","updated":"2022-08-10 12:45:58.000000000","message":"Pushed a revert of my linting change that should fix this, https://review.opendev.org/c/openstack/openstack-helm/+/852755 - will investigate further later.","commit_id":"fea67ec3cb3784bcc3b7713a2c8a0311b4fcd673"}]}