)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35024},"change_message_id":"1b04aeec83a05e0c0adbaddd08d8436193a4474f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added horizon to install as default component"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added horizon to the openstack umbrella chart to deploy and enable"},{"line_number":10,"context_line":"by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia835c0c142d0e0878623af9165d595a386b7c4c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"27fac88c_7cc954cb","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":66},"updated":"2022-09-30 20:03:55.000000000","message":"/but disable","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"},{"author":{"_account_id":35024},"change_message_id":"ef82f93508bace12b6a4399407040d2b2ffbee2b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added horizon to install as default component"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added horizon to the openstack umbrella chart to deploy and enable"},{"line_number":10,"context_line":"by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia835c0c142d0e0878623af9165d595a386b7c4c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"be529235_b85b95e0","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":66},"in_reply_to":"27fac88c_7cc954cb","updated":"2022-10-03 15:50:14.000000000","message":"This is still wrong, it\u0027s disabled by default.","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"a6bc2643555512f94d3cfcbe040dd33556ab9f6a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added horizon to install as default component"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added horizon to the openstack umbrella chart to deploy and enable"},{"line_number":10,"context_line":"by default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia835c0c142d0e0878623af9165d595a386b7c4c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"7506de6a_d5d859c4","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":66},"in_reply_to":"be529235_b85b95e0","updated":"2022-10-03 16:10:02.000000000","message":"sorry...\ncommit amend done","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"9a5f5e3eeda74c0489307512e1db491928cdc5bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":57,"id":"6dec6b47_2eed9621","updated":"2022-10-04 13:49:05.000000000","message":"This also adds in another horizon job that isn\u0027t mentioned here, but that\u0027s fine.","commit_id":"94a8d348a9863188dc4e214831b80af2c3ba52c4"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"d73298b2255fc1fc4177d17ebe0cc78b1de67a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"babc015f_3f5eb7f0","in_reply_to":"6dec6b47_2eed9621","updated":"2022-10-04 13:50:46.000000000","message":"Yes. Added horizon job for victoria release","commit_id":"94a8d348a9863188dc4e214831b80af2c3ba52c4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35024},"change_message_id":"f93c11a6169cf5cf7b7439250f08861b6c0292a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b90cf143_a4d1ae93","updated":"2022-09-09 17:28:49.000000000","message":"Looks like this is failing in the post-install phase running this script:\n\n./tools/gate/tests/validate-umbrella-upgrade-no-side-effects.sh\n\nMaybe you will need to run that locally to see what it is doing and how it might be failing.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc0f555a_2464efc6","updated":"2022-09-09 20:53:29.000000000","message":"Not sure if my comments will fix the issue....","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35024},"change_message_id":"47b8213d4b4c53e997f50893490f3fa7edac817d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75020e3a_1326f8fc","updated":"2022-09-13 14:16:25.000000000","message":"Sunil - you have not squashed things correctly, there should only be one change and I counted 10 now :(  You should abandon all the other ones and make sure this is the one that is updated since it was first.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35024},"change_message_id":"ab4864dc1622f174e413c21bfffcd0fee783cbba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"767abbef_e6d3cedb","updated":"2022-09-20 14:16:18.000000000","message":"This also needs a change to zuul.d/jobs-openstack-helm.yaml to add horizon to the files: section for the umbrella job\n\nAnd we still don\u0027t know what is causing the failure?","commit_id":"03098bb1aa89aac507e51d78bb882dfa3e4f21ec"},{"author":{"_account_id":35024},"change_message_id":"8712e302fd480603f57108a07a0f9089ae7cbb56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3d9a7295_28b58ffd","updated":"2022-09-20 18:36:00.000000000","message":"Still missing change to zuul.d/jobs-openstack-helm.yaml","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2fd81b68_ca9c2ff1","in_reply_to":"3d9a7295_28b58ffd","updated":"2022-09-22 12:34:28.000000000","message":"updated jobs-openstack-helm.yaml","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35024},"change_message_id":"91d57bc857b6f77bd4ff8bf7a761a5e4b14fd614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d053ca50_ee78373e","updated":"2022-09-21 21:40:13.000000000","message":"Did you notice the horizon-db-sync pod is not running? I don\u0027t know why but it\u0027s causing the rest to fail.","commit_id":"e564bf547f9925365ab1f38a7016f40309612377"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f6feecd0_f5546b29","in_reply_to":"d053ca50_ee78373e","updated":"2022-09-22 12:34:28.000000000","message":"From where did you check that horizon-db-sync is not running?","commit_id":"e564bf547f9925365ab1f38a7016f40309612377"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"87ed46674746515b7afef5870cd9571f951c92a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c6ea1e03_db516baa","in_reply_to":"f6feecd0_f5546b29","updated":"2022-10-03 16:15:04.000000000","message":"Ack","commit_id":"e564bf547f9925365ab1f38a7016f40309612377"},{"author":{"_account_id":35024},"change_message_id":"0d1b4ecf3c734937b8e0eff871987c3ae9c79a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2f79d17e_2752f5b6","updated":"2022-09-22 21:57:55.000000000","message":"Have we figured out why this is still failing?","commit_id":"a937b6f91e0d4c319a5e9facda1bc046ddb3fefc"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"96ae08153e8f651753c4cbdf47652782d91e71bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"b7955adf_f8c5730c","updated":"2022-09-23 14:07:27.000000000","message":"recheck","commit_id":"751145ffb0b287ef66436bcced2f254b57a5c4af"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"69a183d0e6596a40cf5e67bf5458a79acc85d39f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"8deb8822_6cb032fd","updated":"2022-09-23 18:43:32.000000000","message":"check","commit_id":"67d0566fa642dc10bbcf8d9f5ed47af51ddbd67a"},{"author":{"_account_id":31728,"name":"Oleksii Shcherba","display_name":"Oleksii Shcherba","email":"v-oshcherba@microsoft.com","username":"mihalych"},"change_message_id":"1a10d0ceea7896cead70b959c03b92bf8d76b164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"91fd3ea6_b207a35f","updated":"2022-09-23 20:50:30.000000000","message":"recheck","commit_id":"67d0566fa642dc10bbcf8d9f5ed47af51ddbd67a"},{"author":{"_account_id":35024},"change_message_id":"cdda7ac88c4b5e03afdd8583f7f981f31258175a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"64404809_5594cb88","updated":"2022-10-03 20:40:56.000000000","message":"Just to sum up why horizon is disabled by default is that it seemed to be triggering a timeout failure with etcd, most likely based on the size/performance of the instance things were running on. We were able to test with it enabled downstream without an issue. So until we can change something we chose to disable it so the gate jobs pass.\n\nHopefully I remembered that all correctly.","commit_id":"94a8d348a9863188dc4e214831b80af2c3ba52c4"}],"horizon/Chart.yaml":[{"author":{"_account_id":35024},"change_message_id":"8712e302fd480603f57108a07a0f9089ae7cbb56","unresolved":true,"context_lines":[{"line_number":14,"context_line":"appVersion: v1.0.0"},{"line_number":15,"context_line":"description: OpenStack-Helm Horizon"},{"line_number":16,"context_line":"name: horizon"},{"line_number":17,"context_line":"version: 0.2.27"},{"line_number":18,"context_line":"home: https://docs.openstack.org/horizon/latest/"},{"line_number":19,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Horizon/OpenStack_Project_Horizon_vertical.png"},{"line_number":20,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ac02f805_cada507f","line":17,"updated":"2022-09-20 18:36:00.000000000","message":"I don\u0027t think you need this as there\u0027s no changes to anything in the horizon directory. Same for related releasenote change.","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"87ed46674746515b7afef5870cd9571f951c92a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"appVersion: v1.0.0"},{"line_number":15,"context_line":"description: OpenStack-Helm Horizon"},{"line_number":16,"context_line":"name: horizon"},{"line_number":17,"context_line":"version: 0.2.27"},{"line_number":18,"context_line":"home: https://docs.openstack.org/horizon/latest/"},{"line_number":19,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Horizon/OpenStack_Project_Horizon_vertical.png"},{"line_number":20,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"137b6c75_5689e74a","line":17,"in_reply_to":"65a4e5c2_e7e13c87","updated":"2022-10-03 16:15:04.000000000","message":"Ack","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"87ed46674746515b7afef5870cd9571f951c92a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"appVersion: v1.0.0"},{"line_number":15,"context_line":"description: OpenStack-Helm Horizon"},{"line_number":16,"context_line":"name: horizon"},{"line_number":17,"context_line":"version: 0.2.27"},{"line_number":18,"context_line":"home: https://docs.openstack.org/horizon/latest/"},{"line_number":19,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Horizon/OpenStack_Project_Horizon_vertical.png"},{"line_number":20,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"497853f5_5561bb30","line":17,"in_reply_to":"65a4e5c2_e7e13c87","updated":"2022-10-03 16:15:04.000000000","message":"Ack","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35024},"change_message_id":"3885a8243eac0a3a4a5b44a2e1795f46712cc66c","unresolved":true,"context_lines":[{"line_number":14,"context_line":"appVersion: v1.0.0"},{"line_number":15,"context_line":"description: OpenStack-Helm Horizon"},{"line_number":16,"context_line":"name: horizon"},{"line_number":17,"context_line":"version: 0.2.27"},{"line_number":18,"context_line":"home: https://docs.openstack.org/horizon/latest/"},{"line_number":19,"context_line":"icon: https://www.openstack.org/themes/openstack/images/project-mascots/Horizon/OpenStack_Project_Horizon_vertical.png"},{"line_number":20,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"65a4e5c2_e7e13c87","line":17,"in_reply_to":"ac02f805_cada507f","updated":"2022-09-21 19:45:43.000000000","message":"??","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"}],"horizon/templates/configmap-etc.yaml":[{"author":{"_account_id":35024},"change_message_id":"c22e5735b908dd8b2bbe15060ad7a8eeefc3b5eb","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{- if .Values.conf.horizon.security }}"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.horizon.security \"key\" \"security.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{{- range $key, $value :\u003d .Values.conf.horizon.policy }}"},{"line_number":31,"context_line":"  {{ printf \"%s_policy.json\" $key }}: {{ $value | toPrettyJson | b64enc }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c5eb5d6e_baf7e107","line":29,"updated":"2022-09-23 19:05:16.000000000","message":"Unnecessary blank line","commit_id":"67d0566fa642dc10bbcf8d9f5ed47af51ddbd67a"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"87ed46674746515b7afef5870cd9571f951c92a9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{- if .Values.conf.horizon.security }}"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.snippets.values_template_renderer\" (dict \"envAll\" $envAll \"template\" .Values.conf.horizon.security \"key\" \"security.conf\" \"format\" \"Secret\" ) | indent 2 }}"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"{{- range $key, $value :\u003d .Values.conf.horizon.policy }}"},{"line_number":31,"context_line":"  {{ printf \"%s_policy.json\" $key }}: {{ $value | toPrettyJson | b64enc }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"659584c2_988ee563","line":29,"in_reply_to":"c5eb5d6e_baf7e107","updated":"2022-10-03 16:15:04.000000000","message":"Ack","commit_id":"67d0566fa642dc10bbcf8d9f5ed47af51ddbd67a"}],"openstack/Chart.yaml":[{"author":{"_account_id":35024},"change_message_id":"1b04aeec83a05e0c0adbaddd08d8436193a4474f","unresolved":true,"context_lines":[{"line_number":52,"context_line":"- name: horizon"},{"line_number":53,"context_line":"  repository: file://../horizon"},{"line_number":54,"context_line":"  version: \"\u003e0.1.0\""},{"line_number":55,"context_line":"  condition: horizon.disabled"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"description: A chart for openstack helm commmon deployment items"},{"line_number":58,"context_line":"name: openstack"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"63606da7_9d5a30a5","line":55,"updated":"2022-09-30 20:03:55.000000000","message":"Is this the right way? Or should this stay horizon.enabled and we set enabled\u003dfalse in the other file.","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"543574c350639375f5fdb0c6e212d0fbb98e84c0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- name: horizon"},{"line_number":53,"context_line":"  repository: file://../horizon"},{"line_number":54,"context_line":"  version: \"\u003e0.1.0\""},{"line_number":55,"context_line":"  condition: horizon.disabled"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"description: A chart for openstack helm commmon deployment items"},{"line_number":58,"context_line":"name: openstack"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"d2a9867a_c16be7b6","line":55,"in_reply_to":"63606da7_9d5a30a5","updated":"2022-10-03 14:49:22.000000000","message":"made horizon enabled","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"}],"openstack/values_overrides/horizon/apparmor.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pod:"},{"line_number":3,"context_line":"  mandatory_access_control:"},{"line_number":4,"context_line":"    type: apparmor"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"75ffe3af_e5b3e761","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"There needs to be a \u0027horizon:\u0027 line added here, and then everything else indented. Looks like this was copied from horizon/values_overrides/apparmor.yaml and it needs that change.\n\nAt least this is what is done for the other files like nova.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pod:"},{"line_number":3,"context_line":"  mandatory_access_control:"},{"line_number":4,"context_line":"    type: apparmor"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7b061340_51339ec7","line":1,"in_reply_to":"75ffe3af_e5b3e761","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35024},"change_message_id":"e31eba307ddd3df59f6720b83517a99807b5dad4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pod:"},{"line_number":3,"context_line":"  mandatory_access_control:"},{"line_number":4,"context_line":"    type: apparmor"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4180d65b_8c56a603","line":1,"updated":"2022-09-22 20:41:42.000000000","message":"Looks to be missing the \"horizon:\" stanza now","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pod:"},{"line_number":3,"context_line":"  mandatory_access_control:"},{"line_number":4,"context_line":"    type: apparmor"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9b044f3d_6c144881","line":1,"in_reply_to":"4180d65b_8c56a603","updated":"2022-09-22 21:29:58.000000000","message":"thank you \nadded","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"}],"openstack/values_overrides/horizon/netpol.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"manifests:"},{"line_number":3,"context_line":"  network_policy: true"},{"line_number":4,"context_line":"network_policy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"40f11d31_4d29d535","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"manifests:"},{"line_number":3,"context_line":"  network_policy: true"},{"line_number":4,"context_line":"network_policy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6aed2863_b1092e5c","line":1,"in_reply_to":"40f11d31_4d29d535","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/tls.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"network:"},{"line_number":3,"context_line":"  dashboard:"},{"line_number":4,"context_line":"    ingress:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9b928b89_fd8d60ea","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"network:"},{"line_number":3,"context_line":"  dashboard:"},{"line_number":4,"context_line":"    ingress:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"27ac3695_5ddfe837","line":1,"in_reply_to":"9b928b89_fd8d60ea","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/train-ubuntu_bionic.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:train-ubuntu_bionic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"319aa87e_45a6dd60","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:train-ubuntu_bionic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9e751be5_73eaeafd","line":1,"in_reply_to":"319aa87e_45a6dd60","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/ussuri-ubuntu_bionic.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:ussuri-ubuntu_bionic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e7c70848_d36506ce","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:ussuri-ubuntu_bionic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b5359006_434cb3fd","line":1,"in_reply_to":"e7c70848_d36506ce","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/victoria-ubuntu_focal.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:victoria-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"84fe4204_f4c1b9c1","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:victoria-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"653a0102_846df91f","line":1,"in_reply_to":"84fe4204_f4c1b9c1","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/wallaby-ubuntu_focal.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:wallaby-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fd47a1ef_97766eea","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:wallaby-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"410cf6c6_b1fc05b6","line":1,"in_reply_to":"fd47a1ef_97766eea","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/xena-ubuntu_focal.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:xena-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b2bb767a_b5f51de1","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:xena-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f7ac5210_2a91d292","line":1,"in_reply_to":"b2bb767a_b5f51de1","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"openstack/values_overrides/horizon/yoga-ubuntu_focal.yaml":[{"author":{"_account_id":35024},"change_message_id":"12ce790c8a53bf7ce6a40ba78891d6dff0d01fd7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:yoga-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8679568b_6e31c8b9","line":1,"updated":"2022-09-09 20:53:29.000000000","message":"Add \u0027horizon:\u0027 and indent like others.","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    db_init: docker.io/openstackhelm/heat:yoga-ubuntu_focal"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d3e20b83_d8f303df","line":1,"in_reply_to":"8679568b_6e31c8b9","updated":"2022-09-22 12:34:28.000000000","message":"added \u0027horizon:\u0027 line and indented everything else","commit_id":"afa8b8c75d1efd6c79929fa4fe4fa8a9ecb8e6b9"}],"releasenotes/notes/horizon.yaml":[{"author":{"_account_id":35024},"change_message_id":"e31eba307ddd3df59f6720b83517a99807b5dad4","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  - 0.2.24 Remove blank lines in logo configmap"},{"line_number":37,"context_line":"  - 0.2.25 Added OCI registry authentication"},{"line_number":38,"context_line":"  - 0.2.26 Support SSL identity endpoint"},{"line_number":39,"context_line":"  - 0.2.27 Added in default openstack components list"},{"line_number":40,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"09923a08_4b5147d2","line":39,"updated":"2022-09-22 20:41:42.000000000","message":"Not needed, might cause a lint error","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  - 0.2.24 Remove blank lines in logo configmap"},{"line_number":37,"context_line":"  - 0.2.25 Added OCI registry authentication"},{"line_number":38,"context_line":"  - 0.2.26 Support SSL identity endpoint"},{"line_number":39,"context_line":"  - 0.2.27 Added in default openstack components list"},{"line_number":40,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"b4835d10_9772be94","line":39,"in_reply_to":"09923a08_4b5147d2","updated":"2022-09-22 21:29:58.000000000","message":"removed 0.2.27","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"}],"tools/gate/tests/validate-umbrella-upgrade-config-changes-do-not-update-other-components.sh":[{"author":{"_account_id":35024},"change_message_id":"8712e302fd480603f57108a07a0f9089ae7cbb56","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  if [ ! -z $3 ];then"},{"line_number":21,"context_line":"    local timeout\u003d$3"},{"line_number":22,"context_line":"  else"},{"line_number":23,"context_line":"    local timeout\u003d0"},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  before_apps_list\u003d\"$(mktemp)\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"f4b61118_2f2c7094","line":23,"updated":"2022-09-20 18:36:00.000000000","message":"Would this override whatever the default timeout is in the called script? Oh, it actually will ignore if zero, so I guess we got lucky there.\n\nBut it\u0027s really unnecessary, could just declare:\n\nlocal timeout\u003d\"$3\"\n\nand if it\u0027s not passed that\u0027s fine as nothing will be passed to wait-for-pods.sh","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  if [ ! -z $3 ];then"},{"line_number":21,"context_line":"    local timeout\u003d$3"},{"line_number":22,"context_line":"  else"},{"line_number":23,"context_line":"    local timeout\u003d0"},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  before_apps_list\u003d\"$(mktemp)\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"b252d88a_d61d4cf5","line":23,"in_reply_to":"f46c9785_51382678","updated":"2022-09-22 21:29:58.000000000","message":"Done","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35024},"change_message_id":"3885a8243eac0a3a4a5b44a2e1795f46712cc66c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  if [ ! -z $3 ];then"},{"line_number":21,"context_line":"    local timeout\u003d$3"},{"line_number":22,"context_line":"  else"},{"line_number":23,"context_line":"    local timeout\u003d0"},{"line_number":24,"context_line":"  fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  before_apps_list\u003d\"$(mktemp)\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"f46c9785_51382678","line":23,"in_reply_to":"f4b61118_2f2c7094","updated":"2022-09-21 19:45:43.000000000","message":"??","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35024},"change_message_id":"8712e302fd480603f57108a07a0f9089ae7cbb56","unresolved":true,"context_lines":[{"line_number":78,"context_line":"validate_only_expected_application_changes \"openvswitch\" \"--set openvswitch.pod.user.nova.uid\u003d42425\""},{"line_number":79,"context_line":"validate_only_expected_application_changes \"placement\" \"--set placement.conf.logging.logger_placement.level\u003dWARN\""},{"line_number":80,"context_line":"validate_only_expected_application_changes \"rabbitmq\" \"--set rabbitmq.conf.rabbitmq.log.file.level\u003dinfo\""},{"line_number":81,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.debug\u003dTrue\" \"1800\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"f9e20a95_647a3d13","line":81,"updated":"2022-09-20 18:36:00.000000000","message":"Should put this back where it was in previous versions to keep the list alphabetical.","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"32f104a321cad79d4d6dedeba4bc4a8ee100c052","unresolved":false,"context_lines":[{"line_number":78,"context_line":"validate_only_expected_application_changes \"openvswitch\" \"--set openvswitch.pod.user.nova.uid\u003d42425\""},{"line_number":79,"context_line":"validate_only_expected_application_changes \"placement\" \"--set placement.conf.logging.logger_placement.level\u003dWARN\""},{"line_number":80,"context_line":"validate_only_expected_application_changes \"rabbitmq\" \"--set rabbitmq.conf.rabbitmq.log.file.level\u003dinfo\""},{"line_number":81,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.debug\u003dTrue\" \"1800\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ca27ab50_4cfdfbce","line":81,"in_reply_to":"f9e20a95_647a3d13","updated":"2022-09-22 12:34:28.000000000","message":"replaced it back as in previous versions","commit_id":"86ed1560c05d7c0d4acba33c78d1ded1b9c6da7d"},{"author":{"_account_id":35024},"change_message_id":"3885a8243eac0a3a4a5b44a2e1795f46712cc66c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"  fi"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.debug\u003dTrue\" \"1800\""},{"line_number":69,"context_line":"validate_only_expected_application_changes \"glance\" \"--set glance.conf.logging.logger_glance.level\u003dWARN\""},{"line_number":70,"context_line":"validate_only_expected_application_changes \"heat\" \"--set heat.conf.logging.logger_heat.level\u003dWARN\""},{"line_number":71,"context_line":"validate_only_expected_application_changes \"keystone\" \"--set keystone.conf.logging.logger_keystone.level\u003dWARN\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"a1b8fbaf_377963ec","line":68,"updated":"2022-09-21 19:45:43.000000000","message":"nit: list is alphabetical","commit_id":"cb6d4e5c62582f9fd4b8ee1eace5dcadd79a4d7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  fi"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.debug\u003dTrue\" \"1800\""},{"line_number":69,"context_line":"validate_only_expected_application_changes \"glance\" \"--set glance.conf.logging.logger_glance.level\u003dWARN\""},{"line_number":70,"context_line":"validate_only_expected_application_changes \"heat\" \"--set heat.conf.logging.logger_heat.level\u003dWARN\""},{"line_number":71,"context_line":"validate_only_expected_application_changes \"keystone\" \"--set keystone.conf.logging.logger_keystone.level\u003dWARN\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"bd3dd5df_a1acad0b","line":68,"in_reply_to":"a1b8fbaf_377963ec","updated":"2022-09-22 21:29:58.000000000","message":"Done","commit_id":"cb6d4e5c62582f9fd4b8ee1eace5dcadd79a4d7d"},{"author":{"_account_id":35024},"change_message_id":"91d57bc857b6f77bd4ff8bf7a761a5e4b14fd614","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":"#  if [ ! -z $3 ]; then"},{"line_number":20,"context_line":"#    local timeout\u003d$3"},{"line_number":21,"context_line":"#  else"}],"source_content_type":"text/x-sh","patch_set":13,"id":"54ea4e1b_30192d7e","line":18,"updated":"2022-09-21 21:40:13.000000000","message":"You need to have this here else this script will probably throw an error:\n\n  local timeout\u003d\"$3\"","commit_id":"e564bf547f9925365ab1f38a7016f40309612377"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":"#  if [ ! -z $3 ]; then"},{"line_number":20,"context_line":"#    local timeout\u003d$3"},{"line_number":21,"context_line":"#  else"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9fcd939b_87eb6d86","line":18,"in_reply_to":"54ea4e1b_30192d7e","updated":"2022-09-22 21:29:58.000000000","message":"Done","commit_id":"e564bf547f9925365ab1f38a7016f40309612377"},{"author":{"_account_id":35024},"change_message_id":"e31eba307ddd3df59f6720b83517a99807b5dad4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":"  local timeout\u003d\"$3\""},{"line_number":20,"context_line":"#  if [ ! -z $3 ]; then"},{"line_number":21,"context_line":"#   local timeout\u003d$3"},{"line_number":22,"context_line":"#  else"}],"source_content_type":"text/x-sh","patch_set":15,"id":"11c2b157_3c502066","line":19,"updated":"2022-09-22 20:41:42.000000000","message":"There is actually no caller specifying this any more, still required?","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":"  local timeout\u003d\"$3\""},{"line_number":20,"context_line":"#  if [ ! -z $3 ]; then"},{"line_number":21,"context_line":"#   local timeout\u003d$3"},{"line_number":22,"context_line":"#  else"}],"source_content_type":"text/x-sh","patch_set":15,"id":"e1a8ccf6_e466f1f7","line":19,"in_reply_to":"11c2b157_3c502066","updated":"2022-09-22 21:29:58.000000000","message":"removed","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35024},"change_message_id":"e31eba307ddd3df59f6720b83517a99807b5dad4","unresolved":true,"context_lines":[{"line_number":21,"context_line":"#   local timeout\u003d$3"},{"line_number":22,"context_line":"#  else"},{"line_number":23,"context_line":"#  local timeout\u003d0"},{"line_number":24,"context_line":"#  fi"},{"line_number":25,"context_line":"  before_apps_list\u003d\"$(mktemp)\""},{"line_number":26,"context_line":"  after_apps_list\u003d\"$(mktemp)\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"ba5cc070_44096534","line":24,"updated":"2022-09-22 20:41:42.000000000","message":"This commented code can be removed","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   local timeout\u003d$3"},{"line_number":22,"context_line":"#  else"},{"line_number":23,"context_line":"#  local timeout\u003d0"},{"line_number":24,"context_line":"#  fi"},{"line_number":25,"context_line":"  before_apps_list\u003d\"$(mktemp)\""},{"line_number":26,"context_line":"  after_apps_list\u003d\"$(mktemp)\""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":15,"id":"e41c1250_6f0f7929","line":24,"in_reply_to":"ba5cc070_44096534","updated":"2022-09-22 21:29:58.000000000","message":"removed","commit_id":"db5d4e4879500da028b5df348730f34ed43ab58a"},{"author":{"_account_id":35024},"change_message_id":"0d1b4ecf3c734937b8e0eff871987c3ae9c79a26","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    ${config_change} \\"},{"line_number":37,"context_line":"    --wait --timeout 20m0s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack $timeout"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  kubectl get daemonsets,deployments,statefulsets \\"},{"line_number":42,"context_line":"    --namespace openstack \\"}],"source_content_type":"text/x-sh","patch_set":17,"id":"10bc15f0_501b5bb3","line":39,"range":{"start_line":39,"start_character":55,"end_line":39,"end_character":63},"updated":"2022-09-22 21:57:55.000000000","message":"$timeout is undefined now","commit_id":"a937b6f91e0d4c319a5e9facda1bc046ddb3fefc"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"d4c4bdda1cc2117955435a9da5b456aa3f674893","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    ${config_change} \\"},{"line_number":37,"context_line":"    --wait --timeout 20m0s"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack $timeout"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  kubectl get daemonsets,deployments,statefulsets \\"},{"line_number":42,"context_line":"    --namespace openstack \\"}],"source_content_type":"text/x-sh","patch_set":17,"id":"8f3645d5_09e18161","line":39,"range":{"start_line":39,"start_character":55,"end_line":39,"end_character":63},"in_reply_to":"10bc15f0_501b5bb3","updated":"2022-09-24 04:59:20.000000000","message":"removed","commit_id":"a937b6f91e0d4c319a5e9facda1bc046ddb3fefc"},{"author":{"_account_id":35024},"change_message_id":"c22e5735b908dd8b2bbe15060ad7a8eeefc3b5eb","unresolved":true,"context_lines":[{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  before_apps_list\u003d\"$(mktemp)\""},{"line_number":21,"context_line":"  after_apps_list\u003d\"$(mktemp)\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"5451490f_45492f42","side":"PARENT","line":19,"updated":"2022-09-23 19:05:16.000000000","message":"Unnecessary line removal","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"543574c350639375f5fdb0c6e212d0fbb98e84c0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"validate_only_expected_application_changes () {"},{"line_number":17,"context_line":"  local app_name\u003d\"$1\""},{"line_number":18,"context_line":"  local config_change\u003d\"$2\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  before_apps_list\u003d\"$(mktemp)\""},{"line_number":21,"context_line":"  after_apps_list\u003d\"$(mktemp)\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-sh","patch_set":26,"id":"eb76ed5b_b2c1a9bb","side":"PARENT","line":19,"in_reply_to":"5451490f_45492f42","updated":"2022-10-03 14:49:22.000000000","message":"initially removed because of whitespaces error, but added line again","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35024},"change_message_id":"1b04aeec83a05e0c0adbaddd08d8436193a4474f","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    --namespace openstack \\"},{"line_number":31,"context_line":"    -l \"application\u003d$app_name\" \\"},{"line_number":32,"context_line":"    --wait"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  helm upgrade openstack ./openstack \\"},{"line_number":35,"context_line":"    --namespace openstack \\"},{"line_number":36,"context_line":"    --reuse-values \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"225f3aff_6b952189","side":"PARENT","line":33,"updated":"2022-09-30 20:03:55.000000000","message":"Unnecessary line removal","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"543574c350639375f5fdb0c6e212d0fbb98e84c0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    --namespace openstack \\"},{"line_number":31,"context_line":"    -l \"application\u003d$app_name\" \\"},{"line_number":32,"context_line":"    --wait"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  helm upgrade openstack ./openstack \\"},{"line_number":35,"context_line":"    --namespace openstack \\"},{"line_number":36,"context_line":"    --reuse-values \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"062b82b0_3a9b2d78","side":"PARENT","line":33,"in_reply_to":"225f3aff_6b952189","updated":"2022-10-03 14:49:22.000000000","message":"removed because of whitespaces error, but added line again","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35024},"change_message_id":"1b04aeec83a05e0c0adbaddd08d8436193a4474f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    --reuse-values \\"},{"line_number":37,"context_line":"    ${config_change} \\"},{"line_number":38,"context_line":"    --wait"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  kubectl get daemonsets,deployments,statefulsets \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"9c0a64f4_97d34dbd","side":"PARENT","line":39,"updated":"2022-09-30 20:03:55.000000000","message":"Unnecessary line removal","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"543574c350639375f5fdb0c6e212d0fbb98e84c0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    --reuse-values \\"},{"line_number":37,"context_line":"    ${config_change} \\"},{"line_number":38,"context_line":"    --wait"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  ./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  kubectl get daemonsets,deployments,statefulsets \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"2616162e_143a3581","side":"PARENT","line":39,"in_reply_to":"9c0a64f4_97d34dbd","updated":"2022-10-03 14:49:22.000000000","message":"removed because of whitespaces error, but added line again","commit_id":"08cc418ae4b8386db3c2d328d1c2967e290f3cf3"},{"author":{"_account_id":35024},"change_message_id":"1b04aeec83a05e0c0adbaddd08d8436193a4474f","unresolved":true,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"validate_only_expected_application_changes \"glance\" \"--set glance.conf.logging.logger_glance.level\u003dWARN\""},{"line_number":63,"context_line":"validate_only_expected_application_changes \"heat\" \"--set heat.conf.logging.logger_heat.level\u003dWARN\""},{"line_number":64,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.log_level\u003dWARN\""},{"line_number":65,"context_line":"validate_only_expected_application_changes \"keystone\" \"--set keystone.conf.logging.logger_keystone.level\u003dWARN\""},{"line_number":66,"context_line":"validate_only_expected_application_changes \"libvirt\" \"--set libvirt.conf.libvirt.log_level\u003d2\""},{"line_number":67,"context_line":"validate_only_expected_application_changes \"mariadb\" \"--set mariadb.conf.database.config_override\u003d[mysqld]\\nlog_warnings\u003d3\""}],"source_content_type":"text/x-sh","patch_set":50,"id":"4e0fcb93_980f33df","line":64,"updated":"2022-09-30 20:03:55.000000000","message":"Since it\u0027s not enabled do we want this?","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"543574c350639375f5fdb0c6e212d0fbb98e84c0","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"validate_only_expected_application_changes \"glance\" \"--set glance.conf.logging.logger_glance.level\u003dWARN\""},{"line_number":63,"context_line":"validate_only_expected_application_changes \"heat\" \"--set heat.conf.logging.logger_heat.level\u003dWARN\""},{"line_number":64,"context_line":"validate_only_expected_application_changes \"horizon\" \"--set horizon.conf.horizon.local_settings.config.log_level\u003dWARN\""},{"line_number":65,"context_line":"validate_only_expected_application_changes \"keystone\" \"--set keystone.conf.logging.logger_keystone.level\u003dWARN\""},{"line_number":66,"context_line":"validate_only_expected_application_changes \"libvirt\" \"--set libvirt.conf.libvirt.log_level\u003d2\""},{"line_number":67,"context_line":"validate_only_expected_application_changes \"mariadb\" \"--set mariadb.conf.database.config_override\u003d[mysqld]\\nlog_warnings\u003d3\""}],"source_content_type":"text/x-sh","patch_set":50,"id":"22fc6254_c4903f29","line":64,"in_reply_to":"4e0fcb93_980f33df","updated":"2022-10-03 14:49:22.000000000","message":"Commented this line","commit_id":"300267e04f54efef05c4b6d51340f72af2d791dc"}],"zuul.d/jobs-openstack-helm.yaml":[{"author":{"_account_id":35024},"change_message_id":"3885a8243eac0a3a4a5b44a2e1795f46712cc66c","unresolved":true,"context_lines":[{"line_number":177,"context_line":"      - ^nova/.*$"},{"line_number":178,"context_line":"      - ^openstack/.*$"},{"line_number":179,"context_line":"      - ^placement/.*$"},{"line_number":180,"context_line":"      - ^horizon/.*$"},{"line_number":181,"context_line":"      - ^tools/deployment/common/force-cronjob-run.sh$"},{"line_number":182,"context_line":"      - ^tools/deployment/common/install-packages.sh$"},{"line_number":183,"context_line":"      - ^tools/deployment/common/setup-client.sh$"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cec66799_d3d20424","line":180,"updated":"2022-09-21 19:45:43.000000000","message":"nit: list is alphabetical","commit_id":"cb6d4e5c62582f9fd4b8ee1eace5dcadd79a4d7d"},{"author":{"_account_id":35266,"name":"Sunil Emmadi","email":"v-semmadi@microsoft.com","username":"sunile"},"change_message_id":"c40f2cf6941d33dcfa2145ddf4f7345e97a704d6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"      - ^nova/.*$"},{"line_number":178,"context_line":"      - ^openstack/.*$"},{"line_number":179,"context_line":"      - ^placement/.*$"},{"line_number":180,"context_line":"      - ^horizon/.*$"},{"line_number":181,"context_line":"      - ^tools/deployment/common/force-cronjob-run.sh$"},{"line_number":182,"context_line":"      - ^tools/deployment/common/install-packages.sh$"},{"line_number":183,"context_line":"      - ^tools/deployment/common/setup-client.sh$"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"42cccb69_f367c4ba","line":180,"in_reply_to":"cec66799_d3d20424","updated":"2022-09-22 21:29:58.000000000","message":"Done","commit_id":"cb6d4e5c62582f9fd4b8ee1eace5dcadd79a4d7d"}]}