)]}'
{"id":"openstack%2Fopenstack-helm~879410","triplet_id":"openstack%2Fopenstack-helm~master~Ic35c1b4bb3c4d1cff7b633e6f69d5269cc23eeef","project":"openstack/openstack-helm","branch":"master","topic":"story/2010686","attention_set":{},"removed_from_attention_set":{"4428":{"account":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"last_update":"2023-04-05 04:28:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic35c1b4bb3c4d1cff7b633e6f69d5269cc23eeef","subject":"fix(neutron): Don\u0027t check tcp socket state for ovn metadata agent","status":"MERGED","created":"2023-04-04 02:42:03.000000000","updated":"2023-04-05 04:29:25.000000000","submitted":"2023-04-05 04:28:07.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"879410-story/2010686","meta_rev_id":"56eccc49ce84d0df35ebb2b979a147263485e297","_number":879410,"virtual_id_number":879410,"owner":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-04-05 04:28:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2023-04-05 03:16:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-04-04 16:13:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2023-04-05 03:16:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-04-04 04:07:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-04-04 16:13:11.000000000","updated_by":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2023-04-05 03:16:08.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"}],"messages":[{"id":"f1d4ff242c11ae093cde0475204743d361187d25","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"date":"2023-04-04 02:42:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03a0d9d1a3b41792d979c61db9afb98f7ae303ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-04 04:07:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/2822498815af48849cdc58d30b83cbc3\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a53f0277ba404740b91b7d1250fc95f4 : SUCCESS in 5m 39s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/e13313dde6c84c58997055bd5928b3bd : FAILURE in 2m 07s\n- openstack-helm-bandit https://zuul.opendev.org/t/openstack/build/ae0198a3b4ef434981efe649024bbce7 : SUCCESS in 13m 50s\n- openstack-helm-compute-kit-victoria-ubuntu_focal https://zuul.opendev.org/t/openstack/build/de539d6105c44b9e8a06594cd6a302b5 : SUCCESS in 45m 19s\n- openstack-helm-compute-kit-victoria-ubuntu_focal-umbrella https://zuul.opendev.org/t/openstack/build/fb34a52aec6845509d8da6d38c8e7d88 : SUCCESS in 1h 19m 31s\n- openstack-helm-compute-kit-wallaby-ubuntu_focal https://zuul.opendev.org/t/openstack/build/3d88fba89de64a3ba7388c08ea8ff899 : SUCCESS in 58m 13s\n- openstack-helm-compute-kit-xena-ubuntu_focal https://zuul.opendev.org/t/openstack/build/79665c47999d480abc74a0e28f0590e9 : SUCCESS in 57m 23s","accounts_in_message":[],"_revision_number":1},{"id":"e443079f31bf26238fd3e0c5edb6249097852f8f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"date":"2023-04-04 07:37:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4c85679509773fbd99b1e0ee4e3165ea039c2568","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-04 09:26:08.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/29c3221df687454891aea64ee75f2fb2\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a1ba66b55cd949c9a1957f97a2a246bd : SUCCESS in 5m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9c204403ab504834aa3e9f73ad53f793 : SUCCESS in 3m 32s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/626eabcf4bb1427aac7f7ee879669e37 : SUCCESS in 3m 13s\n- openstack-helm-bandit https://zuul.opendev.org/t/openstack/build/3c25d0a2fa1441dcb9e6c31df236ac12 : SUCCESS in 13m 46s\n- openstack-helm-compute-kit-victoria-ubuntu_focal https://zuul.opendev.org/t/openstack/build/f21a6cc742344d399e43fdcdecbf8a27 : SUCCESS in 57m 21s\n- openstack-helm-compute-kit-victoria-ubuntu_focal-umbrella https://zuul.opendev.org/t/openstack/build/dc388d5acb294c298ba58c809427d717 : SUCCESS in 1h 41m 51s\n- openstack-helm-compute-kit-wallaby-ubuntu_focal https://zuul.opendev.org/t/openstack/build/7fcfdcb90b5c4a688b369b4cca945dec : SUCCESS in 1h 00m 16s\n- openstack-helm-compute-kit-xena-ubuntu_focal https://zuul.opendev.org/t/openstack/build/789d7edf96974884a92a49e46c175417 : SUCCESS in 55m 59s","accounts_in_message":[],"_revision_number":2},{"id":"44d49f0a9c4619f7ea9c8947de96ada62832c6b6","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2023-04-04 16:13:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"19c13539c02abb0ebafb539545d8c19a1bc5cdab","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2023-04-05 03:16:08.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b4b01bd6e1d1bb0a91d78e35134a38fc3786a4d8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-05 03:16:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ddf38aa679ad2bc8a7e11713bab75afd0ce6d5da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-05 04:28:07.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bf51e12f8e4f4f17872466c6d60a0425\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9e0dbc5ac14a4fb7b2519e6e894e8d87 : SUCCESS in 5m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6997f408e39c47b7b73c07add6429306 : SUCCESS in 3m 35s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/929c58fabdb646f5882f147bb3cb4014 : SUCCESS in 3m 38s\n- openstack-helm-tls https://zuul.opendev.org/t/openstack/build/d19a4468038d41a69d2ed6e40d718e13 : SUCCESS in 1h 04m 14s\n- openstack-helm-compute-kit-wallaby-ubuntu_focal https://zuul.opendev.org/t/openstack/build/e4afc142d8ec403a8e275ef73bf6afb7 : SUCCESS in 50m 03s","accounts_in_message":[],"_revision_number":2},{"id":"d1950c19f9674365cab8b86b8cf0ca55184698b9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-05 04:28:07.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"56eccc49ce84d0df35ebb2b979a147263485e297","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-04-05 04:29:25.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cde716c6d236493fa59fedb19a9d3e1c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/98c19cbb19a442e19aef4bafa4ea933d : SUCCESS in 59s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/8b94838302c34f7db8b09a5ec6684d88 : SUCCESS in 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"84a6df2e5d3a1c9feef9523b3ceaf3f21604e8ef","revisions":{"e556ab3feeb651dd3a02abfd85fee37a04fcb693":{"kind":"REWORK","_number":1,"created":"2023-04-04 02:42:03.000000000","uploader":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"ref":"refs/changes/10/879410/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/10/879410/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/1"}}},"commit":{"parents":[{"commit":"c4e00077179d7af44c65a8f9775a7fd4aa852c17","subject":"Merge \"fix: vnc access\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c4e00077179d7af44c65a8f9775a7fd4aa852c17"}]}],"author":{"name":"liyingjun","email":"liyingjun1988@gmail.com","date":"2023-04-04 02:27:45.000000000","tz":0},"committer":{"name":"liyingjun","email":"liyingjun1988@gmail.com","date":"2023-04-04 02:41:43.000000000","tz":0},"subject":"fix(neutron): Don\u0027t check tcp socket state for ovn metadata agent","message":"fix(neutron): Don\u0027t check tcp socket state for ovn metadata agent\n\nWhen using ovn as neutron plugin, the health probe failed with \"RabbitMQ\nsockets not Established\" error, because it still check TCP connection to\nRabbitmq while OVN metadata agent doesn\u0027t use Rabbitmq. This patch adds\na condition check to avoid tcp socket state check for ovn metadata agent.\n\nStory: #2010686\nChange-Id: Ic35c1b4bb3c4d1cff7b633e6f69d5269cc23eeef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e556ab3feeb651dd3a02abfd85fee37a04fcb693"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e556ab3feeb651dd3a02abfd85fee37a04fcb693"}]},"branch":"refs/heads/master"},"84a6df2e5d3a1c9feef9523b3ceaf3f21604e8ef":{"kind":"REWORK","_number":2,"created":"2023-04-04 07:37:32.000000000","uploader":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"ref":"refs/changes/10/879410/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/10/879410/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/10/879410/2"}}},"commit":{"parents":[{"commit":"c4e00077179d7af44c65a8f9775a7fd4aa852c17","subject":"Merge \"fix: vnc access\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/c4e00077179d7af44c65a8f9775a7fd4aa852c17"}]}],"author":{"name":"liyingjun","email":"liyingjun1988@gmail.com","date":"2023-04-04 02:27:45.000000000","tz":0},"committer":{"name":"liyingjun","email":"liyingjun1988@gmail.com","date":"2023-04-04 07:37:07.000000000","tz":0},"subject":"fix(neutron): Don\u0027t check tcp socket state for ovn metadata agent","message":"fix(neutron): Don\u0027t check tcp socket state for ovn metadata agent\n\nWhen using ovn as neutron plugin, the health probe failed with \"RabbitMQ\nsockets not Established\" error, because it still check TCP connection to\nRabbitmq while OVN metadata agent doesn\u0027t use Rabbitmq. This patch adds\na condition check to avoid tcp socket state check for ovn metadata agent.\n\nStory: #2010686\nChange-Id: Ic35c1b4bb3c4d1cff7b633e6f69d5269cc23eeef\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/84a6df2e5d3a1c9feef9523b3ceaf3f21604e8ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/84a6df2e5d3a1c9feef9523b3ceaf3f21604e8ef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}