)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8104,"name":"June Yi","display_name":"gochist","email":"june.yi@samsung.com","username":"juneyi"},"change_message_id":"dd2f3ebfa353686fe6215dcd698ee5eb04f9b769","unresolved":true,"context_lines":[{"line_number":7,"context_line":"title: Update oslo_messaging_RPCClient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo_messaging.RPCClient is currently deprecated."},{"line_number":10,"context_line":"This change moves the health prove to use get_rpc_client instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"story: 2010766"},{"line_number":13,"context_line":"task: 48076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"43fdaafe_a0d33aea","line":10,"updated":"2023-05-24 00:49:21.000000000","message":"type: s/prove/probe/","commit_id":"9704acc7b44fe440c0370384e29927879f8c6b42"},{"author":{"_account_id":35655,"name":"moontaek.rho","display_name":"moontaek.rho","email":"moontaek.rho@samsung.com","username":"moontaek.rho"},"change_message_id":"4d8a61e90c4b15e4c9aa27fa8892379b5255e83b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"title: Update oslo_messaging_RPCClient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"oslo_messaging.RPCClient is currently deprecated."},{"line_number":10,"context_line":"This change moves the health prove to use get_rpc_client instead."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"story: 2010766"},{"line_number":13,"context_line":"task: 48076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"91cde06d_86a07982","line":10,"in_reply_to":"43fdaafe_a0d33aea","updated":"2023-05-24 08:57:25.000000000","message":"Done","commit_id":"9704acc7b44fe440c0370384e29927879f8c6b42"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c2bd664c07865d9a7993e6891bb1f0cd296e6ee7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b858d82f_991eb2bc","updated":"2023-05-23 19:47:56.000000000","message":"You have also update the nova/Chart.yaml and releasenotes/notes/nova.yaml files.","commit_id":"ef2f6a67411e5476b0cb6e8cae4ff356ddea0e82"}],"nova/templates/bin/_health-probe.py.tpl":[{"author":{"_account_id":8104,"name":"June Yi","display_name":"gochist","email":"june.yi@samsung.com","username":"juneyi"},"change_message_id":"dd2f3ebfa353686fe6215dcd698ee5eb04f9b769","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                          timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                          retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"},{"line_number":72,"context_line":"                    \u0027ping\u0027,"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"6f1d8b13_e6622fd9","line":69,"updated":"2023-05-24 00:49:21.000000000","message":"You need to keep the coding style by adding indentation on next lines.","commit_id":"9704acc7b44fe440c0370384e29927879f8c6b42"},{"author":{"_account_id":35655,"name":"moontaek.rho","display_name":"moontaek.rho","email":"moontaek.rho@samsung.com","username":"moontaek.rho"},"change_message_id":"4d8a61e90c4b15e4c9aa27fa8892379b5255e83b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                          timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                          retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"},{"line_number":72,"context_line":"                    \u0027ping\u0027,"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"b3122b05_73878df8","line":69,"in_reply_to":"6f1d8b13_e6622fd9","updated":"2023-05-24 08:57:25.000000000","message":"Done","commit_id":"9704acc7b44fe440c0370384e29927879f8c6b42"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5179dfe265f6f0fd4cae06a54927fd12880d9c20","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            server\u003d_get_hostname(service_queue_name, use_fqdn),"},{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                               timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                               retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"6fd772ef_35bc6aab","line":68,"updated":"2023-05-24 19:30:46.000000000","message":"This helper method is only available in 2023.1. I don\u0027t understand why all these compute-kit jobs for releases older than antelope did not fail.\n\nCan you please delve into this? Openstack-helm does not follow the release/branching model that other Openstack projects use. So our charts including health probe scripts are supposed to support multiple Openstack releases (at the moment these are victoria, wallaby, xena, yoga). Can you please make it fallback to RPCClient if get_rpc_client is not available?","commit_id":"ec18722218ac18a736bae28e5b310621d3b44c34"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"971bf9ffe7e927d26022e8fe0be60a34ee08f0d7","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            server\u003d_get_hostname(service_queue_name, use_fqdn),"},{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                               timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                               retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"38abc84a_5982e3d2","line":68,"updated":"2023-05-24 20:17:25.000000000","message":"```\n$ docker run -it --rm openstackhelm/nova:yoga-ubuntu_focal \nroot@134dafeae131:/# python -c \"from oslo_messaging import get_rpc_client\"\nTraceback (most recent call last):\n  File \"\u003cstring\u003e\", line 1, in \u003cmodule\u003e\nImportError: cannot import name \u0027get_rpc_client\u0027 from \u0027oslo_messaging\u0027 (/var/lib/openstack/lib/python3.8/site-packages/oslo_messaging/__init__.py)\n\n```","commit_id":"ec18722218ac18a736bae28e5b310621d3b44c34"},{"author":{"_account_id":35655,"name":"moontaek.rho","display_name":"moontaek.rho","email":"moontaek.rho@samsung.com","username":"moontaek.rho"},"change_message_id":"ee41a12ce5715ec61f2562442e78cce9eaee0a91","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            server\u003d_get_hostname(service_queue_name, use_fqdn),"},{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                               timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                               retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"82340729_f2cd3ae5","line":68,"in_reply_to":"38abc84a_5982e3d2","updated":"2023-05-25 12:57:38.000000000","message":"Done","commit_id":"ec18722218ac18a736bae28e5b310621d3b44c34"},{"author":{"_account_id":35655,"name":"moontaek.rho","display_name":"moontaek.rho","email":"moontaek.rho@samsung.com","username":"moontaek.rho"},"change_message_id":"ee41a12ce5715ec61f2562442e78cce9eaee0a91","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            server\u003d_get_hostname(service_queue_name, use_fqdn),"},{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":69,"context_line":"                                               timeout\u003drpc_timeout,"},{"line_number":70,"context_line":"                                               retry\u003drpc_retries)"},{"line_number":71,"context_line":"        client.call(context.RequestContext(),"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"4021a0e3_54ef1761","line":68,"in_reply_to":"6fd772ef_35bc6aab","updated":"2023-05-25 12:57:38.000000000","message":"Done","commit_id":"ec18722218ac18a736bae28e5b310621d3b44c34"},{"author":{"_account_id":8104,"name":"June Yi","display_name":"gochist","email":"june.yi@samsung.com","username":"juneyi"},"change_message_id":"be40076085895301ba1468a53cffef00f892eae9","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            from oslo_messaging import get_rpc_client"},{"line_number":70,"context_line":"            client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":71,"context_line":"                                                   timeout\u003drpc_timeout,"},{"line_number":72,"context_line":"                                                   retry\u003drpc_retries)"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"975ff67c_2ba6a8a6","line":69,"updated":"2023-05-25 10:06:32.000000000","message":"Since the `olso_messaging` module is already imported into the namespace, I think it would be better to check it using the `hasattr` function rather than importing `get_rpc_client` in another namespace.\n\n```\n$ docker run -it --rm openstackhelm/nova:yoga-ubuntu_focal \nroot@6ee2145f44cc:/# python                                     \nPython 3.8.10 (default, Mar 15 2022, 12:22:08) \n[GCC 9.4.0] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e import oslo_messaging\n\u003e\u003e\u003e hasattr(oslo_messaging, \u0027get_rpc_client\u0027)\nFalse\n```","commit_id":"a2ca4265c133dcf7cf2c22bdc2acc7fb08c29475"},{"author":{"_account_id":35655,"name":"moontaek.rho","display_name":"moontaek.rho","email":"moontaek.rho@samsung.com","username":"moontaek.rho"},"change_message_id":"d29e29ca2512d3fb0d05ec0701a64e222a6734f2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            from oslo_messaging import get_rpc_client"},{"line_number":70,"context_line":"            client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":71,"context_line":"                                                   timeout\u003drpc_timeout,"},{"line_number":72,"context_line":"                                                   retry\u003drpc_retries)"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"4eed8a7c_4be21d0f","line":69,"in_reply_to":"37bfe302_0fee47fe","updated":"2023-05-25 13:46:32.000000000","message":"Done","commit_id":"a2ca4265c133dcf7cf2c22bdc2acc7fb08c29475"},{"author":{"_account_id":8104,"name":"June Yi","display_name":"gochist","email":"june.yi@samsung.com","username":"juneyi"},"change_message_id":"8ddf7325c0a3eee0ade5812f796c0959a2173c67","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            from oslo_messaging import get_rpc_client"},{"line_number":70,"context_line":"            client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":71,"context_line":"                                                   timeout\u003drpc_timeout,"},{"line_number":72,"context_line":"                                                   retry\u003drpc_retries)"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"37bfe302_0fee47fe","line":69,"in_reply_to":"4bcce968_fd84733e","updated":"2023-05-25 12:10:34.000000000","message":"I think that is an important point too. So I looked through the Zuul logs, but I haven\u0027t found any clues yet. If I find one, I\u0027ll contact you via the slack channel.","commit_id":"a2ca4265c133dcf7cf2c22bdc2acc7fb08c29475"},{"author":{"_account_id":8104,"name":"June Yi","display_name":"gochist","email":"june.yi@samsung.com","username":"juneyi"},"change_message_id":"5a2eecd43442fdf123cc0cf1b94426be7c2bfe1d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            from oslo_messaging import get_rpc_client"},{"line_number":70,"context_line":"            client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":71,"context_line":"                                                   timeout\u003drpc_timeout,"},{"line_number":72,"context_line":"                                                   retry\u003drpc_retries)"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"23f0a9ae_c8a42fd6","line":69,"in_reply_to":"4eed8a7c_4be21d0f","updated":"2023-05-25 16:27:15.000000000","message":"I found that it didn\u0027t failed with get_rpc_client because the `AttributeError` was caught by the broad except block and the exception was handled to return success by `sys.exit(0)`.","commit_id":"a2ca4265c133dcf7cf2c22bdc2acc7fb08c29475"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ca4003905784f07556a0703be00f92216eb36f03","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            namespace\u003d\u0027baseapi\u0027,"},{"line_number":67,"context_line":"            version\u003d\"1.1\")"},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            from oslo_messaging import get_rpc_client"},{"line_number":70,"context_line":"            client \u003d oslo_messaging.get_rpc_client(transport, target,"},{"line_number":71,"context_line":"                                                   timeout\u003drpc_timeout,"},{"line_number":72,"context_line":"                                                   retry\u003drpc_retries)"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"4bcce968_fd84733e","line":69,"in_reply_to":"975ff67c_2ba6a8a6","updated":"2023-05-25 11:42:53.000000000","message":"Yes, this is gonna work. BTW, did you try to figure out why tests (even for older releases) didn\u0027t fail with get_rpc_client?","commit_id":"a2ca4265c133dcf7cf2c22bdc2acc7fb08c29475"}]}