)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bb41e0bdb04228bafaf9720baf14e283ac1db5ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9952a120_e8020a13","updated":"2023-08-28 23:33:53.000000000","message":"Can you please abandon this PR and review the similar https://review.opendev.org/c/openstack/openstack-helm/+/888109 I asked James Mosher to add the Co-authored-by tag to the commit message?","commit_id":"1f3731511730208ac13d28f101b4f587f357a356"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"de97e11c7464605cab048825144d834ebac9eed4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7ab0bed_6a48cd49","updated":"2023-08-25 22:42:25.000000000","message":"There is similar PR https://review.opendev.org/c/openstack/openstack-helm/+/888109 I\u0027ll take a look carefully at both and probably we can merge these two approches.","commit_id":"1f3731511730208ac13d28f101b4f587f357a356"}],"nova/templates/certificate-novnc.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bb41e0bdb04228bafaf9720baf14e283ac1db5ad","unresolved":true,"context_lines":[{"line_number":15,"context_line":"*/}}\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"{{- if (contains \"vencrypt\" .Values.conf.nova.vnc.auth_schemes) -}}\r"},{"line_number":18,"context_line":"apiVersion: cert-manager.io/v1\r"},{"line_number":19,"context_line":"kind: Certificate\r"},{"line_number":20,"context_line":"metadata:\r"},{"line_number":21,"context_line":"  name: nova-novncproxy-vencrypt\r"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d3a65baf_b16060ac","line":18,"updated":"2023-08-28 23:33:53.000000000","message":"We use helm-toolkit certificates manifest to generate all the certificates uniformly.","commit_id":"1f3731511730208ac13d28f101b4f587f357a356"}],"nova/templates/deployment-novncproxy.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"be03374302cbf19a80a64216fc67a7232b3a4dbe","unresolved":true,"context_lines":[{"line_number":133,"context_line":"              mountPath: /etc/nova/nova.conf"},{"line_number":134,"context_line":"              subPath: nova.conf"},{"line_number":135,"context_line":"              readOnly: true"},{"line_number":136,"context_line":"{{- if (contains \"vencrypt\" .Values.conf.nova.vnc.auth_schemes) -}}"},{"line_number":137,"context_line":"            - name: vencrypt-certs"},{"line_number":138,"context_line":"              mountPath: /etc/pki/nova-novncproxy"},{"line_number":139,"context_line":"              readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"89faa2d8_239a7b7e","line":136,"updated":"2023-08-24 20:18:52.000000000","message":"It gonna give an error. Need to remove the dash before closing `}}`\nIt should be \n```\n{{- if (contains \"vencrypt\" .Values.conf.nova.vnc.auth_schemes) }}\n```","commit_id":"2767489d8dfeb453224c65d9dce825b87c48b945"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"be03374302cbf19a80a64216fc67a7232b3a4dbe","unresolved":true,"context_lines":[{"line_number":166,"context_line":"          emptyDir: {}"},{"line_number":167,"context_line":"        - name: pod-shared"},{"line_number":168,"context_line":"          emptyDir: {}"},{"line_number":169,"context_line":"{{- if (contains \"vencrypt\" .Values.conf.nova.vnc.auth_schemes) -}}"},{"line_number":170,"context_line":"        - name: vencrypt-certs"},{"line_number":171,"context_line":"          secret:"},{"line_number":172,"context_line":"            secretName: nova-novncproxy-vencrypt"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d1f4a223_311b7525","line":169,"updated":"2023-08-24 20:18:52.000000000","message":"ditto","commit_id":"2767489d8dfeb453224c65d9dce825b87c48b945"}]}