)]}'
{"id":"openstack%2Fopenstack-helm~896461","triplet_id":"openstack%2Fopenstack-helm~master~Iaf86e0a215802001f58d607a1a3a18acf83f5e81","project":"openstack/openstack-helm","branch":"master","attention_set":{},"removed_from_attention_set":{"3009":{"account":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"last_update":"2023-09-26 20:12:04.000000000","reason":"\u003cGERRIT_ACCOUNT_3009\u003e replied on the change","reason_account":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"}},"33594":{"account":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"last_update":"2023-09-27 22:04:21.000000000","reason":"Change was submitted"},"28459":{"account":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"last_update":"2023-09-25 19:47:28.000000000","reason":"\u003cGERRIT_ACCOUNT_28459\u003e replied on the change","reason_account":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"}},"21420":{"account":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"last_update":"2023-09-27 22:04:21.000000000","reason":"Change was submitted"},"8863":{"account":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"last_update":"2023-09-27 22:04:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iaf86e0a215802001f58d607a1a3a18acf83f5e81","subject":"Nova: Add IP addresses search control flag","status":"MERGED","created":"2023-09-25 18:49:59.000000000","updated":"2023-09-27 22:05:31.000000000","submitted":"2023-09-27 22:04:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"896461","meta_rev_id":"16d59db7817b036582b74588834bc7fb130f1c94","_number":896461,"virtual_id_number":896461,"owner":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":0,"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":0,"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},{"value":0,"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-09-27 22:04:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"all":[{"value":2,"date":"2023-09-26 20:12:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":2,"date":"2023-09-27 21:11:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":1,"date":"2023-09-26 12:53:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},{"value":1,"date":"2023-09-25 19:47:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"all":[{"value":0,"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"value":1,"date":"2023-09-27 21:11:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"value":0,"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},{"value":0,"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"}],"reviewers":{"REVIEWER":[{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-25 18:49:59.000000000","updated_by":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"reviewer":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"state":"REVIEWER"},{"updated":"2023-09-25 18:51:24.000000000","updated_by":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"reviewer":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"state":"REVIEWER"},{"updated":"2023-09-25 20:06:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-25 20:08:37.000000000","updated_by":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"reviewer":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"state":"REVIEWER"},{"updated":"2023-09-26 12:53:33.000000000","updated_by":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"reviewer":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"state":"REVIEWER"},{"updated":"2023-09-26 21:24:59.000000000","updated_by":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"reviewer":{"_account_id":8863,"name":"Andrii Ostapenko","email":"anost1986@gmail.com","username":"aostapenko"},"state":"REVIEWER"},{"updated":"2023-09-27 21:11:46.000000000","updated_by":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"reviewer":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"state":"REVIEWER"}],"messages":[{"id":"8b6fc67e0021b219083da546bcf2fa5df9e6daa4","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"date":"2023-09-25 18:49:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"809b1d1b28803da9ed689693cb3eef0683b635fe","author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"date":"2023-09-25 18:51:24.000000000","message":"Patch Set 1:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"dd59e746ea6cd9a1c21be2aa138b43dd2bf5eb61","author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"date":"2023-09-25 19:47:28.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"51e083725cfe198533b500cf57198bb3eae3c6d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-25 20:06:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b880f49e194d4fa69c0a9c057be951e2\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6dc8a199cb5c4424a753789e7492b684 : SUCCESS in 7m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ca9acf09de404962b7e17e067821d93c : SUCCESS in 3m 36s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/0ee64b81f9b7481ea84e1282a281d02b : SUCCESS in 3m 08s\n- openstack-helm-compute-kit-yoga-ubuntu_focal https://zuul.opendev.org/t/openstack/build/6bc1912527064b48b1b15e763e120009 : SUCCESS in 51m 29s\n- openstack-helm-compute-kit-zed-ubuntu_focal https://zuul.opendev.org/t/openstack/build/c4c4aaf14d2948e0866a6ca74fee05ec : SUCCESS in 1h 06m 42s\n- openstack-helm-compute-kit-zed-ubuntu_jammy https://zuul.opendev.org/t/openstack/build/cf0fe3deaa3c42fa9f63d64a59b8a680 : SUCCESS in 1h 07m 25s\n- openstack-helm-compute-kit-2023-1-ubuntu_focal https://zuul.opendev.org/t/openstack/build/b4f6692b19d0409aa3ff87436204c824 : SUCCESS in 57m 58s\n- openstack-helm-compute-kit-2023-1-ubuntu_jammy https://zuul.opendev.org/t/openstack/build/50dd95e901c94979bcf58174e384144d : SUCCESS in 1h 06m 09s\n- openstack-helm-umbrella-2023-1-ubuntu_focal https://zuul.opendev.org/t/openstack/build/528f59942c4943388c60e7b9c45e1cae : SUCCESS in 1h 15m 02s\n- openstack-helm-tls-2023-1-ubuntu_focal https://zuul.opendev.org/t/openstack/build/217898cfbe3a48578407aff4a2943417 : SUCCESS in 58m 38s","accounts_in_message":[],"_revision_number":1},{"id":"65a2128dceb106aed3f80a27a7328e3b78e24829","author":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"},"date":"2023-09-26 12:53:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"28dbbdcf0ea3e99463173ac1808799da72ad39ee","author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"date":"2023-09-26 20:12:04.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"94a28d06e0755ad5a7c60051358664aa37412fe6","author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"date":"2023-09-27 21:11:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2b8e58ddfacf3a0d557a4e38f292453398bcd1e9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-27 21:12:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"97ac8050a2d8f5a577493b529066fcb9c496ae2a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-27 22:04:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/45bb586c54a44f5fa4621cc926c7ca92\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/005eed74df1c4b008e4c123d667c9225 : SUCCESS in 7m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9289d0afeba94050acb7791e5bbb8b58 : SUCCESS in 3m 11s\n- openstack-helm-lint https://zuul.opendev.org/t/openstack/build/3fa2c6f4f238439cbddb3214f8480b07 : SUCCESS in 3m 28s\n- openstack-helm-compute-kit-2023-1-ubuntu_focal https://zuul.opendev.org/t/openstack/build/c695b9144f2142c3b90bdd43e343c83f : SUCCESS in 51m 42s","accounts_in_message":[],"_revision_number":1},{"id":"001c8383946daeb01d6ccde8930e887f914b0004","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-27 22:04:21.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"16d59db7817b036582b74588834bc7fb130f1c94","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-27 22:05:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/809c22e9ee044e45a7b469b911c6b72e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9cde37aad6664f4fa7af92a56d86cd45 : SUCCESS in 53s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9723f5cea7b142269385047824866616 : SUCCESS in 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7189e6c9165485af6d152089e8607881773bbf9a","revisions":{"7189e6c9165485af6d152089e8607881773bbf9a":{"kind":"REWORK","_number":1,"created":"2023-09-25 18:49:59.000000000","uploader":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"ref":"refs/changes/61/896461/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/61/896461/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/61/896461/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/61/896461/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/61/896461/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/61/896461/1"}}},"commit":{"parents":[{"commit":"75c30f43db44218e7842611e880fd8d7a30fa79c","subject":"Merge \"Fix start function template\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/75c30f43db44218e7842611e880fd8d7a30fa79c"}]}],"author":{"name":"Thales Elero Cervi","email":"thaleselero.cervi@windriver.com","date":"2023-09-25 18:34:55.000000000","tz":-180},"committer":{"name":"Thales Elero Cervi","email":"thaleselero.cervi@windriver.com","date":"2023-09-25 18:49:46.000000000","tz":-180},"subject":"Nova: Add IP addresses search control flag","message":"Nova: Add IP addresses search control flag\n\nAdd options to nova to enable/disable the use of:\n1. The vnc or spice server proxyclient address found by the console\n   compute init container\n2. The my_ip hypervisor address found by compute init container\n3. The libvirt live_migration_inbound_addr used by nova compute to\n   live-migrate instances\n\nThese options can be used to prevent cases where the found addresses\noverwrite what has already been defined in nova.conf by per host nova\ncompute DaemonSet overrides.\nIt is important to allow the flexibility of using or not the default\nConfigMap - DaemonSet cluster level configuration, allowing the\npossibility of having custom per host overrides definitions that will\nnot be overwrite by nova-compute-init.sh\n\nOne use case (live-migration) for this flexibility is the following:\nOriginally the nova-compute-init.sh script received the capability of\nselection a target interface (by name, in a ConfigMap level) through\nwhich the live-migration traffic should be handled [1], allowing the\npossibility of selecting a separate network to handle live-migration\ntraffic. This was not assuming any interface/network IP if users did not\nset .Values.conf.libvirt.live_migration_interface.\nLater [2], same script was updated to fall-back to default gateway IP\nresolution in case the live_migration_interface is not defined.\nSo, currently it is mandatory to define a \"cluster level config\" for the\ninterface name (i.e., through ConfigMap) or to rely on default gateway\nIP resolution for live-migration addresses.\nThis can be problematic for use cases were:\n* There are many networks defined for the cluster and a host default\n  gateway might not resolve to the desired network IP;\n* There is the need of having a per host definition of nova.conf, since\n  nova-compute-init.sh will create a new .conf that will overwrite it.\n\n[1] commit 31be86079d711c698b2560b4bed654e23373a596\n[2] commit 8f0a15413839c92d6d527bf7cbc441380de6c2af\n\nChange-Id: Iaf86e0a215802001f58d607a1a3a18acf83f5e81\nSigned-off-by: Thales Elero Cervi \u003cthaleselero.cervi@windriver.com\u003e\nSigned-off-by: Robert Church \u003crobert.church@windriver.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7189e6c9165485af6d152089e8607881773bbf9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7189e6c9165485af6d152089e8607881773bbf9a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":34455,"name":"Lucas de Ataides Barreto","display_name":"Lucas de Ataides","email":"lucas.deataidesbarreto@windriver.com","username":"lucasdeataides"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}