)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e8db6c10cc0f0430ee5b84c71bc76e394f4cbae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4dac15fd_c4f05339","updated":"2023-12-06 20:33:08.000000000","message":"recheck","commit_id":"8d901e2bb6822dad6af180260754a38a9434882c"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c5bcbfe24771faa595d2220e30b7a3bce71c482e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"58b3c9d8_eb051d88","updated":"2023-12-07 01:44:29.000000000","message":"recheck","commit_id":"f6f73918dff4dc05a3769600cce8a6e6fe018210"}],"tools/deployment/component/ceph/ceph.sh":[{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"d4b0ae31530085151e6d27c038346e91c10a55bc","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  make -C ${HELM_CHART_ROOT_PATH} \"${CHART}\""},{"line_number":26,"context_line":"done"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NUMBER_OF_OSDS\u003d\"$(kubectl get nodes -l ceph-osd\u003denabled --no-headers | wc -l)\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Deploy command"},{"line_number":31,"context_line":"[ -s /tmp/ceph-fs-uuid.txt ] || uuidgen \u003e /tmp/ceph-fs-uuid.txt"}],"source_content_type":"text/x-sh","patch_set":12,"id":"6e9b4fff_2fc0b9a1","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":78},"updated":"2023-12-08 00:07:50.000000000","message":"We can probably get away with this for now, but this assumes a single OSD per OSD node. Would it be better to count the number of ceph-osd pods instead?","commit_id":"444f1fd161494373389a251c9f52b9c4c00ecc18"},{"author":{"_account_id":29974,"name":"Stephen Taylor","email":"stephen.taylor.1@att.com","username":"st053q"},"change_message_id":"30eedd0bba8d7248ca4f7f02a81d40ea9c47354c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  make -C ${HELM_CHART_ROOT_PATH} \"${CHART}\""},{"line_number":26,"context_line":"done"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NUMBER_OF_OSDS\u003d\"$(kubectl get nodes -l ceph-osd\u003denabled --no-headers | wc -l)\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Deploy command"},{"line_number":31,"context_line":"[ -s /tmp/ceph-fs-uuid.txt ] || uuidgen \u003e /tmp/ceph-fs-uuid.txt"}],"source_content_type":"text/x-sh","patch_set":12,"id":"712798ef_878b8b7a","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":78},"in_reply_to":"6e9b4fff_2fc0b9a1","updated":"2023-12-08 00:13:39.000000000","message":"Thinking about it more, this is probably the right way to do this for now. It would be better not to assume a single OSD per node, but making it more robust is probably more work that it is worth.","commit_id":"444f1fd161494373389a251c9f52b9c4c00ecc18"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ab0c76a69035f6665c89fd3e69bf5274386ae464","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  make -C ${HELM_CHART_ROOT_PATH} \"${CHART}\""},{"line_number":26,"context_line":"done"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"NUMBER_OF_OSDS\u003d\"$(kubectl get nodes -l ceph-osd\u003denabled --no-headers | wc -l)\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Deploy command"},{"line_number":31,"context_line":"[ -s /tmp/ceph-fs-uuid.txt ] || uuidgen \u003e /tmp/ceph-fs-uuid.txt"}],"source_content_type":"text/x-sh","patch_set":12,"id":"55647a26_15164ec9","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":78},"in_reply_to":"712798ef_878b8b7a","updated":"2023-12-08 04:57:14.000000000","message":"You are right, that it is better to count the number of OSDs. This script is mostly for testing purposes and it is only used for the case when we deploy ceph using OSH charts (not Rook). Ceph OSD is a daemonset with the node selector ceph-osd\u003denabled, so I assume it is more or less fair to say that the number of OSDs is always equeal to the number of K8s nodes with this selector.","commit_id":"444f1fd161494373389a251c9f52b9c4c00ecc18"}]}