)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"0d6db0037f2310b658f2eff912d90af1016b8fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b49a3ed1_770c38cf","updated":"2024-01-19 17:24:05.000000000","message":"Can you please elaborate the benefit of writing logs to a in-memory volume?","commit_id":"df77c3ae09501caa3a410e1397a0db79ee9c5c96"}],"keystone/templates/cron-job-credential-rotate.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"0d6db0037f2310b658f2eff912d90af1016b8fc9","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                  subPath: {{ base .Values.conf.keystone.DEFAULT.log_config_append }}"},{"line_number":114,"context_line":"                  readOnly: true"},{"line_number":115,"context_line":"                {{- end }}"},{"line_number":116,"context_line":"                {{- if .Values.conf.keystone.DEFAULT.log_dir }}"},{"line_number":117,"context_line":"                - name: log"},{"line_number":118,"context_line":"                  mountPath: {{ .Values.conf.keystone.DEFAULT.log_dir }}"},{"line_number":119,"context_line":"                {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"964ede6c_bb7e72dd","line":116,"updated":"2024-01-19 17:24:05.000000000","message":"According to Keystone documentation this log_dir configuration parameter will be ignored if log_config_append is set. Also log_dir parameter is only going to be consumed by the keystone-manage command, but the script itself /tmp/fernet-manage.py also writes its own log messages.","commit_id":"df77c3ae09501caa3a410e1397a0db79ee9c5c96"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"0d6db0037f2310b658f2eff912d90af1016b8fc9","unresolved":true,"context_lines":[{"line_number":135,"context_line":"              configMap:"},{"line_number":136,"context_line":"                name: keystone-bin"},{"line_number":137,"context_line":"                defaultMode: 0555"},{"line_number":138,"context_line":"            {{- if .Values.conf.keystone.DEFAULT.log_dir }}"},{"line_number":139,"context_line":"            - name: log"},{"line_number":140,"context_line":"              emptyDir: {}"},{"line_number":141,"context_line":"            {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c02f827c_e88bc983","line":138,"updated":"2024-01-19 17:24:05.000000000","message":"What is the benefit of having logs on a ephemeral in memory volume? This looks like K8s anti-pattern. Usually processes running in containers are assumed to write their logs to stdout/stderr and then the container runtime is responsible for capturing them and storing in files.","commit_id":"df77c3ae09501caa3a410e1397a0db79ee9c5c96"}]}