)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35674,"name":"ChungWon Lee","display_name":"cw0306-lee","email":"cw0306.lee@samsung.com","username":"cw0306-lee"},"change_message_id":"47d59b97385ea8c016d263223930696473d658ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18fa68fc_2a5ea766","updated":"2024-02-26 09:40:52.000000000","message":"recheck","commit_id":"2039086c05aa42214a26846fb22121b92a1ce328"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"be807284b8dde7f5733f727474b84a5943d41220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54aaa5f0_88732654","updated":"2024-03-04 01:58:16.000000000","message":"I updated the PR so we use metadata_listen_port instead of metadata_port. Also updated the tls override in neutron so it uses the correct metadata hostname. Usually, openstack services should use internal endpoints for interacting with each other. But in case of tls feature enabled services connect to TLS endpoints served by ingress controller.","commit_id":"e48aa98ca370e7dc8595d35846919017157b57b3"},{"author":{"_account_id":34520,"name":"Sergiy Markin","email":"smarkin@mirantis.com","username":"sm515x"},"change_message_id":"f1d3f765a5e5ec7b88bb8425aa909829c4f2bb21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c980b925_45320a96","updated":"2024-03-04 21:57:50.000000000","message":"recheck","commit_id":"44e2b10447085ca0f30bb76d80ee92a89ed8db9f"}],"nova/templates/configmap-etc.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"266fe1e9a5db6035072fdf9db4d045a89a2a37ff","unresolved":true,"context_lines":[{"line_number":151,"context_line":"{{- $_ :\u003d set .Values.conf.nova.DEFAULT \"metadata_host\" .Values.endpoints.compute_metadata.ip.ingress -}}"},{"line_number":152,"context_line":"{{- end -}}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"{{- if empty .Values.conf.nova.DEFAULT.metadata_port -}}"},{"line_number":155,"context_line":"{{- $_ :\u003d tuple \"compute_metadata\" \"public\" \"metadata\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" | set .Values.conf.nova.DEFAULT \"metadata_port\" -}}"},{"line_number":156,"context_line":"{{- end -}}"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"898edd19_39d2a2ff","side":"PARENT","line":154,"updated":"2024-02-27 18:04:17.000000000","message":"Thanks a lot for catching this bug.\n\nCan you please clarify why did you choose to remove this instead of replacing it with metadata_listen_port?\n\nThe very idea of this block is that users can set metadata port in values.yaml and then we use helm-toolkit endpoint snippet to configure all the Nova manifests in agreement with each other from this single point of truth. If you just remove this block then the default port will always be used no matter which port is defined here https://opendev.org/openstack/openstack-helm/src/branch/master/nova/values.yaml#L1866","commit_id":"552cab2ff17d4d430b24ce115cbf42ee51aee0f7"},{"author":{"_account_id":35674,"name":"ChungWon Lee","display_name":"cw0306-lee","email":"cw0306.lee@samsung.com","username":"cw0306-lee"},"change_message_id":"267c1f8b74d5018bd5fd624af27a9dcde5d79077","unresolved":true,"context_lines":[{"line_number":151,"context_line":"{{- $_ :\u003d set .Values.conf.nova.DEFAULT \"metadata_host\" .Values.endpoints.compute_metadata.ip.ingress -}}"},{"line_number":152,"context_line":"{{- end -}}"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"{{- if empty .Values.conf.nova.DEFAULT.metadata_port -}}"},{"line_number":155,"context_line":"{{- $_ :\u003d tuple \"compute_metadata\" \"public\" \"metadata\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" | set .Values.conf.nova.DEFAULT \"metadata_port\" -}}"},{"line_number":156,"context_line":"{{- end -}}"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"aba0ad36_95369a92","side":"PARENT","line":154,"in_reply_to":"898edd19_39d2a2ff","updated":"2024-02-28 02:04:37.000000000","message":"First, I tried to use metadata_listen_port. Then, it used public port number 80 and occured permission denied error when nova-metadata starts https://zuul.opendev.org/t/openstack/build/431eff97f3c945dea11f501ceeea5ca7.\nNext, I changed to use default port and host instead of public, also changed neutron configmap-etc here https://opendev.org/openstack/openstack-helm/src/branch/master/neutron/templates/configmap-etc.yaml#L127-L135. It occured error in zuul tls test https://zuul.opendev.org/t/openstack/build/dded421f666b45f29f6bd4d98c00f820.","commit_id":"552cab2ff17d4d430b24ce115cbf42ee51aee0f7"}]}