)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"93ae0e6514bae3c2a6ab18d3a2012ac20d8a511d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"945f8f94_f28914e0","updated":"2024-03-21 23:54:03.000000000","message":"Can I suggest using something like this https://review.opendev.org/c/openstack/openstack-helm-infra/+/913935 ?\n\nUsing this snippet does not require setting all this empty values in the values.yaml file. The snippet can check the key and if it does not exist then the value will be considered as empty. \n\nAlso you don\u0027t need all this boilerplate code in all the templates. Instead you can just add a single line\n```\n{{ tuple \"ceilometer_compute\" . | include \"helm-toolkit.snippets.custom_pod_annotations\" }}\n```\nand the snippet will insert \u003cspecific\u003e if it is defined and \u003cdefault\u003e otherwise.\nannotations:\n  pod:\n    default: \u003cdefault\u003e\n    ceilometer_compute: \u003cspecific\u003e\n```\nAnd if nothing is defined, then nothing will be inserted.","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1468cb3bc4724034cc356351ba4bf69a17a8c3f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ac3b86d_9c09d485","in_reply_to":"2fc945d0_b4958ba1","updated":"2024-03-22 23:05:49.000000000","message":"Thanks, looks good. BTW, can you please give your +1 on the 913935?","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"dbf01ccc8025c6a15b6995168fed2d14936c29e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"996697d4_834d52d3","in_reply_to":"3ac3b86d_9c09d485","updated":"2024-03-22 23:13:42.000000000","message":"Done","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"641a6954b75a4b82c2c42014549acd7bf21b036e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2fc945d0_b4958ba1","in_reply_to":"3b0bf19b_3e971e14","updated":"2024-03-22 21:24:44.000000000","message":"Removed changes related to secrets and for pod annotations used new test snippet","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":34311,"name":"Tadas Sutkaitis","display_name":"Tadas Sutkaitis","email":"tadasas@gmail.com","username":"t42x"},"change_message_id":"abe018f4dd16a47de0783da72a9898472cc12b79","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f06c9bc_c2f53364","in_reply_to":"945f8f94_f28914e0","updated":"2024-03-22 00:31:55.000000000","message":"Nice. Then i’ll wait until 913935 merge and refactor everything later. In a meantime i’ll create similar function in a helm-toolkit but for secrets.","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"52e27d2ebc17597b987ccbb96c7e904d3dc298ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b0bf19b_3e971e14","in_reply_to":"9f06c9bc_c2f53364","updated":"2024-03-22 20:18:36.000000000","message":"It is better not to wait till we merge 913935. Instead let\u0027s test your changes with this new snippet. If you agree with the approach please modify your PR so it uses this snippet and in the commit message please add the line\n```\nDepends-On: I898afae7945c03aec909e5edcd1c760c4d8ff9d6\n```","commit_id":"4fac15320191d5ce67f4cff5637c41ab49c80149"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2339a3fc9282cdb1b6aceffcc392ab955da1e813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"15c74b72_a239dc0b","updated":"2024-03-25 21:39:02.000000000","message":"recheck","commit_id":"91656d0cf4f39cfd673f6970c68bab554855fef5"}]}