)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"842fb95d7b403acc0e9399d50bac579ca2206565","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9bb55b9f_f2dd9065","updated":"2024-05-07 17:54:22.000000000","message":"recheck","commit_id":"75ea03d73b4f917804dfdc890b3fb39a92a960c3"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"929948aa54150868be568f926035d8b1ce1efe9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bc9bd094_0c34d637","updated":"2024-05-07 19:22:30.000000000","message":"recheck","commit_id":"75ea03d73b4f917804dfdc890b3fb39a92a960c3"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"df8206138c7d6c6c95a69ed7d13a5e7a9c80a54c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b94735db_e1ef5a8a","updated":"2024-05-22 19:51:31.000000000","message":"I\u0027ve made the adjustments you\u0027ve suggested. I\u0027ve also made some other updates to the white space because I see the default has some whitespace issues. I\u0027ve also added the shebang to the default scripts. Basically I\u0027ve now tested the default case rather than using my local values.yaml override, which I should have done in the first place.","commit_id":"5f088cb173495dea933f3bc647aa3d656eb87983"}],"ironic/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e2df6f60c8931e872d5e0b816cb266b81c783863","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        #NOTE(portdirect): this works around a limitation in Kolla images"},{"line_number":242,"context_line":"        if ! dpkg -l ipxe; then"},{"line_number":243,"context_line":"          apt-get update"},{"line_number":244,"context_line":"          apt-get install ipxe -y"},{"line_number":245,"context_line":"        fi"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # default to Ubuntu path"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e1e97cfd_067ce405","line":244,"updated":"2024-05-20 21:29:30.000000000","message":"As you mentioned earlier ipxe package is already installed in the ironic image. Looks like we don\u0027t need this.","commit_id":"4ddbc818b198d4e13755b7271ac5b867e590cd24"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"df8206138c7d6c6c95a69ed7d13a5e7a9c80a54c","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        #NOTE(portdirect): this works around a limitation in Kolla images"},{"line_number":242,"context_line":"        if ! dpkg -l ipxe; then"},{"line_number":243,"context_line":"          apt-get update"},{"line_number":244,"context_line":"          apt-get install ipxe -y"},{"line_number":245,"context_line":"        fi"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # default to Ubuntu path"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4c87be37_3746bd3e","line":244,"in_reply_to":"e1e97cfd_067ce405","updated":"2024-05-22 19:51:31.000000000","message":"Done","commit_id":"4ddbc818b198d4e13755b7271ac5b867e590cd24"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e2df6f60c8931e872d5e0b816cb266b81c783863","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        # default to Ubuntu path"},{"line_number":248,"context_line":"        FILEPATH\u003d${FILEPATH:-/usr/lib/ipxe}"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"      elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if ! yum list installed ipxe-bootimgs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":253,"context_line":"          yum update --nogpgcheck -y"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c5f6909a_8f481f3b","line":250,"updated":"2024-05-20 21:29:30.000000000","message":"The default image in values.yaml is ironic:2024.1-ubuntu_jammy. Can we maybe just remove this centos related stuff by default?","commit_id":"4ddbc818b198d4e13755b7271ac5b867e590cd24"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"df8206138c7d6c6c95a69ed7d13a5e7a9c80a54c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # default to Ubuntu path"},{"line_number":248,"context_line":"        FILEPATH\u003d${FILEPATH:-/usr/lib/ipxe}"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"      elif [ \"x$HOST_OS\" \u003d\u003d \"xcentos\" ]; then"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if ! yum list installed ipxe-bootimgs \u003e/dev/null 2\u003e\u00261; then"},{"line_number":253,"context_line":"          yum update --nogpgcheck -y"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1cad1458_816c7b0e","line":250,"in_reply_to":"c5f6909a_8f481f3b","updated":"2024-05-22 19:51:31.000000000","message":"Done","commit_id":"4ddbc818b198d4e13755b7271ac5b867e590cd24"}]}