)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"9b90a55c16a2c866892c2804c082970dce5e5dbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"abeaa97b_a3d8b8a1","updated":"2024-11-13 21:47:44.000000000","message":"recheck","commit_id":"d88e3216f0589998938390c11b6135305f4f41b1"}],"tempest/templates/bin/_run-tests.sh.tpl":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9f9bb205a8c43727375ad46f19eb132a5767691","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if [ ! -f /etc/tempest/test-blacklist ]; then"},{"line_number":20,"context_line":"  touch /etc/tempest/test-blacklist"},{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [ ! -f /etc/tempest/test-whitelist ]; then"},{"line_number":24,"context_line":"  touch /etc/tempest/test-whitelist"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{ if .Values.conf.cleanup.previous_run }}"},{"line_number":28,"context_line":"tempest cleanup --prefix {{ .Values.conf.cleanup.prefix_name }}"},{"line_number":29,"context_line":"{{ end }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{ if .Values.conf.cleanup.enabled }}"},{"line_number":32,"context_line":"mkdir -p /var/lib/tempest/saved_state"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"7f1cb0a0_df41507d","line":29,"range":{"start_line":19,"start_character":0,"end_line":29,"end_character":9},"updated":"2024-11-25 18:50:25.000000000","message":"this is not needed, just pass correct command depending on if mentioned files are present or not.","commit_id":"802f8015da77f529920737d1fab50c1ce1972ff0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9f9bb205a8c43727375ad46f19eb132a5767691","unresolved":true,"context_lines":[{"line_number":39,"context_line":"popd"},{"line_number":40,"context_line":"{{- end }}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ if .Values.conf.subunit_output }}"},{"line_number":43,"context_line":"tempest run --include-list /etc/tempest/test-whitelist --exclude-list /etc/tempest/test-blacklist --config-file /etc/tempest/tempest.conf -w 4 --smoke --subunit \u003e /var/lib/tempest/data/results.subunit"},{"line_number":44,"context_line":"cat /var/lib/tempest/data/results.subunit | subunit2junitxml -o /var/lib/tempest/data/results.junit || echo converted subunit file"},{"line_number":45,"context_line":"{{ else }}"},{"line_number":46,"context_line":"{{ .Values.conf.script }}"},{"line_number":47,"context_line":"{{- end }}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"f5ef4108_c1bfe504","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":10},"updated":"2024-11-25 18:50:25.000000000","message":"just pass the script you want in .Values.conf.script.","commit_id":"802f8015da77f529920737d1fab50c1ce1972ff0"}],"tempest/templates/job-run-tests.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6ad5a2de8727d03c7dcda476ebff00764bd96733","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        {{- if .Values.pvc.enabled }}"},{"line_number":118,"context_line":"          persistentVolumeClaim:"},{"line_number":119,"context_line":"            claimName: {{ .Values.pvc.name }}"},{"line_number":120,"context_line":"        {{- else if .Values.conf.subunit_output }}"},{"line_number":121,"context_line":"          hostPath:"},{"line_number":122,"context_line":"            path: /tmp/tempest-reports"},{"line_number":123,"context_line":"        {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"46144259_1537317a","line":120,"updated":"2024-11-13 03:24:19.000000000","message":"IMO this is a bit too specific. Let\u0027s consider having storage field in the values.yaml\n```\nstorage: pvc  #  or local or ephemeral\n```\n\nand then in the template we could have\n```\n{{- if eq .Values.storage \"pvc\" }}\npersistentVolumeClaim:\n  claimName: {{ .Values.pvc.name }}\n{{ else if eq .Values.storage \"local\" }}\nhostPath:\n  path: /tmp/tempest-reports\n{{- else }}\nemptyDir: {}\n\n```\n\nLater we will introduce more format values format.","commit_id":"39ea38b20d77057985c453fb7859867c6c1816a8"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ef05dfa6bcd146d2958980782c6563a1277cc299","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        {{- if .Values.pvc.enabled }}"},{"line_number":118,"context_line":"          persistentVolumeClaim:"},{"line_number":119,"context_line":"            claimName: {{ .Values.pvc.name }}"},{"line_number":120,"context_line":"        {{- else if .Values.conf.subunit_output }}"},{"line_number":121,"context_line":"          hostPath:"},{"line_number":122,"context_line":"            path: /tmp/tempest-reports"},{"line_number":123,"context_line":"        {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7925ac39_7ba8603f","line":120,"in_reply_to":"33b0f0e4_8a980359","updated":"2024-11-13 21:47:36.000000000","message":"You are right the structure of values.yaml is not ideal and we are going to spend some cycles to make it more formal and cover all such patterns. \n\nFor this particular case you can use this:\n```\n{{- if and (eq .Values.conf.storage \"pvc\") .Values.pvc.enabled }}\n```\n\nNot ideal, but at least this parameter subunit_output is not involved. It specifies whether user wants to save reports or not. What if I want to enable it subunit_output but I would like to save reports to pvc? It wasn\u0027t possible with the previous PS.\n\nBTW, when I commented the previous PS I was thinking about these two patterns [1] and [2] in the rabbitmq chart and [3] and [4] in the glance chart.\n\n[1] https://opendev.org/openstack/openstack-helm-infra/src/branch/master/rabbitmq/values.yaml#L459-L466\n[2] https://opendev.org/openstack/openstack-helm-infra/src/branch/master/rabbitmq/templates/statefulset.yaml#L339-L359\n\n[3] https://opendev.org/openstack/openstack-helm/src/branch/master/glance/values.yaml#L20\n[4] https://opendev.org/openstack/openstack-helm/src/branch/master/glance/templates/deployment-api.yaml#L337-L349","commit_id":"39ea38b20d77057985c453fb7859867c6c1816a8"},{"author":{"_account_id":30176,"name":"masterpe","email":"michiel@piscaer.com","username":"masterpe"},"change_message_id":"2eb60dd1a60c7b67b29fe3763ff8f171f1517071","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        {{- if .Values.pvc.enabled }}"},{"line_number":118,"context_line":"          persistentVolumeClaim:"},{"line_number":119,"context_line":"            claimName: {{ .Values.pvc.name }}"},{"line_number":120,"context_line":"        {{- else if .Values.conf.subunit_output }}"},{"line_number":121,"context_line":"          hostPath:"},{"line_number":122,"context_line":"            path: /tmp/tempest-reports"},{"line_number":123,"context_line":"        {{- else }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"33b0f0e4_8a980359","line":120,"in_reply_to":"46144259_1537317a","updated":"2024-11-13 12:18:23.000000000","message":"@kozhukalov@gmail.com I don\u0027t know how happy I\u0027m with this solution. Because this will break a config when someone uses the pvc.enable: false and will results tempest-reposts inside a pvc.","commit_id":"39ea38b20d77057985c453fb7859867c6c1816a8"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7de0b007367392af1d1ee0c381d2d0c87c518607","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            name: tempest-bin"},{"line_number":115,"context_line":"            defaultMode: 0555"},{"line_number":116,"context_line":"        - name: tempest-reports"},{"line_number":117,"context_line":"        {{- if eq .Values.conf.storage \"pvc\" }}"},{"line_number":118,"context_line":"          persistentVolumeClaim:"},{"line_number":119,"context_line":"            claimName: {{ .Values.pvc.name }}"},{"line_number":120,"context_line":"        {{- else if eq .Values.conf.storage \"local\" }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"e8064eff_4443d0ea","line":117,"updated":"2024-11-13 21:49:37.000000000","message":"This looks good because if pvc is disabled helm will fail to deploy because pvc will not be rendered and there will be error.","commit_id":"d88e3216f0589998938390c11b6135305f4f41b1"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d9f9bb205a8c43727375ad46f19eb132a5767691","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            defaultMode: 0555"},{"line_number":116,"context_line":"        - name: tempest-reports"},{"line_number":117,"context_line":"        {{- if not .Values.pvc.enabled }}"},{"line_number":118,"context_line":"          emptyDir: {}"},{"line_number":119,"context_line":"        {{- else }}"},{"line_number":120,"context_line":"          persistentVolumeClaim:"},{"line_number":121,"context_line":"            claimName: {{ .Values.pvc.name }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e007fc70_85331fc1","side":"PARENT","line":118,"range":{"start_line":118,"start_character":9,"end_line":118,"end_character":22},"updated":"2024-11-25 18:50:25.000000000","message":"I think we can store results on host in /var/lib/tempest directory like we do it for other services when pvc is not enabled.","commit_id":"a556dbe2320faf28a6badc6869002970c9082c99"}]}