)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f10d64561166b9d63ae14da0c656efeea5955a20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b3e2fbf9_39d092fd","updated":"2024-12-08 10:44:28.000000000","message":"recheck","commit_id":"0b7d682fecc654aef6f306596050e6ad73e4edd9"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"710e7e7f20d7ab5e33fb8896d101c6ad7fdce148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"11c074ed_8fea86e2","updated":"2024-12-11 11:18:53.000000000","message":"this will not pass as one of jobs has missing values.","commit_id":"0b7d682fecc654aef6f306596050e6ad73e4edd9"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e69c7d6224daa9d8ce8ef04dc78a45c450931733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd201203_4b558a55","updated":"2024-12-16 18:49:26.000000000","message":"recheck","commit_id":"f725ff439016458de0d8c73153cc2c105ddbe27f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"36a8441e7e7cc9e893a2ad1737000e37d9840a52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3fb54432_d9ba260f","updated":"2025-01-24 15:43:09.000000000","message":"recheck","commit_id":"5a3f2080c12bb56238b150c69a06064c64d61d0f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"04656ed4e58d6c3de3f5a0d392632072804504fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"caf69c10_e590b065","updated":"2025-01-24 12:57:01.000000000","message":"recheck","commit_id":"5a3f2080c12bb56238b150c69a06064c64d61d0f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"375844abdd0ed700c046ad7933315cee514c4f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d97cc08a_2a7636d6","updated":"2025-01-24 19:26:19.000000000","message":"recheck","commit_id":"5a3f2080c12bb56238b150c69a06064c64d61d0f"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f1b4999d3431e3f5a3d4d1b8b630e0d87430835c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ee64f2cf_ad436707","updated":"2025-01-27 08:51:14.000000000","message":"recheck","commit_id":"5a3f2080c12bb56238b150c69a06064c64d61d0f"}],"cinder/templates/ingress-api.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0cbd688eb09805ba8cd9ecae3729842547a203fc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendService\" \"api\" \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volume.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a5051884_e3facb5e","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":64},"updated":"2024-12-08 10:44:18.000000000","message":"nit: its a default, no need to specify explicitly.","commit_id":"0b7d682fecc654aef6f306596050e6ad73e4edd9"},{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"ed9e67404cde71b3de13cd16fcc0c4c5a497940e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendService\" \"api\" \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volume.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"4bc745a4_d7077f47","line":17,"range":{"start_line":17,"start_character":42,"end_line":17,"end_character":64},"in_reply_to":"a5051884_e3facb5e","updated":"2025-01-02 15:05:58.000000000","message":"Done","commit_id":"0b7d682fecc654aef6f306596050e6ad73e4edd9"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d874cc7cbd16668ba351cd5922811ae2bca128dc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volumev3.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4ce3b098_ea7bdb56","line":17,"updated":"2025-01-17 13:27:42.000000000","message":"looks like this is the only line needed to fix the ingress","commit_id":"f14a232afbbc02bdc36c2af984a0a727468782e0"},{"author":{"_account_id":34112,"name":"Kaloyan Kotlarski","email":"kaloyan.kotlarski@storpool.com","username":"kkotlarski"},"change_message_id":"da11073d5821ef86f4b3e12795de8e60c562eb9d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volumev3.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"4ea45111_cc4fbb62","line":17,"in_reply_to":"0ce52da1_e60f0b7d","updated":"2025-01-21 12:57:36.000000000","message":"I disagree on this one. The TLS setup fails without changing all the files; a simple \"helm install—-dry-run\" is enough to verify it.","commit_id":"f14a232afbbc02bdc36c2af984a0a727468782e0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1d3577f25ccda2f3bcf69f37cde767eaa2c6a5e2","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volumev3.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0ce52da1_e60f0b7d","line":17,"in_reply_to":"4ce3b098_ea7bdb56","updated":"2025-01-18 12:50:56.000000000","message":"++","commit_id":"f14a232afbbc02bdc36c2af984a0a727468782e0"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1d2bba24475b23b1dce0558ce76f759f6106281f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if and .Values.manifests.ingress_api .Values.network.api.ingress.public }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . -}}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" $envAll \"backendServiceType\" \"volumev3\" \"backendPort\" \"c-api\" -}}"},{"line_number":18,"context_line":"{{- $secretName :\u003d $envAll.Values.secrets.tls.volumev3.api.internal -}}"},{"line_number":19,"context_line":"{{- if and .Values.manifests.certificates $secretName -}}"},{"line_number":20,"context_line":"{{- $_ :\u003d set $ingressOpts \"certIssuer\" .Values.endpoints.volume.host_fqdn_override.default.tls.issuerRef.name -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e8624e48_44fc32c7","line":17,"in_reply_to":"4ea45111_cc4fbb62","updated":"2025-01-21 20:11:18.000000000","message":"You are right. Thanks.","commit_id":"f14a232afbbc02bdc36c2af984a0a727468782e0"}]}