)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"change_message_id":"407bd6d611a7e2f979f99c42d522648ab04d5c9c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d317749_6ed1272e","updated":"2024-12-10 20:49:09.000000000","message":"I think it\u0027s `/healthcheck` (no trailing slash) and not `/healthcheck/` (trailing slash)\n\nhttps://docs.openstack.org/keystone/latest/admin/health-check-middleware.html","commit_id":"5dbfeb962a0137fd04bfaf2664dc007fef7d14bc"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d4fccd488801e5403f7fa75d023db892a1f8d19b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0732517_93d1e76a","in_reply_to":"1d317749_6ed1272e","updated":"2024-12-10 23:28:28.000000000","message":"Done","commit_id":"5dbfeb962a0137fd04bfaf2664dc007fef7d14bc"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1e7f8363f31d518a3927c7e67a0cb4012085d878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa62b819_cdd31cd5","updated":"2025-01-30 19:20:11.000000000","message":"recheck","commit_id":"1ecc9eac1675252c0af888106a3759e0a4f42cc1"}],"keystone/templates/deployment-api.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6ab6a537989bff649d0c362e438929eaca74610b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4371370_4414516c","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"updated":"2024-12-11 11:18:21.000000000","message":"having this middleware is not forced and may be disabled in api.paste. Maybe better to add another endpoint\n```\nidentity:\n  path:\n    healhcheck:  /healhcheck\n    default: /v3\n  ..\n```  \nand there set the exact path you want to ceck v2/v3 or healthcheck depending on your needs.","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"38b0fc5df4d0ff27482b5dd22af8b630d0ef3c99","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d9fb6ee7_886ba9d5","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"in_reply_to":"4f3a0b28_03b7a506","updated":"2024-12-17 15:49:53.000000000","message":"We did the same here [1]. This default url does not seem to change in any foreseeable future.   \n\nAnyway we have plenty of such places where healthcheck url is hardcoded (e.g. [2]). This PR doesn\u0027t make it worse. If we want it to be configurable in the values.yaml let\u0027s make it consistent with the same default with a helm-toolkit template. I would suggest to not block this contribution but instead to kindly request to contribute the HTK template that makes it configurable.\n\n[1] https://review.opendev.org/c/openstack/openstack-helm/+/934104/3/glance/templates/deployment-api.yaml\n[2] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/deployment-api-osapi.yaml#L18","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"22f429628e3586500fd35d30f4ed277d0adf5678","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d5e1480_0171ddc9","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"in_reply_to":"71ee0b0f_c78452ff","updated":"2025-01-30 05:07:30.000000000","message":"Done","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"92ff5ac73228fb26009fccbd4fac0e0aa19bf712","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4f3a0b28_03b7a506","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"in_reply_to":"83c0965e_163e3df7","updated":"2024-12-12 08:15:15.000000000","message":"Api paste was removed, you are right https://review.opendev.org/c/openstack/keystone/+/427878 but it still possible to disable this midleware https://docs.openstack.org/oslo.middleware/latest/reference/healthcheck_plugins.html#available-plugins\n\nWe have a way to pass this helthcheck endpoint from .Values.endpoints.identity. And I do not see any reason to keep it hardcoded. We can set default value to /healthcheck but it should not be hardcoded here.","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d23137797ba13d12cd9e81dab36ddd9781a82909","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83c0965e_163e3df7","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"in_reply_to":"c4371370_4414516c","updated":"2024-12-11 18:24:19.000000000","message":"Half a dozen existing services use /healthcheck exclusively. OpenStack Helm\u0027s Keystone doesn\u0027t use paste so there\u0027s no ability to disable it via paste.","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"65a26b83ceffe09e942e4bceaa2ef293b1d12285","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"apiProbeTemplate\" }}"},{"line_number":16,"context_line":"httpGet:"},{"line_number":17,"context_line":"  scheme: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":18,"context_line":"  path: /healthcheck"},{"line_number":19,"context_line":"  port: {{ tuple \"identity\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"71ee0b0f_c78452ff","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":20},"in_reply_to":"d9fb6ee7_886ba9d5","updated":"2024-12-18 08:27:03.000000000","message":"I\u0027ve fixed places where we use /healthcheck endpoint https://review.opendev.org/c/openstack/openstack-helm/+/937960, lets rebase this patch and implement correct approach.","commit_id":"ce71c3ee7021de449b7e8c08e01ea734fb071d80"}]}