)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7dc079710e3c7571366da912b10d75282e2932ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9a90029_6659d444","updated":"2024-12-19 00:24:17.000000000","message":"I think this will have issues with people using the tls overrides and then the path isn\u0027t fixed up for glance.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a7013be26c957ff6c296387e4641bfa2c14f2c1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"190c1696_1c1068c8","updated":"2024-12-21 15:34:37.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"24caaa755825ed7307725f5157be3ed98d371e45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19529f5d_a9742bdb","updated":"2024-12-20 06:27:44.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"75b539445870f6c0b5a549721ba9d6827f8abc9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2b3035d7_ca229f16","updated":"2024-12-20 11:31:19.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ba74a6a4b3f02c02881f78b3231a4d6482f8df22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4a0c686c_6a5ff9d1","updated":"2024-12-20 18:01:40.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3ef4d85e3e19df5bbc8d34be69e56e5efd6285cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e8d1b9a_00537c1c","updated":"2024-12-19 15:43:14.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c586d21f34ea0f333ece3543f12705a4322bd00c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"740d7d90_c4a1709a","updated":"2024-12-20 09:16:17.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1f0533c1ba5857c396565a26a2c8a154aaa5937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"96010cc2_a2b367d8","updated":"2024-12-19 20:10:06.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d73a43bc1464cac9b3b838ba69c2f94a7f3a874f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a857a596_af914006","updated":"2024-12-20 14:25:08.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bdcd7ebedb3042cf3887d68a4517f16a5ac10c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf2624ea_9cc21e41","updated":"2024-12-19 13:25:34.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9e18d8a43e70fde076d493983d9d923b45550711","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d805a8fb_a13f44bb","updated":"2024-12-19 17:55:05.000000000","message":"recheck","commit_id":"471767523fdc41e57e362a7bec51135f486ad5bb"}],"barbican/templates/deployment-api.yaml":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7dc079710e3c7571366da912b10d75282e2932ad","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"probeTemplate\" }}"},{"line_number":16,"context_line":"{{- $health_path :\u003d tuple \"key_manager\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":17,"context_line":"httpGet:"},{"line_number":18,"context_line":"  scheme: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":19,"context_line":"  path: {{ $health_path }}"},{"line_number":20,"context_line":"  port: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":21,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3349de66_65e9dede","line":18,"updated":"2024-12-19 00:24:17.000000000","message":"How will this work when people use tls override files which set the scheme to https? The certificates might not be available in that case. Which leads to configurations like found in the neutron deployment-server.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4f49a2b17e864e873ba5963f3f806c8cb95e9a0e","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"probeTemplate\" }}"},{"line_number":16,"context_line":"{{- $health_path :\u003d tuple \"key_manager\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":17,"context_line":"httpGet:"},{"line_number":18,"context_line":"  scheme: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":19,"context_line":"  path: {{ $health_path }}"},{"line_number":20,"context_line":"  port: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":21,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c545edd1_c04f51c2","line":18,"in_reply_to":"303f206c_f54e2450","updated":"2024-12-19 08:07:24.000000000","message":"kubernetes ignore certificate validation https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#http-probes","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0925b44474666bc4addd1f84f795721bb0eb9910","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{{- define \"probeTemplate\" }}"},{"line_number":16,"context_line":"{{- $health_path :\u003d tuple \"key_manager\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":17,"context_line":"httpGet:"},{"line_number":18,"context_line":"  scheme: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":19,"context_line":"  path: {{ $health_path }}"},{"line_number":20,"context_line":"  port: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":21,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"303f206c_f54e2450","line":18,"in_reply_to":"3349de66_65e9dede","updated":"2024-12-19 06:59:59.000000000","message":"yes, it may be. But it is how its done right now. We may fix tls support in barbican in separate patch.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8aad800950b5f35878a469ea3c68384c89c90716","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{{- define \"probeTemplate\" }}"},{"line_number":16,"context_line":"{{- $health_path :\u003d tuple \"key_manager\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":17,"context_line":"httpGet:"},{"line_number":18,"context_line":"  scheme: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":19,"context_line":"  path: {{ $health_path }}"},{"line_number":20,"context_line":"  port: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":21,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"636e3f5a_d1cd89a6","line":18,"in_reply_to":"364dfb86_1c5ae7e6","updated":"2024-12-19 10:50:14.000000000","message":"I dig a bit more, in case of TLS we deploy sidecar container with nginx on POD_IP, but bind glance to 127.0.0.1. Exec probe is used because its not possible to do HTTP probe to 127.0.0.1 its done to POD_IP. Its not due to certificates.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c40ac208d3e88c0b51c888f430d4325929c716ea","unresolved":false,"context_lines":[{"line_number":15,"context_line":"{{- define \"probeTemplate\" }}"},{"line_number":16,"context_line":"{{- $health_path :\u003d tuple \"key_manager\" \"healthcheck\" \"internal\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":17,"context_line":"httpGet:"},{"line_number":18,"context_line":"  scheme: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"},{"line_number":19,"context_line":"  path: {{ $health_path }}"},{"line_number":20,"context_line":"  port: {{ tuple \"key_manager\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":21,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"364dfb86_1c5ae7e6","line":18,"in_reply_to":"c545edd1_c04f51c2","updated":"2024-12-19 08:07:36.000000000","message":"Done","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"}],"glance/templates/deployment-api.yaml":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"7dc079710e3c7571366da912b10d75282e2932ad","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  command:"},{"line_number":20,"context_line":"    - python"},{"line_number":21,"context_line":"    - -c"},{"line_number":22,"context_line":"    - \"import requests; requests.get(\u0027http://127.0.0.1:{{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\u0027)\""},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"httpGet:"},{"line_number":25,"context_line":"  scheme: {{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"60b40fc5_099d43eb","line":22,"updated":"2024-12-19 00:24:17.000000000","message":"You\u0027re adjusting the path lookup above but not here.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4f49a2b17e864e873ba5963f3f806c8cb95e9a0e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  command:"},{"line_number":20,"context_line":"    - python"},{"line_number":21,"context_line":"    - -c"},{"line_number":22,"context_line":"    - \"import requests; requests.get(\u0027http://127.0.0.1:{{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\u0027)\""},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"httpGet:"},{"line_number":25,"context_line":"  scheme: {{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a82f50f7_220da705","line":22,"in_reply_to":"01d9bed9_233151db","updated":"2024-12-19 08:07:24.000000000","message":"drop this part completely as kubernetes ignore certificate validation https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#http-probes","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"0925b44474666bc4addd1f84f795721bb0eb9910","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  command:"},{"line_number":20,"context_line":"    - python"},{"line_number":21,"context_line":"    - -c"},{"line_number":22,"context_line":"    - \"import requests; requests.get(\u0027http://127.0.0.1:{{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\u0027)\""},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"httpGet:"},{"line_number":25,"context_line":"  scheme: {{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"01d9bed9_233151db","line":22,"in_reply_to":"60b40fc5_099d43eb","updated":"2024-12-19 06:59:59.000000000","message":"here path is not included at all right now, so people who use tls do not use /healthcheck endpint, but let me fix this here as well.","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c40ac208d3e88c0b51c888f430d4325929c716ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  command:"},{"line_number":20,"context_line":"    - python"},{"line_number":21,"context_line":"    - -c"},{"line_number":22,"context_line":"    - \"import requests; requests.get(\u0027http://127.0.0.1:{{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}\u0027)\""},{"line_number":23,"context_line":"{{- else }}"},{"line_number":24,"context_line":"httpGet:"},{"line_number":25,"context_line":"  scheme: {{ tuple \"image\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_scheme_lookup\" | upper }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"12fb89f5_d0215158","line":22,"in_reply_to":"a82f50f7_220da705","updated":"2024-12-19 08:07:36.000000000","message":"Done","commit_id":"6d8afc83cfdf08ce4124de76f0bfc7658b176aec"}]}