)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"44067ba8c82a46d34d45d006c40646b0965661e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"72a9f7a3_299f88fa","updated":"2025-02-27 07:25:19.000000000","message":"I\u0027m not sure that we have build dependencies between jobs. It means that job that checks linting is executed separately. I do not know if it is possible to build chart with broken lint (if yes) then by removing linting broken chart will be packaged and failed on deployment stage. So de facto instead of saving resources we will waste even more. I do not think that linting is super heavy operation that we need try to optimize something.","commit_id":"27f6701e87b1e082087871c2f165790d17212e9e"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"43af68da350c0cd8aceaaf1e5cdc09932081f283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"817c6980_a8e85715","updated":"2025-02-27 17:12:25.000000000","message":"recheck","commit_id":"27f6701e87b1e082087871c2f165790d17212e9e"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f7e88211bc1a0644da4fde19962849b5d5a2c5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"86cfdf6f_45232a4a","in_reply_to":"72a9f7a3_299f88fa","updated":"2025-02-27 16:57:07.000000000","message":"Linting isn\u0027t heavy, but not necessary when you build charts for deployment tests and not going to publish them. But SKIP_LINT option is set to 0 by default, so the linting will be skipped if only you explicitly set it SKIP_LINT\u003d1","commit_id":"27f6701e87b1e082087871c2f165790d17212e9e"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9cdd591950514aa2caa2a5f1fa33e408081ad841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"949b7737_948e7ddb","in_reply_to":"86cfdf6f_45232a4a","updated":"2025-02-28 06:41:04.000000000","message":"My point is that linting  allows to catch errors earlier if they exists. If broken chart we can\u0027t build its ok, if we can build broken chart it means we fail later at installtion stage\n\n```\nmariadb# helm3 package .\nSuccessfully packaged chart and saved it to: /root/rockoon/charts/infra/mariadb/mariadb-0.1.0.tgz\n\nmariadb# helm3 lint\n\u003d\u003d\u003e Linting .\n[ERROR] templates/: template: mariadb/templates/statefulset.yaml:215:98: executing \"mariadb/templates/statefulset.yaml\" at \u003cinclude \"mariadbReadinessProbe\" $envAll\u003e: error calling include: template: no template \"mariadbReadinessProbe\" associated with template \"gotpl\"\n\nError: 1 chart(s) linted, 1 chart(s) failed\n```\n\nAs you can see we can package broken chart it means that deployment job will continue running unless it reaches to installation phase and fail much later that it can with helm lint.\n\nAlso I would suggest to extend linting and add values that we are going to use in deployment job to lint command to test chart rendering in more sophisticated cases.","commit_id":"27f6701e87b1e082087871c2f165790d17212e9e"}]}