)]}'
{"manila/templates/deployment-api.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ee5316f2b162ea5175dfa9a82bb3b491818726d3","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: /healthcheck"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"132acba5_7c350a3e","line":85,"updated":"2025-03-11 20:10:57.000000000","message":"Can we do here the same as https://review.opendev.org/c/openstack/openstack-helm/+/937472/3/keystone/templates/deployment-api.yaml ?","commit_id":"8ebef554ef5ccccfc44ef3801c1af8e8ca860569"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"1f276ee8cf2a99b9a8c3a6f06a3f9c449a0996ad","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: /healthcheck"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"69168741_9cde2d96","line":85,"in_reply_to":"132acba5_7c350a3e","updated":"2025-03-12 05:58:23.000000000","message":"Yes, it is possible, But the user needs to add additional settings to values.yaml. Should I change it like this?\n`path: {{ tuple \"share\" \"healthcheck\" \"\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}`","commit_id":"8ebef554ef5ccccfc44ef3801c1af8e8ca860569"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dd5ecf96419e6496e8973510ad974d9ef8475e91","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: /healthcheck"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"95f9b9ae_dc40c8bd","line":85,"in_reply_to":"69168741_9cde2d96","updated":"2025-03-14 13:55:55.000000000","message":"++","commit_id":"8ebef554ef5ccccfc44ef3801c1af8e8ca860569"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"93b9719afc061b91052490c6a556878e0af49eea","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: /healthcheck"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5e84f1c4_a14a43e4","line":85,"in_reply_to":"95f9b9ae_dc40c8bd","updated":"2025-03-17 04:18:04.000000000","message":"I changed the code. thanks.","commit_id":"8ebef554ef5ccccfc44ef3801c1af8e8ca860569"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"45ca4a1c773448c25a0365390a5b989fb5778f60","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: {{ tuple \"share\" \"healthcheck\" \"\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"8e17e6e0_a04e07be","line":85,"updated":"2025-03-17 17:05:48.000000000","message":"Also you have to add the healthcheck key to the endpoint where you lookup for the path. See for example here https://opendev.org/openstack/openstack-helm/src/branch/master/keystone/values.yaml#L978 . You can check the result of templating using the command `helm template manila ./manila`","commit_id":"a8f374f9250410d2c7a7c86c2022cd51de7565b7"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"c689655b9c894a509bd0943c95cfa382dfb56962","unresolved":true,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            httpGet:"},{"line_number":84,"context_line":"              scheme: HTTP"},{"line_number":85,"context_line":"              path: {{ tuple \"share\" \"healthcheck\" \"\" . | include \"helm-toolkit.endpoints.keystone_endpoint_path_lookup\" }}"},{"line_number":86,"context_line":"              port: {{ tuple \"share\" \"service\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":87,"context_line":"          volumeMounts:"},{"line_number":88,"context_line":"            - name: pod-tmp"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c1dad059_6e5e0c5b","line":85,"in_reply_to":"8e17e6e0_a04e07be","updated":"2025-03-18 07:19:00.000000000","message":"I added values.yaml healthcheck key and checked the result.\n```\n          readinessProbe:\n            httpGet:\n              scheme: HTTP\n              path: /healthcheck\n              port: 8786\n```","commit_id":"a8f374f9250410d2c7a7c86c2022cd51de7565b7"}]}
