)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dcebd75b9cfeb6a1ce364344037af36e12a39182","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow multiple Barbican Key Encryption Key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Barbican moved to support multiple keks instead of just one."},{"line_number":10,"context_line":"OpenStack-helm is failing if run againist Barbican after commit [1]."},{"line_number":11,"context_line":"This patch allows specify multiple and fix compatible issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] cfba1c1ba8f3659e6de727c3f1c274052e9ccace"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"53d6cbf9_a5651506","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":67},"updated":"2025-03-20 07:19:17.000000000","message":"can you please report a bug and add traces from barbican how its failing? At first look this patch is fully backward compatible and works with 1 key.","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"cd42d7d4e187e1f78c7587ffbe4a3fab8a287ef7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow multiple Barbican Key Encryption Key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Barbican moved to support multiple keks instead of just one."},{"line_number":10,"context_line":"OpenStack-helm is failing if run againist Barbican after commit [1]."},{"line_number":11,"context_line":"This patch allows specify multiple and fix compatible issue."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] cfba1c1ba8f3659e6de727c3f1c274052e9ccace"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"f31ecebd_3291b0f9","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":67},"in_reply_to":"53d6cbf9_a5651506","updated":"2025-03-21 03:42:25.000000000","message":"added and explained in https://bugs.launchpad.net/openstack-helm/+bug/2103757","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"348d0dfd2ad384b242da9195f859dd7ef5ab77b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2690c50_a8fae488","updated":"2025-03-20 02:29:57.000000000","message":"just update a small nit","commit_id":"e5525e0c0cca99dbeff64805182d80644bc9474b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"3b745e6f2f25df46ab6a355a392d4e0fa0ff3b2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"028c019c_872dd6d1","updated":"2025-03-25 18:59:59.000000000","message":"recheck","commit_id":"73cdac6019ebd0363e14d05f2655b243519afeed"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"a88389c629d528e1bd1941a511c4109c8f73082d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e6f1b38b_2f340713","updated":"2025-03-25 20:47:33.000000000","message":"recheck","commit_id":"73cdac6019ebd0363e14d05f2655b243519afeed"}],"barbican/templates/bin/_simple_crypto_kek_rewrap.py.tpl":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dcebd75b9cfeb6a1ce364344037af36e12a39182","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        \u0027--old-keks\u0027,"},{"line_number":155,"context_line":"        default\u003d\"[\u0027dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\u0027]\","},{"line_number":156,"context_line":"        help\u003d\u0027Old key encryption keys previously used by Simple Crypto Plugin. \u0027"},{"line_number":157,"context_line":"             \u0027A list of keys (32 bytes, base64-encoded).\u0027"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    args \u003d parser.parse_args()"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"92e523a4_26ac0b7a","line":157,"range":{"start_line":157,"start_character":55,"end_line":157,"end_character":56},"updated":"2025-03-20 07:19:17.000000000","message":"Please add that first is used for encryption and others for decryption.","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"cd42d7d4e187e1f78c7587ffbe4a3fab8a287ef7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        \u0027--old-keks\u0027,"},{"line_number":155,"context_line":"        default\u003d\"[\u0027dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\u0027]\","},{"line_number":156,"context_line":"        help\u003d\u0027Old key encryption keys previously used by Simple Crypto Plugin. \u0027"},{"line_number":157,"context_line":"             \u0027A list of keys (32 bytes, base64-encoded).\u0027"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    args \u003d parser.parse_args()"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"c1f1ad36_397a5119","line":157,"range":{"start_line":157,"start_character":55,"end_line":157,"end_character":56},"in_reply_to":"92e523a4_26ac0b7a","updated":"2025-03-21 03:42:25.000000000","message":"Done","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dcebd75b9cfeb6a1ce364344037af36e12a39182","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    args \u003d parser.parse_args()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    rewrapper \u003d KekRewrap(CONF, args.old_keks.split(\",\"))"},{"line_number":162,"context_line":"    rewrapper.execute(args.dry_run)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"f7ee67c5_f9103380","line":161,"range":{"start_line":161,"start_character":32,"end_line":161,"end_character":56},"updated":"2025-03-20 07:19:17.000000000","message":"it seems we expecte comma separated strings here, but on L155 default is json list.","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"cd42d7d4e187e1f78c7587ffbe4a3fab8a287ef7","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    args \u003d parser.parse_args()"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    rewrapper \u003d KekRewrap(CONF, args.old_keks.split(\",\"))"},{"line_number":162,"context_line":"    rewrapper.execute(args.dry_run)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"668ebff8_824bb41c","line":161,"range":{"start_line":161,"start_character":32,"end_line":161,"end_character":56},"in_reply_to":"f7ee67c5_f9103380","updated":"2025-03-21 03:42:25.000000000","message":"Done","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"}],"barbican/templates/configmap-etc.yaml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"12372ead8e647f06067cbb62b793a913c3a8c3e8","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  api_audit_map.conf: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.audit_map | b64enc }}"},{"line_number":99,"context_line":"  policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":100,"context_line":"  barbican-api-uwsgi.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.barbican_api_uwsgi | b64enc }}"},{"line_number":101,"context_line":"  old_keks: {{ index .Values.conf.simple_crypto_kek_rewrap \"old_kek\" | default \"\" ) | b64enc | quote }}"},{"line_number":102,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bcec926c_1bb20ed2","line":101,"range":{"start_line":101,"start_character":82,"end_line":101,"end_character":84},"updated":"2025-03-25 15:12:25.000000000","message":"I think this is the cause of the failure.","commit_id":"1b29553fb671c9f0a714f9f077413cf31de29b83"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"1c375adb28c9f1e8b0cd4c78a2d02c82164a9782","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  api_audit_map.conf: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.audit_map | b64enc }}"},{"line_number":99,"context_line":"  policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":100,"context_line":"  barbican-api-uwsgi.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.barbican_api_uwsgi | b64enc }}"},{"line_number":101,"context_line":"  old_keks: {{ index .Values.conf.simple_crypto_kek_rewrap \"old_kek\" | default \"\" ) | b64enc | quote }}"},{"line_number":102,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6dc431a2_68fe9a50","line":101,"range":{"start_line":101,"start_character":82,"end_line":101,"end_character":84},"in_reply_to":"bcec926c_1bb20ed2","updated":"2025-03-25 17:30:49.000000000","message":"Done","commit_id":"1b29553fb671c9f0a714f9f077413cf31de29b83"}],"barbican/values.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"dcebd75b9cfeb6a1ce364344037af36e12a39182","unresolved":true,"context_lines":[{"line_number":450,"context_line":"    # The KEK value \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\" matches the"},{"line_number":451,"context_line":"    # plugin default, and is retained here for convenience, in case the chart was"},{"line_number":452,"context_line":"    # previously installed without explicitly specifying a kek."},{"line_number":453,"context_line":"    old_keks:"},{"line_number":454,"context_line":"      - \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":455,"context_line":"  logging:"},{"line_number":456,"context_line":"    loggers:"},{"line_number":457,"context_line":"      keys:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ab465bf0_3132ec34","line":454,"range":{"start_line":453,"start_character":4,"end_line":454,"end_character":54},"updated":"2025-03-20 07:19:17.000000000","message":"its going to be a breaking change, why we can\u0027t use `old_kek` and describe that it accepts comma separated strings with keks or add `keks` option here but always fallback to old_keks when specified","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"cd42d7d4e187e1f78c7587ffbe4a3fab8a287ef7","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    # The KEK value \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\" matches the"},{"line_number":451,"context_line":"    # plugin default, and is retained here for convenience, in case the chart was"},{"line_number":452,"context_line":"    # previously installed without explicitly specifying a kek."},{"line_number":453,"context_line":"    old_keks:"},{"line_number":454,"context_line":"      - \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":455,"context_line":"  logging:"},{"line_number":456,"context_line":"    loggers:"},{"line_number":457,"context_line":"      keys:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"b2d03ba8_4d0fcd03","line":454,"range":{"start_line":453,"start_character":4,"end_line":454,"end_character":54},"in_reply_to":"ab465bf0_3132ec34","updated":"2025-03-21 03:42:25.000000000","message":"Let me add old_kek as default if old_keks not specify","commit_id":"680fd04e0da0acd95152a4133f37edcff7cab367"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1133e293d72a6d2c4766b1347f6c10baf4217684","unresolved":true,"context_lines":[{"line_number":449,"context_line":"    # The KEK value \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\" matches the"},{"line_number":450,"context_line":"    # plugin default, and is retained here for convenience, in case the chart was"},{"line_number":451,"context_line":"    # previously installed without explicitly specifying a kek."},{"line_number":452,"context_line":"    # old_keks:"},{"line_number":453,"context_line":"    #   # First key is used for ecnrypting new data"},{"line_number":454,"context_line":"    #   - \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":455,"context_line":"    #   # Additional keys used for decrypting existing data"},{"line_number":456,"context_line":"    #   - \"dDDpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":457,"context_line":"    # For backward compatible, one can also specify old_kek that will be use if"},{"line_number":458,"context_line":"    # old_keks not provided."},{"line_number":459,"context_line":"    old_kek: \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"caadb400_bd37a650","line":456,"range":{"start_line":452,"start_character":4,"end_line":456,"end_character":56},"updated":"2025-03-21 12:24:56.000000000","message":"do we really need a list here? we convert it to comma separated string later. Why not just use same format here? And if yes do we really need old_kek`S` and why we can\u0027t just use old_kek as a comma separted string?","commit_id":"cebcfa0db628d543c4f3f41d61fcc19b3a7e45e9"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"f82bc1d8a1036ea3f10b6c3fff63a30c96bf36e8","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    # The KEK value \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\" matches the"},{"line_number":450,"context_line":"    # plugin default, and is retained here for convenience, in case the chart was"},{"line_number":451,"context_line":"    # previously installed without explicitly specifying a kek."},{"line_number":452,"context_line":"    # old_keks:"},{"line_number":453,"context_line":"    #   # First key is used for ecnrypting new data"},{"line_number":454,"context_line":"    #   - \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":455,"context_line":"    #   # Additional keys used for decrypting existing data"},{"line_number":456,"context_line":"    #   - \"dDDpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""},{"line_number":457,"context_line":"    # For backward compatible, one can also specify old_kek that will be use if"},{"line_number":458,"context_line":"    # old_keks not provided."},{"line_number":459,"context_line":"    old_kek: \"dGhpcnR5X3R3b19ieXRlX2tleWJsYWhibGFoYmxhaGg\u003d\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7d93e1a6_33d5dbe4","line":456,"range":{"start_line":452,"start_character":4,"end_line":456,"end_character":56},"in_reply_to":"caadb400_bd37a650","updated":"2025-03-24 07:04:00.000000000","message":"I\u0027m okay to use old_kek for both","commit_id":"cebcfa0db628d543c4f3f41d61fcc19b3a7e45e9"}]}