)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"a73d900c4322c2b171a73a8ed5a1cc774dba925c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae36e312_2fdb166d","updated":"2025-03-25 20:28:41.000000000","message":"Please add the release note for the change.\n```\nreno new nova\n```\nThen edit the file releasenotes/notes/nova-\u003chash\u003e.yaml and describe the change.","commit_id":"39613a80a88826dfa025ea54e028136cdf62c4f1"}],"nova/templates/job-cell-setup.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b82f3a80e7dfc715763571f6619b88b3ac1e67f3","unresolved":true,"context_lines":[{"line_number":26,"context_line":"{{ tuple $envAll \"nova\" \"cell-setup\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":27,"context_line":"  annotations:"},{"line_number":28,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":29,"context_line":"{{- if (((.Values.annotations).job).nova_cell_setup) }}"},{"line_number":30,"context_line":"{{- with .Values.annotations.job.nova_cell_setup }}"},{"line_number":31,"context_line":"{{ toYaml . | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"525fe10a_0c642028","line":29,"updated":"2025-03-25 21:28:56.000000000","message":"Please use custom_job_annotations snippet [1]. See example here [2].\n\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/helm-toolkit/templates/snippets/_custom_job_annotations.tpl\n[2] https://opendev.org/openstack/openstack-helm/src/branch/master/keystone/templates/job-credential-setup.yaml#L65","commit_id":"3eb29aca946222b7dc20b90d087f46857c266032"},{"author":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"change_message_id":"2729542e6782eba0246efebd97b09df298681316","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{ tuple $envAll \"nova\" \"cell-setup\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":27,"context_line":"  annotations:"},{"line_number":28,"context_line":"    {{ tuple $envAll | include \"helm-toolkit.snippets.release_uuid\" }}"},{"line_number":29,"context_line":"{{- if (((.Values.annotations).job).nova_cell_setup) }}"},{"line_number":30,"context_line":"{{- with .Values.annotations.job.nova_cell_setup }}"},{"line_number":31,"context_line":"{{ toYaml . | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6af196e0_26439a3d","line":29,"in_reply_to":"525fe10a_0c642028","updated":"2025-03-26 17:36:49.000000000","message":"Thanks for the suggestion. This looks much cleaner.","commit_id":"3eb29aca946222b7dc20b90d087f46857c266032"}],"releasenotes/notes/nova-b0749b6144e2b871.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b82f3a80e7dfc715763571f6619b88b3ac1e67f3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"nova:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    I experienced a small issue where my custom job annotations for the"},{"line_number":5,"context_line":"    nova-cell-setup job weren\u0027t coming through in the resulting kubernetes"},{"line_number":6,"context_line":"    yaml manifests like they were for other jobs. I saw the nova-cell-setup"},{"line_number":7,"context_line":"    job doesn\u0027t seem to use the same template as the other nova jobs and it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6424bd1d_f594014c","line":4,"updated":"2025-03-25 21:28:56.000000000","message":"This will eventually come to the CHANGELOG.md file of the nova chart. To see how it looks use the commands\n\n```\nhelm repo add openstack-helm https://tarballs.opendev.org/openstack/openstack-helm/\nmkdir tmp\ncd tmp\nhelm pull openstack-helm/nova --untar --version 2024.2.7+e54398295\ncat nova/CHANGELOG.md\n```\n\nHaving said that I would recommend using a short phrase that briefly describes the change avoiding any personalization. I would say this should be enough\n\n```\nAdd custom annotations to the nova-cell-setup\n```","commit_id":"3eb29aca946222b7dc20b90d087f46857c266032"},{"author":{"_account_id":6799,"name":"Nicholas Kuechler","email":"nkuechler@gmail.com","username":"nicholaskuechler"},"change_message_id":"2729542e6782eba0246efebd97b09df298681316","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"nova:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    I experienced a small issue where my custom job annotations for the"},{"line_number":5,"context_line":"    nova-cell-setup job weren\u0027t coming through in the resulting kubernetes"},{"line_number":6,"context_line":"    yaml manifests like they were for other jobs. I saw the nova-cell-setup"},{"line_number":7,"context_line":"    job doesn\u0027t seem to use the same template as the other nova jobs and it\u0027s"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ccf21e5e_176b91a7","line":4,"in_reply_to":"6424bd1d_f594014c","updated":"2025-03-26 17:36:49.000000000","message":"Acknowledged","commit_id":"3eb29aca946222b7dc20b90d087f46857c266032"}]}