)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6e3c429b66cf34f92ab509f1797fb4ae828391cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a249fd8_b88d4e05","updated":"2025-04-28 17:09:36.000000000","message":"Can you please clarify the motivation behind? The script uses transaction as \na context manager. So even if rewrap_kek fails at some point the transaction is rolled back, right? IMO it could make it even worse when you try to start a nested transaction when for some reason the previous one is not yet finished/rolled back.","commit_id":"559d486b77bb9827d9419df3a3525940a7af1e4a"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"55065f68f008697c9684c448b1cef27d3e1173d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f6252ece_fb763506","updated":"2025-04-23 01:11:39.000000000","message":"recheck","commit_id":"559d486b77bb9827d9419df3a3525940a7af1e4a"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"626fe12fb07dce57f31d0909594f6e3f1b382023","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fce6928b_b6fe4a3a","in_reply_to":"6a249fd8_b88d4e05","updated":"2025-05-28 08:27:54.000000000","message":"sorry for the late reply,\nHere is the original issue we face https://github.com/vexxhost/atmosphere/issues/2492\n\nIIUC, from the description in https://docs.sqlalchemy.org/en/20/orm/session_transaction.html#using-savepoint\n`BEGIN SAVEPOINT` will be trigger and flush all pending state. \nSo we should be fine with nested transaction, as all things are solid from SAVEPOINT (which nested transaction starts.)","commit_id":"559d486b77bb9827d9419df3a3525940a7af1e4a"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac2a238eb4189633d804c8b494d246e8552b91cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"354a94cc_aa29b9d1","in_reply_to":"fce6928b_b6fe4a3a","updated":"2025-05-29 17:17:38.000000000","message":"Thanks a lot for the details of the issue.","commit_id":"559d486b77bb9827d9419df3a3525940a7af1e4a"}]}
