)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1a8259dd2b41b33665e0766664ae5ecf17e13c06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3ff0fc4b_9c83c33f","updated":"2025-08-04 14:53:43.000000000","message":"Also please add the deployment job for Freezer chart. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/base.yaml#L446-L469 . The job is assumed to run a bunch of scripts that first deploy dependencies and then one of scripts will be for deployment of freezer itself.","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"13c91592_d41c88f2","updated":"2025-08-04 14:49:40.000000000","message":"Thanks for introducing the freezer chart. However in openstack-helm we try to follow the same code style in all of our charts. To make the code base more maintainable we put all repetitive things such as jobs definitions, ini files rendering, etc. to the Helm-toolkit chart.","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a1b1bf27_56356a52","in_reply_to":"3ff0fc4b_9c83c33f","updated":"2025-08-07 13:45:57.000000000","message":"Done","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1f78f2e9335a570502ab860ae0f522c24865fa22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"a36a0fda_ebcdd062","updated":"2025-08-21 11:26:46.000000000","message":"Please see how stuff is implemented in other charts and try to use same code style and same patterns.","commit_id":"582897e12e50bdd001385b1fd389f1f821fa6d36"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"acb293982c75f47d20e5e40e85dc57a1c155506f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b7677db4_ad720a70","updated":"2025-08-12 06:13:40.000000000","message":"Recheck","commit_id":"582897e12e50bdd001385b1fd389f1f821fa6d36"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c6781ec8_38e255b7","updated":"2025-08-07 13:45:57.000000000","message":"rekicking zuul build","commit_id":"582897e12e50bdd001385b1fd389f1f821fa6d36"}],"freezer/templates/_helpers.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1f78f2e9335a570502ab860ae0f522c24865fa22","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Common labels for this chart (freezer)."},{"line_number":3,"context_line":"Uses Kubernetes recommended labels."},{"line_number":4,"context_line":"Expected context: (dict \"context\" . \"component\" \"...\")"}],"source_content_type":"text/x-smarty","patch_set":22,"id":"18842426_75f6b3e8","line":1,"updated":"2025-08-21 11:26:46.000000000","message":"Please consider putting all these templates in dedicated files. Like for example we usually put script templates to the bin/_* files. See for example [1].\n\nMany templates are already defined in the helm-toolkit chart.\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/bin","commit_id":"582897e12e50bdd001385b1fd389f1f821fa6d36"}],"freezer/templates/configmap-bin.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    export HOME\u003d/tmp"},{"line_number":34,"context_line":"    {{ .Values.bootstrap.script | default \"echo \u0027No bootstrap script defined.\u0027\" }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  db-init.py: |"},{"line_number":37,"context_line":"    #!/usr/bin/env python"},{"line_number":38,"context_line":"    import logging"},{"line_number":39,"context_line":"    import os"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"c0fb3e99_dbf71265","line":36,"updated":"2025-08-04 14:49:40.000000000","message":"Please use helm-toolkit helper to render scripts. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/configmap-bin.yaml","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    export HOME\u003d/tmp"},{"line_number":34,"context_line":"    {{ .Values.bootstrap.script | default \"echo \u0027No bootstrap script defined.\u0027\" }}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  db-init.py: |"},{"line_number":37,"context_line":"    #!/usr/bin/env python"},{"line_number":38,"context_line":"    import logging"},{"line_number":39,"context_line":"    import os"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"70854d70_9205825e","line":36,"in_reply_to":"c0fb3e99_dbf71265","updated":"2025-08-07 13:45:57.000000000","message":"@kozhukalov@gmail.com - Didnt find any drop-in replacements (helm-toolkit equivalent) for dep-check.sh, bootstrap.sh, db-sync.sh, freezer-api.sh, freezer-scheduler.sh. Hence keeping them as it is. Is that fine?","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"}],"freezer/templates/configmap-etc.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"{{ include \"freezer.labels.standard\" (dict \"context\" . \"component\" \"bin\") | indent 4 }}"},{"line_number":9,"context_line":"data:"},{"line_number":10,"context_line":"  freezer.conf: |"},{"line_number":11,"context_line":"    # This is the main configuration file for OpenStack Freezer."},{"line_number":12,"context_line":"    # It includes settings for both the API and Scheduler components."},{"line_number":13,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"498df4fb_32b19fc5","line":10,"updated":"2025-08-04 14:49:40.000000000","message":"Please use the conf section in values.yaml to store configs and then render them using helm-toolkit helper. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/configmap-etc.yaml#L240","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  labels:"},{"line_number":8,"context_line":"{{ include \"freezer.labels.standard\" (dict \"context\" . \"component\" \"bin\") | indent 4 }}"},{"line_number":9,"context_line":"data:"},{"line_number":10,"context_line":"  freezer.conf: |"},{"line_number":11,"context_line":"    # This is the main configuration file for OpenStack Freezer."},{"line_number":12,"context_line":"    # It includes settings for both the API and Scheduler components."},{"line_number":13,"context_line":"    [DEFAULT]"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"715cfa35_cea04cac","line":10,"in_reply_to":"498df4fb_32b19fc5","updated":"2025-08-07 13:45:57.000000000","message":"Done","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"}],"freezer/templates/job-db-drop.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"67541064_0baf19f5","line":1,"updated":"2025-08-04 14:49:40.000000000","message":"Please use helm-toolkit helper. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-db-drop.yaml","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d0c9482b_89083430","line":1,"in_reply_to":"67541064_0baf19f5","updated":"2025-08-07 13:45:57.000000000","message":"Done","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"}],"freezer/templates/job-db-init.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9cd08a57_1c3cb6b4","line":1,"updated":"2025-08-04 14:49:40.000000000","message":"Please use helm-toolkit helpers See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-db-init.yaml","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ff51a0f0_c03e77d2","line":1,"in_reply_to":"9cd08a57_1c3cb6b4","updated":"2025-08-07 13:45:57.000000000","message":"Done","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"}],"freezer/templates/job-image-repo-sync.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6862fe257a29c40b0e4c920b6dc194beddd588af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a1900ac0_53d463a8","line":1,"updated":"2025-08-04 14:49:40.000000000","message":"Please use helm-toolkit snippet. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-image-repo-sync.yaml","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"},{"author":{"_account_id":38144,"name":"Anand Nande","display_name":"Anand Nande","email":"anand.nande@pm.me","username":"anand-nande"},"change_message_id":"8eedb86c0a7f44d630025eae42c7afa1b0867e20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"apiVersion: batch/v1"},{"line_number":4,"context_line":"kind: Job"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a7ab5fc8_40633611","line":1,"in_reply_to":"a1900ac0_53d463a8","updated":"2025-08-07 13:45:57.000000000","message":"Done","commit_id":"445204359ae488fd794ee4612160b27bda9bd069"}]}