)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e3954696cb6fbe859bfe6b3c2b3f309ecc425076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31cd8e71_f556bf6a","updated":"2025-08-04 16:34:41.000000000","message":"Please add a deployment test job for the new chart. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/2025.1.yaml#L35-L44 and https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/base.yaml#L471-L491\n\nThe job is supposed to run a bunch of scripts for deploying dependencies and the Blazar chart itself.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"19650a88_deae62f8","updated":"2025-08-13 13:28:32.000000000","message":"Recheck","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"a80824b9216ca56b2f885a1c1adac4d03be80d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2631aeb2_1b5a2971","updated":"2025-08-13 14:43:48.000000000","message":"Recheck","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"0902ca7d89ff7418256fa24054e598e45d26a490","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2de4a0fb_cbcdbbd2","updated":"2025-08-13 14:51:16.000000000","message":"Recheck","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"60390bdced0d2056068e860f8d660db9ed63a078","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3621a23c_0fea347a","updated":"2025-08-13 14:21:50.000000000","message":"Recheck","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"d71f61294aaeb7a281d8935eb456eb108a6ba09f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"4f9f2d00_b119fcf0","updated":"2025-08-13 14:54:54.000000000","message":"Recheck","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"21ff73048058420036a5732ce127f0b83933287a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3fe53a1d_f037c994","updated":"2025-08-14 08:29:59.000000000","message":"Recheck.","commit_id":"03d6b22781061283029342361ea26aef01fa6247"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"85742f6a25bf211217a95a14e2d28decb87beb6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"7f71c2b6_c51299e8","updated":"2025-08-14 11:46:39.000000000","message":"Recheck.","commit_id":"4d239e876cd68fe6bd4733b670a597cd855486ca"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"77cf8cc53af22f0f94b6a499b598f6e1ed63847e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0818e92a_3e891310","updated":"2025-08-15 02:34:16.000000000","message":"Recheck.","commit_id":"f15ce42971ba2ccf3b8bd6de444d794aa6196c9b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"f9c792f778e4015851f8605fac125d838334ac48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"a5b77ed0_cbe2ff13","updated":"2025-08-17 08:06:03.000000000","message":"Recheck.","commit_id":"f81a37d4cf3800cb793b2cc1a89eda664078064d"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"144c820338e2ddcf58decbe0ad31fd32c7ff2c66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"6d006642_e84371a8","updated":"2025-08-19 10:33:25.000000000","message":"Recheck.","commit_id":"52f7af5e553da2a750a0ca526fa021c52729b8e5"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"4c3251fafa2998a28c63260795176e32866015a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"6d7f43a7_8a19b44d","updated":"2025-08-19 08:15:20.000000000","message":"Recheck.","commit_id":"52f7af5e553da2a750a0ca526fa021c52729b8e5"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"311005b8_bb75fac2","updated":"2025-08-21 20:40:40.000000000","message":"Recheck.","commit_id":"bc80a3e91bec31f3be34c5fefe420c6b0fd6fc18"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b1ee97fa306238ea98d153345672bd17cb8b3baa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":119,"id":"2280d76a_295ee23a","updated":"2025-08-26 23:28:35.000000000","message":"Recheck","commit_id":"476244045bcf8f9ad5b6563b88da7679a3273684"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"a7bb650076f4048d5165dfef465514cd258846fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":124,"id":"fc24766a_729650b5","updated":"2025-08-27 19:41:52.000000000","message":"Looks good. The only thing that needs to be done is uncommenting all our usuall check jobs and please put the blazar job to the periodic pipeline next to the watcher job [1]\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/project.yaml#L65\n\nAnd we are ready for review and merge.","commit_id":"e0d2362720646934f188ff611c2ce236f8b5d7b3"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"41a3b532b23deccb33433470d9fab208fced054f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":125,"id":"6ffd944c_4fad2e18","updated":"2025-08-28 14:59:16.000000000","message":"recheck unrelated fail","commit_id":"e1bd0b20d34c00fdd5d04b6ecf8e83f137a29a9f"}],"blazar/Chart.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7aaac406044151b7b316321441da86cf4b0c59a5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"description: OpenStack Resource Reservation Service"},{"line_number":5,"context_line":"name: blazar"},{"line_number":6,"context_line":"type: application"},{"line_number":7,"context_line":"version: 0.1.0"},{"line_number":8,"context_line":"home: https://docs.openstack.org/blazar/"},{"line_number":9,"context_line":"icon: https://openmetal.io/wp-content/uploads/2024/10/OpenStack_Project_Blazar-300x300.jpg"},{"line_number":10,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"bd7d0bb1_b98812c4","line":7,"updated":"2025-08-20 14:22:57.000000000","message":"This must be 2025.1.0. See the spec https://docs.openstack.org/openstack-helm/latest/specs/2025.1/chart_versioning.html","commit_id":"091ee3618a8a17175f85247c5a5b22c672c6c3af"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"description: OpenStack Resource Reservation Service"},{"line_number":5,"context_line":"name: blazar"},{"line_number":6,"context_line":"type: application"},{"line_number":7,"context_line":"version: 0.1.0"},{"line_number":8,"context_line":"home: https://docs.openstack.org/blazar/"},{"line_number":9,"context_line":"icon: https://openmetal.io/wp-content/uploads/2024/10/OpenStack_Project_Blazar-300x300.jpg"},{"line_number":10,"context_line":"sources:"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"7de90c88_47b91632","line":7,"in_reply_to":"bd7d0bb1_b98812c4","updated":"2025-08-21 20:40:40.000000000","message":"Got it.\nAlso, could you please confirm, if appVersion \"2025.1.0\" is correct or need to be \"v1.0.0\"?","commit_id":"091ee3618a8a17175f85247c5a5b22c672c6c3af"}],"blazar/blazar-helm-charts.md":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e3954696cb6fbe859bfe6b3c2b3f309ecc425076","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# OpenStack Blazar Helm Charts"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This document outlines the complete Helm chart structure for OpenStack Blazar (Resource Reservation Service) following the openstack-helm project patterns."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":11,"id":"da314810_d6233a05","line":1,"updated":"2025-08-04 16:34:41.000000000","message":"Please put the chart documentation to the doc directory.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# OpenStack Blazar Helm Charts"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This document outlines the complete Helm chart structure for OpenStack Blazar (Resource Reservation Service) following the openstack-helm project patterns."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":11,"id":"32a2c432_c34aac11","line":1,"in_reply_to":"da314810_d6233a05","updated":"2025-08-13 13:28:32.000000000","message":"Moved to docs","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"}],"blazar/docs/blazar-helm-charts.md":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b757391af502d52cf5c3dcea1c13825da8617d61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# OpenStack Blazar Helm Charts"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This document outlines the complete Helm chart structure for OpenStack Blazar (Resource Reservation Service) following the openstack-helm project patterns."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":13,"id":"d35a8f1a_ecc55204","line":1,"updated":"2025-08-11 14:16:08.000000000","message":"Please move the doc to the doc directory. The Openstack-Helm is not just a collection of independent charts and the deployment documentation is provided for the repo as a whole.","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# OpenStack Blazar Helm Charts"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This document outlines the complete Helm chart structure for OpenStack Blazar (Resource Reservation Service) following the openstack-helm project patterns."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":13,"id":"f309cb6c_d6b10059","line":1,"in_reply_to":"d35a8f1a_ecc55204","updated":"2025-08-13 13:28:32.000000000","message":"Done","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"}],"blazar/files/blazar_scenarios.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b757391af502d52cf5c3dcea1c13825da8617d61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"task:"},{"line_number":3,"context_line":"  - name: \"BlazarBasic.create_and_list_leases\""},{"line_number":4,"context_line":"    args:"},{"line_number":5,"context_line":"      lease_name: \"rally-test-lease-{{ range(10000) | random }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"81cdff0c_3d3de09f","line":2,"updated":"2025-08-11 14:16:08.000000000","message":"Can you please move all these scenarios to values.yaml like how we do this for all other charts? See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/values.yaml#L650-L861","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"task:"},{"line_number":3,"context_line":"  - name: \"BlazarBasic.create_and_list_leases\""},{"line_number":4,"context_line":"    args:"},{"line_number":5,"context_line":"      lease_name: \"rally-test-lease-{{ range(10000) | random }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"b40fbeed_a6243326","line":2,"in_reply_to":"81cdff0c_3d3de09f","updated":"2025-08-13 13:28:32.000000000","message":"Done.","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"}],"blazar/files/tempest_scenarios.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5888a847c9295ec14c024f41274a52a3baa53f2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"scenarios:"},{"line_number":3,"context_line":"  blazar-basic:"},{"line_number":4,"context_line":"    - scenario: \"blazar_tempest_plugin.tests.api.test_leases.LeasesTest.test_create_lease_with_valid_params\""}],"source_content_type":"text/x-yaml","patch_set":58,"id":"da9464e6_db1b4f2a","line":1,"updated":"2025-08-19 22:22:11.000000000","message":"Is this file used anywhere?","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"scenarios:"},{"line_number":3,"context_line":"  blazar-basic:"},{"line_number":4,"context_line":"    - scenario: \"blazar_tempest_plugin.tests.api.test_leases.LeasesTest.test_create_lease_with_valid_params\""}],"source_content_type":"text/x-yaml","patch_set":58,"id":"a2fe0dc0_f6a50cf5","line":1,"in_reply_to":"da9464e6_db1b4f2a","updated":"2025-08-21 20:40:40.000000000","message":"No, removing this now.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"}],"blazar/templates/_helpers.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2a9f10322ed666842e550001913b7e63f8c41de0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- define \"blazar.blazar-api.sh\" -}}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"set -ex"}],"source_content_type":"text/x-smarty","patch_set":58,"id":"c2e9a8c4_51f669a2","line":1,"updated":"2025-08-19 22:09:49.000000000","message":"Please the same code style that we use for other charts. We don\u0027t utilize common template files for everything but instead we put helm templates in specific files. Please see how it is implemented in other charts.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- define \"blazar.blazar-api.sh\" -}}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"set -ex"}],"source_content_type":"text/x-smarty","patch_set":58,"id":"e5eb5d0d_21cfe1d0","line":1,"in_reply_to":"c2e9a8c4_51f669a2","updated":"2025-08-21 20:40:40.000000000","message":"Done.\nremoved: templates/_helpers.tpl\nAdded:\ntemplates/bin/_blazar_api.sh.tpl\ntemplates/bin/_blazar_manager.sh.tpl\ntemplates/bin/_db-sync.sh.tpl","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"}],"blazar/templates/configmap-bin.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $rallyTests :\u003d .Values.conf.rally_tests }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"3d8dc733_ded534f9","line":17,"updated":"2025-08-20 23:10:58.000000000","message":"There is no need for having this variable. Please use the .Values.conf.rally_tests directly.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- $rallyTests :\u003d .Values.conf.rally_tests }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"},{"line_number":20,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"a9de32dc_451441ff","line":17,"in_reply_to":"3d8dc733_ded534f9","updated":"2025-08-21 20:40:40.000000000","message":"Removed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/configmap-etc.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2a9f10322ed666842e550001913b7e63f8c41de0","unresolved":true,"context_lines":[{"line_number":43,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"region_name\" .Values.endpoints.identity.auth.blazar.region_name -}}"},{"line_number":44,"context_line":"{{- end -}}"},{"line_number":45,"context_line":"{{- if empty .Values.conf.blazar.service_credentials.project_name -}}"},{"line_number":46,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"project_name\" .Values.endpoints.identity.auth.blazar.project_name -}}"},{"line_number":47,"context_line":"{{- end -}}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.blazar.service_credentials.project_domain_name -}}"},{"line_number":49,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"project_domain_name\" .Values.endpoints.identity.auth.blazar.project_domain_name -}}"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"1eb31f8a_2bcbfe26","line":46,"updated":"2025-08-19 22:09:49.000000000","message":"There is no such section in the Blazar config file as [service_credentials].","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"region_name\" .Values.endpoints.identity.auth.blazar.region_name -}}"},{"line_number":44,"context_line":"{{- end -}}"},{"line_number":45,"context_line":"{{- if empty .Values.conf.blazar.service_credentials.project_name -}}"},{"line_number":46,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"project_name\" .Values.endpoints.identity.auth.blazar.project_name -}}"},{"line_number":47,"context_line":"{{- end -}}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.blazar.service_credentials.project_domain_name -}}"},{"line_number":49,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.service_credentials \"project_domain_name\" .Values.endpoints.identity.auth.blazar.project_domain_name -}}"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"5a9399a7_fa501088","line":46,"in_reply_to":"1eb31f8a_2bcbfe26","updated":"2025-08-21 20:40:40.000000000","message":"It\u0027s there under .Values.conf.blazar !!\n\nconf:\n  blazar:\n    ...\n    service_credentials:\n      auth_type: password\n      interface: internal\n      auth_version: v3","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"7aaac406044151b7b316321441da86cf4b0c59a5","unresolved":true,"context_lines":[{"line_number":23,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.region_name -}}"},{"line_number":24,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.keystone_authtoken \"region_name\" .Values.endpoints.identity.auth.blazar.region_name -}}"},{"line_number":25,"context_line":"{{- end -}}"},{"line_number":26,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.project_name -}}"},{"line_number":27,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.keystone_authtoken \"project_name\" .Values.endpoints.identity.auth.blazar.project_name -}}"},{"line_number":28,"context_line":"{{- end -}}"},{"line_number":29,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.project_domain_name -}}"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"97ddcb58_0d5d312d","line":26,"updated":"2025-08-20 14:22:57.000000000","message":"Please use the approch like here [1] and [2]. Oslo config automatically loads files from /etc/\u003cproject\u003e/\u003cproject\u003e.conf.d. So we now encourage putting credential config snippets in this directory. See PS 61. \n\nUnfortunately blazar haven\u0027t yet adopted the approach of storing credentials in dedicated config sections like in other projects and our helm-toolkit snippet is not gonna work for os_auth_* and os_admin_* options.\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/secret-ks-etc.yaml\n[2] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/deployment-api-osapi.yaml#L172-L176","commit_id":"091ee3618a8a17175f85247c5a5b22c672c6c3af"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.region_name -}}"},{"line_number":24,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.keystone_authtoken \"region_name\" .Values.endpoints.identity.auth.blazar.region_name -}}"},{"line_number":25,"context_line":"{{- end -}}"},{"line_number":26,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.project_name -}}"},{"line_number":27,"context_line":"{{- $_ :\u003d set .Values.conf.blazar.keystone_authtoken \"project_name\" .Values.endpoints.identity.auth.blazar.project_name -}}"},{"line_number":28,"context_line":"{{- end -}}"},{"line_number":29,"context_line":"{{- if empty .Values.conf.blazar.keystone_authtoken.project_domain_name -}}"}],"source_content_type":"text/x-yaml","patch_set":63,"id":"7966a831_67c660b4","line":26,"in_reply_to":"97ddcb58_0d5d312d","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"091ee3618a8a17175f85247c5a5b22c672c6c3af"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{{- if .Values.conf.blazar.service_user.send_service_user_token -}}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{{- if empty .Values.conf.blazar.service_user.auth_url -}}"},{"line_number":42,"context_line":"{{- $_ :\u003d tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | set .Values.conf.blazar.service_user \"auth_url\" -}}"},{"line_number":43,"context_line":"{{- end -}}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":66,"id":"f8a7c088_ea7e1219","line":41,"updated":"2025-08-20 23:10:58.000000000","message":"There is no such section as service_user in blazar config.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"{{- if .Values.conf.blazar.service_user.send_service_user_token -}}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"{{- if empty .Values.conf.blazar.service_user.auth_url -}}"},{"line_number":42,"context_line":"{{- $_ :\u003d tuple \"identity\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | set .Values.conf.blazar.service_user \"auth_url\" -}}"},{"line_number":43,"context_line":"{{- end -}}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":66,"id":"5220fe9f_ff782949","line":41,"in_reply_to":"f8a7c088_ea7e1219","updated":"2025-08-21 20:40:40.000000000","message":"Removed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/deployment-api.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":64,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"blazar\" \"container\" \"blazar_api\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":65,"context_line":"          command:"},{"line_number":66,"context_line":"            - /tmp/blazar-api.sh"},{"line_number":67,"context_line":"            - start"},{"line_number":68,"context_line":"          lifecycle:"},{"line_number":69,"context_line":"            preStop:"},{"line_number":70,"context_line":"              exec:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"57f932fa_27bfc57b","line":67,"updated":"2025-08-20 23:10:58.000000000","message":"The blazar-api.sh script does not accept any arguments","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"blazar\" \"container\" \"blazar_api\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":65,"context_line":"          command:"},{"line_number":66,"context_line":"            - /tmp/blazar-api.sh"},{"line_number":67,"context_line":"            - start"},{"line_number":68,"context_line":"          lifecycle:"},{"line_number":69,"context_line":"            preStop:"},{"line_number":70,"context_line":"              exec:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"71c6f142_2d610cdc","line":67,"in_reply_to":"57f932fa_27bfc57b","updated":"2025-08-21 20:40:40.000000000","message":"Updated blazar-api.sh script to accept args.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":70,"context_line":"              exec:"},{"line_number":71,"context_line":"                command:"},{"line_number":72,"context_line":"                  - /tmp/blazar-api.sh"},{"line_number":73,"context_line":"                  - stop"},{"line_number":74,"context_line":"          ports:"},{"line_number":75,"context_line":"            - name: b-api"},{"line_number":76,"context_line":"              containerPort: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"308070b4_1e3c5d52","line":73,"updated":"2025-08-20 23:10:58.000000000","message":"the blazar-api.sh script does not accept arguments.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"              exec:"},{"line_number":71,"context_line":"                command:"},{"line_number":72,"context_line":"                  - /tmp/blazar-api.sh"},{"line_number":73,"context_line":"                  - stop"},{"line_number":74,"context_line":"          ports:"},{"line_number":75,"context_line":"            - name: b-api"},{"line_number":76,"context_line":"              containerPort: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"0fffeff4_e7de583d","line":73,"in_reply_to":"308070b4_1e3c5d52","updated":"2025-08-21 20:40:40.000000000","message":"Updated blazar-api.sh script to accept args.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":74,"context_line":"          ports:"},{"line_number":75,"context_line":"            - name: b-api"},{"line_number":76,"context_line":"              containerPort: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":77,"context_line":"          readinessProbe:"},{"line_number":78,"context_line":"            tcpSocket:"},{"line_number":79,"context_line":"              port: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":80,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"ace9350f_89ed5109","line":77,"updated":"2025-08-20 23:10:58.000000000","message":"Please use helm-toolkit.snippets.kubernetes_probe with the probe template. See example [1]. Also Add livenessProbe.\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/deployment-api-osapi.yaml#L99-L100","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"          ports:"},{"line_number":75,"context_line":"            - name: b-api"},{"line_number":76,"context_line":"              containerPort: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":77,"context_line":"          readinessProbe:"},{"line_number":78,"context_line":"            tcpSocket:"},{"line_number":79,"context_line":"              port: {{ tuple \"reservation\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":80,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"daa1f6ba_27441408","line":77,"in_reply_to":"ace9350f_89ed5109","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        - name: blazar-etc"},{"line_number":118,"context_line":"          secret:"},{"line_number":119,"context_line":"            secretName: blazar-etc"},{"line_number":120,"context_line":"            defaultMode: 0444"},{"line_number":121,"context_line":"{{ if $mounts_blazar_api.volumes }}{{ toYaml $mounts_blazar_api.volumes | indent 8 }}{{ end }}"},{"line_number":122,"context_line":"{{- end }}"},{"line_number":123,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"908e37a1_2b099ed8","line":120,"updated":"2025-08-20 23:10:58.000000000","message":"You didn\u0027t mount credential config snippets. The service might be able to start but won\u0027t be able to serve any requests. See my comment to the PS 63 about config snippets.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        - name: blazar-etc"},{"line_number":118,"context_line":"          secret:"},{"line_number":119,"context_line":"            secretName: blazar-etc"},{"line_number":120,"context_line":"            defaultMode: 0444"},{"line_number":121,"context_line":"{{ if $mounts_blazar_api.volumes }}{{ toYaml $mounts_blazar_api.volumes | indent 8 }}{{ end }}"},{"line_number":122,"context_line":"{{- end }}"},{"line_number":123,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"0e44c77f_bd1e707d","line":120,"in_reply_to":"908e37a1_2b099ed8","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/job-db-drop.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b757391af502d52cf5c3dcea1c13825da8617d61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_drop }}\r"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}\r"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-drop\" }}\r"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_drop\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}\r"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"50e7777a_8b7e344c","line":1,"updated":"2025-08-11 14:16:08.000000000","message":"Can you please use helm-toolkit.manifests.job_db_drop_mysql here?","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_drop }}\r"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}\r"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-drop\" }}\r"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_drop\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}\r"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3cafa0ba_91f15063","line":1,"in_reply_to":"50e7777a_8b7e344c","updated":"2025-08-13 13:28:32.000000000","message":"Done.","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"}],"blazar/templates/job-db-init.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b757391af502d52cf5c3dcea1c13825da8617d61","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_init }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-init\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_init\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ecc584d8_2049596b","line":1,"updated":"2025-08-11 14:16:08.000000000","message":"why didn\u0027t you use helm-toolkit.manifests.job_db_init_mysql snippent here?","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_init }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-init\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_init\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dffe71b3_14ce19a3","line":1,"in_reply_to":"ecc584d8_2049596b","updated":"2025-08-13 13:28:32.000000000","message":"Done.","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"}],"blazar/templates/job-db-sync.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e3954696cb6fbe859bfe6b3c2b3f309ecc425076","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_sync }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-sync\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_sync\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"269c87bd_3ea16f1d","line":1,"updated":"2025-08-04 16:34:41.000000000","message":"Please use helm-toolkit.manifests.job_db_sync helper instead of defining the job from scratch.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_db_sync }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-db-sync\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"db_sync\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f4f4787_7b3048dc","line":1,"in_reply_to":"269c87bd_3ea16f1d","updated":"2025-08-13 13:28:32.000000000","message":"Used helm-toolkit.manifests.job_db_sync as suggested.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"}],"blazar/templates/job-ks-endpoints.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e3954696cb6fbe859bfe6b3c2b3f309ecc425076","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-ks-endpoints\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"ks_endpoints\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"cc72dbac_df9891cb","line":1,"updated":"2025-08-04 16:34:41.000000000","message":"Please use the helm-toolkit wherever possible. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-ks-endpoints.yaml","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-ks-endpoints\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"ks_endpoints\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fcfc4b56_4ccc786a","line":1,"in_reply_to":"cc72dbac_df9891cb","updated":"2025-08-13 13:28:32.000000000","message":"Used helm-toolkit as suggested.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"1c4290a2_63384a7f","line":15,"updated":"2025-08-20 23:10:58.000000000","message":"let\u0027s use the same pattern for the endpoints job as in other charts. See example [1]. I mean helm3 hook annotations and tls support.\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-ks-endpoints.yaml","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"3b7f9f0a_4456ffde","line":15,"in_reply_to":"1c4290a2_63384a7f","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"},{"line_number":19,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"210ac56d_30ad15d2","line":16,"updated":"2025-08-20 23:10:58.000000000","message":"The variable name is not good for the endpoints job.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"},{"line_number":19,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"af4f1f5e_e5fbe09f","line":16,"in_reply_to":"210ac56d_30ad15d2","updated":"2025-08-21 20:40:40.000000000","message":"Changed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/job-ks-service.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_service }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"6c4e2c3c_8c272438","line":15,"updated":"2025-08-20 23:10:58.000000000","message":"let\u0027s use the same pattern as in other charts. See for example [1]\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-ks-service.yaml","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_service }}"},{"line_number":16,"context_line":"{{- $ksServiceJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" \"serviceTypes\" ( tuple \"reservation\" ) -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksServiceJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"e2e72420_098a2d1c","line":15,"in_reply_to":"6c4e2c3c_8c272438","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/job-ks-user.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"e3954696cb6fbe859bfe6b3c2b3f309ecc425076","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-ks-user\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"ks_user\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a9cb41fa_b14816ea","line":1,"updated":"2025-08-04 16:34:41.000000000","message":"Please use helm-toolkit helpers wherever possible. For ks users you can use helm-toolkit.manifests.job_ks_user. See for example https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-ks-user.yaml","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"{{- $serviceAccountName :\u003d \"blazar-ks-user\" }}"},{"line_number":4,"context_line":"{{ tuple $envAll \"ks_user\" $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ef2fa652_e90148ea","line":1,"in_reply_to":"a9cb41fa_b14816ea","updated":"2025-08-13 13:28:32.000000000","message":"Used helm-toolkit helpers as suggested.","commit_id":"9715db3afcbd1a859d6b3aba3e0e91ccb1204b7b"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":16,"context_line":"{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksUserJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"c6c116b8_5d3259c1","line":15,"updated":"2025-08-20 23:10:58.000000000","message":"Please add helm hooks annotations and tls support like other charts do. See example [1] \n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/nova/templates/job-ks-user.yaml","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":16,"context_line":"{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $ksUserJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"847a6579_b9ba3e4e","line":15,"in_reply_to":"c6c116b8_5d3259c1","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/job-rabbit-init.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_rabbit_init }}"},{"line_number":16,"context_line":"{{- $rmqUserJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $rmqUserJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"1ce3c88e_813410c4","line":15,"updated":"2025-08-20 23:10:58.000000000","message":"forgotten tls support and hook annotations","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.job_rabbit_init }}"},{"line_number":16,"context_line":"{{- $rmqUserJob :\u003d dict \"envAll\" . \"serviceName\" \"blazar\" -}}"},{"line_number":17,"context_line":"{{- if .Values.pod.tolerations.blazar.enabled -}}"},{"line_number":18,"context_line":"{{- $_ :\u003d set $rmqUserJob \"tolerationsEnabled\" true -}}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"e1bf2d3d_c5e0b38e","line":15,"in_reply_to":"1ce3c88e_813410c4","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/secret-db.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.secret_db }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"blazar\" }}"},{"line_number":18,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.oslo_db $userClass }}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"cad76f3d_fab945d3","line":15,"updated":"2025-08-20 23:10:58.000000000","message":"Please add tls support, like in other charts","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"limitations under the License."},{"line_number":13,"context_line":"*/}}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- if .Values.manifests.secret_db }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":17,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"blazar\" }}"},{"line_number":18,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.oslo_db $userClass }}"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"d611cef1_9e022e9f","line":15,"in_reply_to":"cad76f3d_fab945d3","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/secret-ks-etc.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":18,"context_line":"{{- $ksUsers :\u003d dict"},{"line_number":19,"context_line":"  \"blazar\" \"keystone_authtoken\""},{"line_number":20,"context_line":"-}}"},{"line_number":21,"context_line":"{{- if .Values.conf.nova.service_user.send_service_user_token }}"},{"line_number":22,"context_line":"{{- $_ :\u003d set $ksUsers \"service\" \"service_user\" -}}"},{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":"{{ dict"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"70c29a4a_8e5faded","line":21,"updated":"2025-08-20 23:10:58.000000000","message":"nova?","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $ksUsers :\u003d dict"},{"line_number":19,"context_line":"  \"blazar\" \"keystone_authtoken\""},{"line_number":20,"context_line":"-}}"},{"line_number":21,"context_line":"{{- if .Values.conf.nova.service_user.send_service_user_token }}"},{"line_number":22,"context_line":"{{- $_ :\u003d set $ksUsers \"service\" \"service_user\" -}}"},{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":"{{ dict"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"64fedf29_c347c224","line":21,"in_reply_to":"70c29a4a_8e5faded","updated":"2025-08-21 20:40:40.000000000","message":"Removed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/service-api.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      {{ end }}"},{"line_number":29,"context_line":"  selector:"},{"line_number":30,"context_line":"{{ tuple $envAll \"blazar\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"  {{ if .Values.network.api.node_port.enabled }}"},{"line_number":32,"context_line":"  type: NodePort"},{"line_number":33,"context_line":"  {{ if .Values.network.api.external_policy_local }}"},{"line_number":34,"context_line":"  externalTrafficPolicy: Local"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"4435ac3f_77ffb720","line":31,"updated":"2025-08-20 23:10:58.000000000","message":"it is better to use {{- for if blocks to avoid empty lines","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      {{ end }}"},{"line_number":29,"context_line":"  selector:"},{"line_number":30,"context_line":"{{ tuple $envAll \"blazar\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"  {{ if .Values.network.api.node_port.enabled }}"},{"line_number":32,"context_line":"  type: NodePort"},{"line_number":33,"context_line":"  {{ if .Values.network.api.external_policy_local }}"},{"line_number":34,"context_line":"  externalTrafficPolicy: Local"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"011b5250_013c23bf","line":31,"in_reply_to":"4435ac3f_77ffb720","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"blazar/templates/servicemonitor-api.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b757391af502d52cf5c3dcea1c13825da8617d61","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"---"},{"line_number":4,"context_line":"apiVersion: monitoring.coreos.com/v1"},{"line_number":5,"context_line":"kind: ServiceMonitor"},{"line_number":6,"context_line":"metadata:"},{"line_number":7,"context_line":"  name: blazar-api"},{"line_number":8,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"a56f2531_1cc4fcdb","line":5,"updated":"2025-08-11 14:16:08.000000000","message":"Using this CR is only valid when you have prometheus operator. Can we remove this resource if it is not absolutely necessary?","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"b542494fd9ef871d9461f7b2abee0f7400ba497c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":3,"context_line":"---"},{"line_number":4,"context_line":"apiVersion: monitoring.coreos.com/v1"},{"line_number":5,"context_line":"kind: ServiceMonitor"},{"line_number":6,"context_line":"metadata:"},{"line_number":7,"context_line":"  name: blazar-api"},{"line_number":8,"context_line":"  labels:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5d93e4fa_955ec9d6","line":5,"in_reply_to":"a56f2531_1cc4fcdb","updated":"2025-08-13 13:28:32.000000000","message":"Removed.","commit_id":"1f37e67ce0680a03f204ea8075bc6447c40754d1"}],"blazar/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"6cdc75b99de64f248aa3d265571f1443cc3bd3c7","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"conf:"},{"line_number":520,"context_line":"  blazar:"},{"line_number":521,"context_line":"    DEFAULT:"},{"line_number":522,"context_line":"      debug: false"},{"line_number":523,"context_line":"      log_config_append: /etc/blazar/logging.conf"},{"line_number":524,"context_line":"      api_paste_config: /etc/blazar/api-paste.ini"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"d6441ada_270a3775","line":521,"updated":"2025-08-19 22:27:30.000000000","message":"it seems the configuration is missing os_auth_* and os_admin_* options","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"conf:"},{"line_number":520,"context_line":"  blazar:"},{"line_number":521,"context_line":"    DEFAULT:"},{"line_number":522,"context_line":"      debug: false"},{"line_number":523,"context_line":"      log_config_append: /etc/blazar/logging.conf"},{"line_number":524,"context_line":"      api_paste_config: /etc/blazar/api-paste.ini"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"9c64ea78_57427a85","line":521,"in_reply_to":"d6441ada_270a3775","updated":"2025-08-21 20:40:40.000000000","message":"Yeah, I removed it for testing, missed adding it back. Though, it is currently same as done in other components, they also don\u0027t have these in values.yaml","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    blazar_api: quay.io/airshipit/blazar:2025.1-ubuntu_jammy"},{"line_number":42,"context_line":"    blazar_manager: quay.io/airshipit/blazar:2025.1-ubuntu_jammy"},{"line_number":43,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:latest-ubuntu_jammy"},{"line_number":44,"context_line":"    scripted_test: quay.io/airshipit/heat:2025.1-ubuntu_jammy"},{"line_number":45,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":66,"id":"45c604ad_08c02db9","line":44,"updated":"2025-08-20 23:10:58.000000000","message":"is this image needed?","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    blazar_api: quay.io/airshipit/blazar:2025.1-ubuntu_jammy"},{"line_number":42,"context_line":"    blazar_manager: quay.io/airshipit/blazar:2025.1-ubuntu_jammy"},{"line_number":43,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:latest-ubuntu_jammy"},{"line_number":44,"context_line":"    scripted_test: quay.io/airshipit/heat:2025.1-ubuntu_jammy"},{"line_number":45,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":66,"id":"f1ac8512_e65982d3","line":44,"in_reply_to":"45c604ad_08c02db9","updated":"2025-08-21 20:40:40.000000000","message":"No, removed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":328,"context_line":"    public_network_id: \"public\""},{"line_number":329,"context_line":"    floating_network_id: \"public\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"pod:"},{"line_number":332,"context_line":"  security_context:"},{"line_number":333,"context_line":"    blazar:"},{"line_number":334,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"cdb7c3d1_5ac1654f","line":331,"updated":"2025-08-20 23:10:58.000000000","message":"Please consider adding probe section here. At least it is useful for API deployment where we check TCP port.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    public_network_id: \"public\""},{"line_number":329,"context_line":"    floating_network_id: \"public\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"pod:"},{"line_number":332,"context_line":"  security_context:"},{"line_number":333,"context_line":"    blazar:"},{"line_number":334,"context_line":"      pod:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"da2383f0_9a4f751d","line":331,"in_reply_to":"cdb7c3d1_5ac1654f","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":554,"context_line":"      auth_version: v3"},{"line_number":555,"context_line":"      memcache_security_strategy: ENCRYPT"},{"line_number":556,"context_line":"      service_type: reservation"},{"line_number":557,"context_line":"    service_user:"},{"line_number":558,"context_line":"      auth_type: password"},{"line_number":559,"context_line":"      send_service_user_token: true"},{"line_number":560,"context_line":"    oslo_messaging_notifications:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"a50eb48e_6892345d","line":557,"updated":"2025-08-20 23:10:58.000000000","message":"there is no such section in the blazar config","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"      auth_version: v3"},{"line_number":555,"context_line":"      memcache_security_strategy: ENCRYPT"},{"line_number":556,"context_line":"      service_type: reservation"},{"line_number":557,"context_line":"    service_user:"},{"line_number":558,"context_line":"      auth_type: password"},{"line_number":559,"context_line":"      send_service_user_token: true"},{"line_number":560,"context_line":"    oslo_messaging_notifications:"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"c8ddebf1_881b026c","line":557,"in_reply_to":"a50eb48e_6892345d","updated":"2025-08-21 20:40:40.000000000","message":"Removed.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":676,"context_line":"    run_tempest: false"},{"line_number":677,"context_line":"    clean_up: \"\""},{"line_number":678,"context_line":"    tests:"},{"line_number":679,"context_line":"      Dummy.dummy:"},{"line_number":680,"context_line":"        -"},{"line_number":681,"context_line":"          args:"},{"line_number":682,"context_line":"            sleep: 5"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"0272994d_7b807101","line":679,"updated":"2025-08-20 23:10:58.000000000","message":"Let\u0027s add a comment here that this is just a placeholder and Rally does not support Blazar scenarios at this point out of the box","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    run_tempest: false"},{"line_number":677,"context_line":"    clean_up: \"\""},{"line_number":678,"context_line":"    tests:"},{"line_number":679,"context_line":"      Dummy.dummy:"},{"line_number":680,"context_line":"        -"},{"line_number":681,"context_line":"          args:"},{"line_number":682,"context_line":"            sleep: 5"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"51874d97_4aeeacbc","line":679,"in_reply_to":"0272994d_7b807101","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":714,"context_line":"  pdb_api: true"},{"line_number":715,"context_line":"  pdb_manager: true"},{"line_number":716,"context_line":"  pod_rally_test: true"},{"line_number":717,"context_line":"  secret_db: true"},{"line_number":718,"context_line":"  secret_keystone: true"},{"line_number":719,"context_line":"  secret_rabbitmq: true"},{"line_number":720,"context_line":"  service_api: true"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"2c505c86_d305b41b","line":717,"updated":"2025-08-20 23:10:58.000000000","message":"forgotten secret_ks_etc","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":714,"context_line":"  pdb_api: true"},{"line_number":715,"context_line":"  pdb_manager: true"},{"line_number":716,"context_line":"  pod_rally_test: true"},{"line_number":717,"context_line":"  secret_db: true"},{"line_number":718,"context_line":"  secret_keystone: true"},{"line_number":719,"context_line":"  secret_rabbitmq: true"},{"line_number":720,"context_line":"  service_api: true"}],"source_content_type":"text/x-yaml","patch_set":66,"id":"5399524e_f63f8625","line":717,"in_reply_to":"2c505c86_d305b41b","updated":"2025-08-21 20:40:40.000000000","message":"Added.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}],"doc/source/install/openstack.rst":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2a9f10322ed666842e550001913b7e63f8c41de0","unresolved":true,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":".. code-block:: bash"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    helm install blazar ./blazar \\"},{"line_number":488,"context_line":"      --namespace\u003dopenstack"}],"source_content_type":"text/x-rst","patch_set":58,"id":"8340544a_837130f1","line":487,"updated":"2025-08-19 22:09:49.000000000","message":"Please use the same command as for other charts.\n\n```\nhelm upgrade --install blazar openstack-helm/blazar \\\n  --namespace\u003dopenstack \\\n  $(helm osh get-values-overrides -p ${OVERRIDES_DIR} -c tacker ${FEATURES})\n```","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":".. code-block:: bash"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    helm install blazar ./blazar \\"},{"line_number":488,"context_line":"      --namespace\u003dopenstack"}],"source_content_type":"text/x-rst","patch_set":58,"id":"ef0c3230_c6ee3e0a","line":487,"in_reply_to":"8340544a_837130f1","updated":"2025-08-21 20:40:40.000000000","message":"Done.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"}],"releasenotes/notes/blazar.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2a9f10322ed666842e550001913b7e63f8c41de0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"blazar:"},{"line_number":3,"context_line":"  - 0.1.0 Initial Chart"},{"line_number":4,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"76a610f5_b5811166","line":3,"updated":"2025-08-19 22:09:49.000000000","message":"No need to use versioning here. We upgrade versions twice a year for all the charts when the Openstack is released.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"blazar:"},{"line_number":3,"context_line":"  - 0.1.0 Initial Chart"},{"line_number":4,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"e4c7d2f3_49dcc478","line":3,"in_reply_to":"4c73f991_b0f4bb8f","updated":"2025-08-21 20:40:40.000000000","message":"Done.\nNew file created: releasenotes/notes/blazar-73cedded47699964.yaml","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5888a847c9295ec14c024f41274a52a3baa53f2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"blazar:"},{"line_number":3,"context_line":"  - 0.1.0 Initial Chart"},{"line_number":4,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"4c73f991_b0f4bb8f","line":3,"in_reply_to":"76a610f5_b5811166","updated":"2025-08-19 22:22:11.000000000","message":"Also please use reno to add a release note.\n```\nreno new blazar\n```\nit will create a file releasenotes/notes/blazar-\u003chash\u003e.yaml\nand then you have to edit this file.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"}],"values_overrides/blazar/2025.1-ubuntu_jammy.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5888a847c9295ec14c024f41274a52a3baa53f2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    bootstrap: quay.io/airshipit/heat:2025.1-ubuntu_jammy"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"2c44006c_7e409aa5","line":1,"updated":"2025-08-19 22:22:11.000000000","message":"Please also add 2025.1-ubuntu_noble.yaml override","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"images:"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    bootstrap: quay.io/airshipit/heat:2025.1-ubuntu_jammy"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"87e00644_699b1e18","line":1,"in_reply_to":"2c44006c_7e409aa5","updated":"2025-08-21 20:40:40.000000000","message":"Done.\nAdded: values_overrides/blazar/2025.1-ubuntu_noble.yaml","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"}],"zuul.d/base.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bc0e4041488057086d20bb567c832a145434f419","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":552,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":553,"context_line":"        - ./tools/deployment/component/blazar/blazar.sh"},{"line_number":554,"context_line":"        - ./tools/deployment/common/run-helm-tests.sh blazar"},{"line_number":555,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"73fb0af7_3932bc49","line":554,"updated":"2025-08-20 00:11:45.000000000","message":"what is the point here to run helm test? the only pod with the test hook is the rally pod, right? and the list of rally scenarios is empty. Since Rally does not provide blazar plugin out of the box let\u0027s at least add a dummy test scenario as a placeholder.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":552,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":553,"context_line":"        - ./tools/deployment/component/blazar/blazar.sh"},{"line_number":554,"context_line":"        - ./tools/deployment/common/run-helm-tests.sh blazar"},{"line_number":555,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":58,"id":"be498c43_296b84ed","line":554,"in_reply_to":"73fb0af7_3932bc49","updated":"2025-08-21 20:40:40.000000000","message":"I believe, rally tests are getting executed by run-helm-tests.sh script only, hence added this.","commit_id":"937a961b9f2190aa2bc496aa595170c508c7d251"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"ac911a60cd1d93aac6792dbbac715c90fb0bf8e7","unresolved":true,"context_lines":[{"line_number":550,"context_line":"        - ./tools/deployment/db/mariadb.sh"},{"line_number":551,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":552,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":553,"context_line":"        - ./tools/deployment/component/blazar/blazar.sh"},{"line_number":554,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"a1c5b935_b2a3ce3b","line":553,"updated":"2025-08-20 23:10:58.000000000","message":"1) Since now you added the dummy rally test, let\u0027s add the helm test script here run-helm-tests.sh blazar. At least we can be sure that the rally test pod is deployed correctly.\n2) Also it seems successful deployment of Blazar does not mean it serves properly. Earlier you mentioned that Blazar components are running but they were not properly  configured (missing credentials). So let\u0027s add at least smoky functional test. Something like: list leases, create lease, delete lease.","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"},{"author":{"_account_id":23886,"name":"NITIN GUPTA","email":"nitin291989@gmail.com","username":"nitin-29-gupta"},"change_message_id":"6b0d30c1b764ba74003955fbdb87e308cf822bf6","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        - ./tools/deployment/db/mariadb.sh"},{"line_number":551,"context_line":"        - ./tools/deployment/component/common/memcached.sh"},{"line_number":552,"context_line":"        - ./tools/deployment/component/keystone/keystone.sh"},{"line_number":553,"context_line":"        - ./tools/deployment/component/blazar/blazar.sh"},{"line_number":554,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":66,"id":"94970d42_7fd353d1","line":553,"in_reply_to":"a1c5b935_b2a3ce3b","updated":"2025-08-21 20:40:40.000000000","message":"@kozhukalov@gmail.com, I had removed \"./tools/deployment/common/run-helm-tests.sh blazar\", because same is getting executed inside \"blazar.sh\".\nAnyways, I have added it again, as suggeted by you.\n\nAdded following test cases for now:\n1. list hosts in the blazar freepool\n2. list leases\n3. list all the hosts","commit_id":"2b30c48183da2141ddb0345ef3e7d039526eaf49"}]}