)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"113c432b9c8cf8183b3472f74adf7c06ed73bf99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6090d0b7_755b31de","updated":"2025-08-25 17:46:42.000000000","message":"If this new image isn\u0027t fully compatible with the previous then we could probably have a second daemonset container so users can choose between them during the deprecation period. And we can send an announcement about this update and then remove the old container after one release cycle.","commit_id":"fec853fc8c7c4ced3ecde8af76c6e16fa146172a"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bb35a259cdb7c1cfce27147207aed0c4fd91c4b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"254738a0_87536a43","in_reply_to":"177376c8_7208a7f4","updated":"2025-08-29 15:00:52.000000000","message":"The problem here is not about good/bad but about not breaking existing deployments.","commit_id":"fec853fc8c7c4ced3ecde8af76c6e16fa146172a"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"a261a63eba37ee39435c4df0ac080cf0b5c8e1ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"177376c8_7208a7f4","in_reply_to":"6090d0b7_755b31de","updated":"2025-08-26 08:34:02.000000000","message":"The new image is the better option going forward. \n(inovex/prometheus-libvirt-exporter) is actively maintained and already adopted by other OpenStack projects such as Kolla-Ansible.\nhttps://docs.openstack.org/releasenotes/kolla/2024.1.html#new-features\n\nThere is also an ongoing effort to move inovex/prometheus-libvirt-exporter into the Prometheus community (discussion here : https://github.com/prometheus-community/community/issues/50), which confirms it as the future-facing solution.\n\nGiven that, I think it makes sense to switch directly to the new exporter rather than keep both in parallel.","commit_id":"fec853fc8c7c4ced3ecde8af76c6e16fa146172a"}],"libvirt/releasenotes/notes/libvirt-339936ca478fbf50.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"2d6e96c983c1cfcda02fdc1383a689b192d71333","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for the Prometheus libvirt exporter using"},{"line_number":5,"context_line":"    ghcr.io/inovex/prometheus-libvirt-exporter."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The exporter exposes per-VM and hypervisor-level metrics, including CPU, memory,"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0273d53d_0623f2e4","line":4,"updated":"2025-09-01 11:47:41.000000000","message":"This release note now does not look actual. Maybe something like \n```\nfeatures:\n  - |\n    Make exporter container args configurable in values to make it possible to use\n    ghcr.io/inovex/prometheus-libvirt-exporter image which assumes\n    having no additional args.\n```\n\nAnd can you please add the override file maybe values_overrides/libvirt/inovex_exporter.yaml with this better image with a comment like\n\n```\n# NOTE: Use the inovex exporter image by default since 2026.1 release.\nimages:\n  tags:\n    libvirt_exporter: ghcr.io/inovex/prometheus-libvirt-exporter:2.2.0\nsidecars:\n  libvirt_exporter:\n    enabled: true\n    args: []\nmanifests:\n  podmonitor: true\n```\n\nThanks a lot for this image suggestion.","commit_id":"9d7e5b8c13885bc2666489ce38294161042ec68c"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"d12eae1da1650b9ad1552e16a71d5be99ce65db2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for the Prometheus libvirt exporter using"},{"line_number":5,"context_line":"    ghcr.io/inovex/prometheus-libvirt-exporter."},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The exporter exposes per-VM and hypervisor-level metrics, including CPU, memory,"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"12bc83b9_68e0445e","line":4,"in_reply_to":"0273d53d_0623f2e4","updated":"2025-09-01 14:18:01.000000000","message":"Done","commit_id":"9d7e5b8c13885bc2666489ce38294161042ec68c"}],"libvirt/templates/daemonset-libvirt.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"1ef9df2dc895273aff947c8e4891c2daded14555","unresolved":true,"context_lines":[{"line_number":300,"context_line":"{{ tuple $envAll \"libvirt_exporter\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":301,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.libvirt_exporter | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":302,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"libvirt\" \"container\" \"libvirt_exporter\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":303,"context_line":"          args:"},{"line_number":304,"context_line":"            - \"--libvirt.nova\""},{"line_number":305,"context_line":"          ports:"},{"line_number":306,"context_line":"            - name: metrics"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f8867157_f10f309d","side":"PARENT","line":303,"updated":"2025-08-25 17:21:47.000000000","message":"this is gonna break existing deployments. Let\u0027s make it backward compatible. Let\u0027s put args to values.yaml","commit_id":"72a656e3f4ebb789f792451b3084589ec2a263a3"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"a261a63eba37ee39435c4df0ac080cf0b5c8e1ee","unresolved":false,"context_lines":[{"line_number":300,"context_line":"{{ tuple $envAll \"libvirt_exporter\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":301,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.libvirt_exporter | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":302,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"libvirt\" \"container\" \"libvirt_exporter\" | include \"helm-toolkit.snippets.kubernetes_container_security_context\" | indent 10 }}"},{"line_number":303,"context_line":"          args:"},{"line_number":304,"context_line":"            - \"--libvirt.nova\""},{"line_number":305,"context_line":"          ports:"},{"line_number":306,"context_line":"            - name: metrics"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cd843f4a_6987762f","side":"PARENT","line":303,"in_reply_to":"f8867157_f10f309d","updated":"2025-08-26 08:34:02.000000000","message":"fix by add option for enable the args","commit_id":"72a656e3f4ebb789f792451b3084589ec2a263a3"}],"libvirt/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"bb35a259cdb7c1cfce27147207aed0c4fd91c4b8","unresolved":true,"context_lines":[{"line_number":292,"context_line":"              - ALL"},{"line_number":293,"context_line":"  sidecars:"},{"line_number":294,"context_line":"    libvirt_exporter: false"},{"line_number":295,"context_line":"    config:"},{"line_number":296,"context_line":"      enabled: false"},{"line_number":297,"context_line":"      args:"},{"line_number":298,"context_line":"        - \"--libvirt.nova\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1ef2486d_311f621c","line":295,"updated":"2025-08-29 15:00:52.000000000","message":"I would rather make the config a subkey of the libvirt_exporter.\n```\nsidecars:\n  libvirt_exporter:\n    enabled: false\n    args:\n      - \"--libvirt.nova\"\n```\nFor those who would like to use new image we could have an override\n\n```\nimages:\n  tags:\n    libvirt_exporter: ghcr.io/inovex/prometheus-libvirt-exporter:2.2.0\nsidecars:\n  libvirt_exporter:\n    enabled: true\n    args: []\n```","commit_id":"240044ce2d3967ab5a41022d1ed037ce8c886b35"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"e6a646c43da5bced871f223d65549b92381f3fea","unresolved":false,"context_lines":[{"line_number":292,"context_line":"              - ALL"},{"line_number":293,"context_line":"  sidecars:"},{"line_number":294,"context_line":"    libvirt_exporter: false"},{"line_number":295,"context_line":"    config:"},{"line_number":296,"context_line":"      enabled: false"},{"line_number":297,"context_line":"      args:"},{"line_number":298,"context_line":"        - \"--libvirt.nova\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a7c5f7a0_9bb8b0a1","line":295,"in_reply_to":"1ef2486d_311f621c","updated":"2025-08-31 17:07:21.000000000","message":"Done","commit_id":"240044ce2d3967ab5a41022d1ed037ce8c886b35"}]}