)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"9ff2f0c9c50ef780ececdc6fde1d481f767cacd8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d72041b7_6dcc8e18","updated":"2025-09-29 17:17:41.000000000","message":"So with something like https://review.opendev.org/c/openstack/openstack-helm/+/962535 you would be able to drop in your own configmap or secret to override these settings (and more). Let me know what you think of this approach?","commit_id":"af88df4404759f2a163fd567eda10657df82b471"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"1852cdc6f1afff9ec8a735bb0d7a82ea50157f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67dba2d5_636a8dfb","in_reply_to":"d72041b7_6dcc8e18","updated":"2025-10-16 17:55:24.000000000","message":"Done","commit_id":"af88df4404759f2a163fd567eda10657df82b471"}],"neutron/templates/bin/_neutron-ovn-init.sh.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"12b3bddeb235c1e733bf0e0514b787a9bc81aeae","unresolved":true,"context_lines":[{"line_number":20,"context_line":"mkdir -p /tmp/pod-shared"},{"line_number":21,"context_line":"tee \u003e /tmp/pod-shared/ovn.ini \u003c\u003c EOF"},{"line_number":22,"context_line":"[ovn]"},{"line_number":23,"context_line":"ovn_nb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_nb_connection \"tcp:$OVN_OVSDB_NB_SERVICE_HOST:$OVN_OVSDB_NB_SERVICE_PORT_OVSDB\" }}"},{"line_number":24,"context_line":"ovn_sb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_sb_connection \"tcp:$OVN_OVSDB_SB_SERVICE_HOST:$OVN_OVSDB_SB_SERVICE_PORT_OVSDB\" }}"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"44daabe2_d77419f0","line":23,"updated":"2025-10-16 23:48:13.000000000","message":"In the first place this was introduced because the ovs library could not resolve dns names and the config options could not be used directly. \n\nIf at the moment the dns names could be used then this template should use the same pattern as we use in configmap-etc.yaml templates when we prepare the messaging connection string. I mean we should gather the connection info from the the endpoints values section. See for example [1].\n\nAlso after some deprecation period we can get rid of using env variables exported by Kubelet.\n\n[1] https://opendev.org/openstack/openstack-helm/src/branch/master/neutron/templates/configmap-etc.yaml#L51-L53","commit_id":"848216ff58f998061262a4c8914c5d45096df9e4"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"cb2164fa05198d23c21ab03821c94b64d57c0530","unresolved":true,"context_lines":[{"line_number":20,"context_line":"mkdir -p /tmp/pod-shared"},{"line_number":21,"context_line":"tee \u003e /tmp/pod-shared/ovn.ini \u003c\u003c EOF"},{"line_number":22,"context_line":"[ovn]"},{"line_number":23,"context_line":"ovn_nb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_nb_connection \"tcp:$OVN_OVSDB_NB_SERVICE_HOST:$OVN_OVSDB_NB_SERVICE_PORT_OVSDB\" }}"},{"line_number":24,"context_line":"ovn_sb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_sb_connection \"tcp:$OVN_OVSDB_SB_SERVICE_HOST:$OVN_OVSDB_SB_SERVICE_PORT_OVSDB\" }}"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"729bf957_821ca727","line":23,"in_reply_to":"44daabe2_d77419f0","updated":"2025-10-16 23:52:01.000000000","message":"I mean you can set the parameter directly in the config section, but if it is not defined, then we can gather it from endpoints.","commit_id":"848216ff58f998061262a4c8914c5d45096df9e4"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"3afb488e9fb036b6d267dac984dd2556ab689342","unresolved":true,"context_lines":[{"line_number":20,"context_line":"mkdir -p /tmp/pod-shared"},{"line_number":21,"context_line":"tee \u003e /tmp/pod-shared/ovn.ini \u003c\u003c EOF"},{"line_number":22,"context_line":"[ovn]"},{"line_number":23,"context_line":"ovn_nb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_nb_connection \"tcp:$OVN_OVSDB_NB_SERVICE_HOST:$OVN_OVSDB_NB_SERVICE_PORT_OVSDB\" }}"},{"line_number":24,"context_line":"ovn_sb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_sb_connection \"tcp:$OVN_OVSDB_SB_SERVICE_HOST:$OVN_OVSDB_SB_SERVICE_PORT_OVSDB\" }}"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"91336ac7_dc0b6581","line":23,"in_reply_to":"729bf957_821ca727","updated":"2025-10-17 03:41:59.000000000","message":"I think DNS names were fixed in 2024.1?","commit_id":"848216ff58f998061262a4c8914c5d45096df9e4"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"f689a2a2fc2b4b850f84d7703ff9b26cd81ba60f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"mkdir -p /tmp/pod-shared"},{"line_number":21,"context_line":"tee \u003e /tmp/pod-shared/ovn.ini \u003c\u003c EOF"},{"line_number":22,"context_line":"[ovn]"},{"line_number":23,"context_line":"ovn_nb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_nb_connection \"tcp:$OVN_OVSDB_NB_SERVICE_HOST:$OVN_OVSDB_NB_SERVICE_PORT_OVSDB\" }}"},{"line_number":24,"context_line":"ovn_sb_connection\u003d{{ coalesce .Values.conf.plugins.ml2_conf.ovn.ovn_sb_connection \"tcp:$OVN_OVSDB_SB_SERVICE_HOST:$OVN_OVSDB_SB_SERVICE_PORT_OVSDB\" }}"},{"line_number":25,"context_line":"EOF"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"6f23fed4_16c34f04","line":23,"in_reply_to":"91336ac7_dc0b6581","updated":"2025-10-17 20:45:57.000000000","message":"Yes, I see it is fixed.\n\nAnyway it is better to use the same fallback pattern and set the connection info from the endpoints section. But we can do this later.","commit_id":"848216ff58f998061262a4c8914c5d45096df9e4"}],"neutron/values.yaml":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"8e0e8337053b4552d9c7f1bb63f9332673ecf981","unresolved":true,"context_lines":[{"line_number":2676,"context_line":"  oslo_db: false"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"# custom ovn-connection"},{"line_number":2679,"context_line":"custom:"},{"line_number":2680,"context_line":"  ovn_nb_connection: \u0027\u0027"},{"line_number":2681,"context_line":"  ovn_sb_connection: \u0027\u0027"},{"line_number":2682,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"baf27f39_0aff9fd4","line":2679,"updated":"2025-09-23 15:47:19.000000000","message":"This should really be in the conf section and use the existing value as the default.","commit_id":"af88df4404759f2a163fd567eda10657df82b471"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"1ebc8cb8fe96d708905d02b5c3164e9ac50fe8db","unresolved":false,"context_lines":[{"line_number":2676,"context_line":"  oslo_db: false"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"# custom ovn-connection"},{"line_number":2679,"context_line":"custom:"},{"line_number":2680,"context_line":"  ovn_nb_connection: \u0027\u0027"},{"line_number":2681,"context_line":"  ovn_sb_connection: \u0027\u0027"},{"line_number":2682,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1b7e19c5_5e00b5e0","line":2679,"in_reply_to":"baf27f39_0aff9fd4","updated":"2025-09-23 19:33:17.000000000","message":"I’d like to clarify why I approached it this way:\n\nCurrently, these parameters don’t actually have static defaults – they are populated at runtime from the environment variables ($OVN_OVSDB_NB_SERVICE_HOST, $OVN_OVSDB_NB_SERVICE_PORT_OVSDB, etc.). If we were to move them into the [conf] section and treat them as normal config values, that would introduce a discrepancy: the default behavior today depends on the runtime environment, not on values in values.yaml.\n\nIf we explicitly define defaults in conf and override them through values.yaml, that would add extra configuration in neutron.conf which is not needed in the current design, and could potentially lead to unintended behavior.\n\nThat’s why I kept the coalesce fallback pointing to the environment-based values — so that unless a user explicitly provides a custom override, the runtime behavior remains unchanged.","commit_id":"af88df4404759f2a163fd567eda10657df82b471"}]}