)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"498f15c8696e44144b9118dfb70fcf05b6759e4a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89d1b49a_ad4f7453","updated":"2025-11-09 04:12:19.000000000","message":"This is not the style we\u0027ve done before for adding extra containers to pods. It\u0027s also not very flexible for configuration. Look at the ironic chart under the conductor section for example. The Ironic example would follow the pattern seen in the upstream Helm best practices.","commit_id":"81b72577c7bed0dd4c90232a85f28588ff614e23"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"83d6c14fb661c4b2a12856f3b8f70a996db9de21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"993b7f2c_f2869904","in_reply_to":"89d1b49a_ad4f7453","updated":"2025-11-13 19:00:26.000000000","message":"I appreciate the feedback, but I respectfully disagree.\n\nThe approach used here follows the same pattern that was previously implemented and accepted in the libvirt chart for adding sidecar containers. That pattern has proven to be both flexible and configurable in practice.\n\nI understand the point about following the pattern from the ironic chart, but in this case, aligning with the existing libvirt implementation keeps consistency within the charts that deploy similar components and avoids introducing a different structure for a similar use case.\n\nUnless there’s a strong technical reason to diverge from the established and working pattern, I believe it’s preferable to maintain consistency with the libvirt approach.","commit_id":"81b72577c7bed0dd4c90232a85f28588ff614e23"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"4ba324dc077290b37bff0c38b0b0b3fc2f68a5ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bf8b19f7_5d5d0deb","in_reply_to":"993b7f2c_f2869904","updated":"2025-11-18 22:41:18.000000000","message":"I think what Doug means here is that in many cases it is better to make it possible to inject necessary things as is instead of hard-coding them. This is not only about Ironic extraContainers, we use this pattern for volume mounts in all charts. \n\nYou are right that in libvirt and ovn we have sidecars in place as part of the template. For some use cases like monitoring or collecting logs there are reference implementations (like inovex libvirt exporter) that most users would prefer to stick to. It is good to have some reference options in our charts. However I am not sure about this ovs exporter fork. Let\u0027s also consider this https://github.com/digitalocean/openvswitch_exporter\n\nApart from reference stuff we can (and probably should) add this extraContainers value in all charts to make it possible for users to inject what they need.","commit_id":"81b72577c7bed0dd4c90232a85f28588ff614e23"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"cf4930960432457d4d695ce6dc026a3d55c3d6c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8ce95ef_5cb2934b","updated":"2026-03-04 06:09:52.000000000","message":"@mgagne@calavera.ca \u0026 @kozhukalov@gmail.com what would you like to do with this change?","commit_id":"23951dadde42a090eddd75253f9bfa8a18049230"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"d4c5e69155c3636edea72d4c45da4e093af59ac6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6dcc08c_ec9c4fe8","updated":"2026-02-23 19:54:30.000000000","message":"I\u0027m very much in favor of providing proper hooks/configs instead.","commit_id":"23951dadde42a090eddd75253f9bfa8a18049230"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"c0cd649812d1b34bf5c99e49a371113861d8ed23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2548807_0f6d9029","in_reply_to":"b8ce95ef_5cb2934b","updated":"2026-03-04 22:12:36.000000000","message":"I would rather abandon this because we recently merged this [1] which allows users to add custom containers including exporters. The suggested container is put to values_overrides/openvswitch/exporter.yaml and compute-kit test job is run with this override [2].\n\n[1] https://review.opendev.org/c/openstack/openstack-helm/+/977738\n[2] https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/base.yaml#L152-L154","commit_id":"23951dadde42a090eddd75253f9bfa8a18049230"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"53beff718c39fe5980c6c55358501c9e72649d23","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"281594f6_84536128","in_reply_to":"f2548807_0f6d9029","updated":"2026-03-04 22:16:28.000000000","message":"Aslo the same is done for the libvirt chart [1]. At the moment the compute-kit job deploys libvirt with tht inovex exporter [2].\n\n[1] https://review.opendev.org/c/openstack/openstack-helm/+/977721\n[2] https://opendev.org/openstack/openstack-helm/src/branch/master/zuul.d/base.yaml#L156-L157","commit_id":"23951dadde42a090eddd75253f9bfa8a18049230"}],"openvswitch/values.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"620a82ac1bfa5c30364bf3eb5c50c5a220ea84f9","unresolved":true,"context_lines":[{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    openvswitch_db_server: docker.io/openstackhelm/openvswitch:latest-ubuntu_focal"},{"line_number":24,"context_line":"    openvswitch_vswitchd: docker.io/openstackhelm/openvswitch:latest-ubuntu_focal"},{"line_number":25,"context_line":"    openvswitch_exporter: ghcr.io/saeed-mcu/ovs_exporter/openvswitch_exporter:v2.3.2"},{"line_number":26,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:latest-ubuntu_focal"},{"line_number":27,"context_line":"    image_repo_sync: docker.io/library/docker:17.07.0"},{"line_number":28,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b6839183_e966654a","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":24},"updated":"2025-11-06 07:55:53.000000000","message":"do we built this image by our own?","commit_id":"81b72577c7bed0dd4c90232a85f28588ff614e23"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"1fffadee9e541978e7eb5133a4ebd62cb0ae5d71","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  tags:"},{"line_number":23,"context_line":"    openvswitch_db_server: docker.io/openstackhelm/openvswitch:latest-ubuntu_focal"},{"line_number":24,"context_line":"    openvswitch_vswitchd: docker.io/openstackhelm/openvswitch:latest-ubuntu_focal"},{"line_number":25,"context_line":"    openvswitch_exporter: ghcr.io/saeed-mcu/ovs_exporter/openvswitch_exporter:v2.3.2"},{"line_number":26,"context_line":"    dep_check: quay.io/airshipit/kubernetes-entrypoint:latest-ubuntu_focal"},{"line_number":27,"context_line":"    image_repo_sync: docker.io/library/docker:17.07.0"},{"line_number":28,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a96aba47_5aaa6ce4","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":24},"in_reply_to":"b6839183_e966654a","updated":"2025-11-07 13:02:19.000000000","message":"No. I used the repository https://github.com/saeed-mcu/ovs_exporter, which is a fork of https://github.com/greenpau/ovs_exporter.","commit_id":"81b72577c7bed0dd4c90232a85f28588ff614e23"}]}