)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"969f6c9786281b6e3be9c3bd520500d8e4e98aac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"095a2560_06c0cdbb","updated":"2025-11-06 07:50:31.000000000","message":"Also I would suggest to use snippet for this https://github.com/openstack/openstack-helm/blob/1a044d13e9641aee20df855939ce4437b27b1598/helm-toolkit/templates/utils/_to_k8s_env_vars.tpl#L23","commit_id":"e6de69832a73b5e5e998fc8cda1c9d7aabc5fbb1"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d657b9bb7aec6cb8ec182cc40556be522142f8f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c93b4871_97e54218","updated":"2025-11-04 20:53:07.000000000","message":"recheck","commit_id":"e6de69832a73b5e5e998fc8cda1c9d7aabc5fbb1"}],"ovn/values.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"9470e4dcfa496c69c968e6603e01babe2b7cae9d","unresolved":true,"context_lines":[{"line_number":142,"context_line":"  use_fqdn:"},{"line_number":143,"context_line":"    compute: true"},{"line_number":144,"context_line":"  envs:"},{"line_number":145,"context_line":"    common:"},{"line_number":146,"context_line":"      - name: OVN_DAEMONSET_VERSION"},{"line_number":147,"context_line":"        value: \"3\""},{"line_number":148,"context_line":"      - name: OVN_KUBERNETES_NAMESPACE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"20940f4f_187f6efa","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":10},"updated":"2025-11-06 07:49:48.000000000","message":"nit: user may expect that common is merged together with component specific, maybe better to use dic style here and merge two dicts before adding variables like:\n```\nenvs:\n  common:\n    VAR_NAME: VAR_VALUE\n  controller:\n    VAR_NAME1: VAR_VALUE\n    VAR_NAME: VAR_VALUE2\n```","commit_id":"e6de69832a73b5e5e998fc8cda1c9d7aabc5fbb1"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"faf9ff30b85ef77c35c243a302acd83b62c0d1ad","unresolved":true,"context_lines":[{"line_number":142,"context_line":"  use_fqdn:"},{"line_number":143,"context_line":"    compute: true"},{"line_number":144,"context_line":"  envs:"},{"line_number":145,"context_line":"    common:"},{"line_number":146,"context_line":"      - name: OVN_DAEMONSET_VERSION"},{"line_number":147,"context_line":"        value: \"3\""},{"line_number":148,"context_line":"      - name: OVN_KUBERNETES_NAMESPACE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"52d7d859_cc90b727","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":10},"in_reply_to":"20940f4f_187f6efa","updated":"2025-11-09 04:07:18.000000000","message":"Yeah I\u0027d 100% expect it to merge. That\u0027s definitely a pattern you see in other Helm charts out there. I\u0027d prefer to see that behavior for this.","commit_id":"e6de69832a73b5e5e998fc8cda1c9d7aabc5fbb1"}]}
