)]}'
{"cinder/templates/deployment-backup.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5b9b1e618e591c1553dde10b2b0e0efb38d086f2","unresolved":true,"context_lines":[{"line_number":108,"context_line":"            {{- end }}"},{"line_number":109,"context_line":"{{- if and $envAll.Values.ceph_client.enable_external_ceph_backend $envAll.Values.ceph_client.external_ceph.rbd_user }}"},{"line_number":110,"context_line":"            {{- if $is_external }}"},{"line_number":111,"context_line":"            - name: RBD_USER"},{"line_number":112,"context_line":"              value: {{ $envAll.Values.ceph_client.external_ceph.rbd_user | quote }}"},{"line_number":113,"context_line":"            {{- end }}"},{"line_number":114,"context_line":"            {{- if or $is_internal $is_external }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9851bdc1_d58a7d8c","line":111,"updated":"2025-12-03 04:11:35.000000000","message":"Correct me if I am wrong, but it looks like here the variable name should be EXTERNAL_RBD_USER","commit_id":"836862fa3ad568658c815a042b546e8b5822d095"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5b9b1e618e591c1553dde10b2b0e0efb38d086f2","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            - name: RBD_USER"},{"line_number":112,"context_line":"              value: {{ $envAll.Values.ceph_client.external_ceph.rbd_user | quote }}"},{"line_number":113,"context_line":"            {{- end }}"},{"line_number":114,"context_line":"            {{- if or $is_internal $is_external }}"},{"line_number":115,"context_line":"            - name: EXTERNAL_RBD_USER"},{"line_number":116,"context_line":"              value: {{ $envAll.Values.ceph_client.external_ceph.rbd_user | quote }}"},{"line_number":117,"context_line":"            {{- end }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f14189da_28972083","line":114,"updated":"2025-12-03 04:11:35.000000000","message":"This line is not needed because this whole block is already inside the `if or $is_internal $is_external`","commit_id":"836862fa3ad568658c815a042b546e8b5822d095"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5b9b1e618e591c1553dde10b2b0e0efb38d086f2","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            - name: etcceph"},{"line_number":207,"context_line":"              mountPath: /etc/ceph"},{"line_number":208,"context_line":"            {{- if not .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":209,"context_line":"            {{- if eq \"true\" (include \"cinder.utils.has_internal_ceph_backend\" $envAll) }}"},{"line_number":210,"context_line":"            - name: ceph-etc"},{"line_number":211,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":212,"context_line":"              subPath: ceph.conf"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ac07528a_83c8c361","line":209,"updated":"2025-12-03 04:11:35.000000000","message":"why not just?\n```\n{{- if (include \"cinder.utils.has_internal_ceph_backend\" $envAll) }}\n```","commit_id":"836862fa3ad568658c815a042b546e8b5822d095"}],"cinder/templates/utils/_has_internal_ceph_backend.tpl":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"5b9b1e618e591c1553dde10b2b0e0efb38d086f2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  {{- $has_internal :\u003d false -}}"},{"line_number":17,"context_line":"  {{- range $_, $backend :\u003d .Values.conf.backends -}}"},{"line_number":18,"context_line":"    {{- if kindIs \"map\" $backend -}}"},{"line_number":19,"context_line":"      {{- if and (eq $backend.volume_driver \"cinder.volume.drivers.rbd.RBDDriver\") (ne $backend.rbd_ceph_conf \"/etc/ceph/external-ceph.conf\") -}}"},{"line_number":20,"context_line":"        {{- $has_internal \u003d true -}}"},{"line_number":21,"context_line":"      {{- end -}}"},{"line_number":22,"context_line":"    {{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"d9306cd6_3568e35b","line":19,"updated":"2025-12-03 04:11:35.000000000","message":"Probably better not hardcode this file name /etc/ceph/external-ceph.conf. \n\nAlso IMO it seems a bit awkward to consider a backend as internal if the conf name is not /etc/ceph/external-ceph.conf","commit_id":"836862fa3ad568658c815a042b546e8b5822d095"}]}