)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"734c9591dc2a552d0e72e359c0de7f93b9826958","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55704db4_8c4dca09","updated":"2026-02-23 19:35:56.000000000","message":"Can you please add a reno releasenotes too for this change. Thanks.","commit_id":"6e2a2919d80257f98c5f186e14a5b7731f4f3727"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"52ba7c64271fb2560a018ebe1f96a15abcf45b5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ed8f8392_95c5a5a4","in_reply_to":"55704db4_8c4dca09","updated":"2026-02-23 23:01:46.000000000","message":"Done","commit_id":"6e2a2919d80257f98c5f186e14a5b7731f4f3727"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"0a5707b2614ebe663b7889081a38e7b75d15d7b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04939dad_833411cc","updated":"2026-02-24 08:06:29.000000000","message":"recheck","commit_id":"0756aa46aa4f4fa94344dde5d77512d4d5fef246"}],"manila/values.yaml":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"734c9591dc2a552d0e72e359c0de7f93b9826958","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        container_format: bare"},{"line_number":315,"context_line":"        private: false"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"ceph_client:"},{"line_number":318,"context_line":"  configmap: ceph-etc"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f1dbb06_b9a28ffe","line":317,"updated":"2026-02-23 19:35:56.000000000","message":"Good. This structure matches what is found in other charts:\n- cinder: https://opendev.org/openstack/openstack-helm/src/tag/2025.2.0/cinder/values.yaml#L463\n- glance: https://opendev.org/openstack/openstack-helm/src/tag/2025.2.0/glance/values.yaml#L80-L81\n- nova: https://opendev.org/openstack/openstack-helm/src/branch/master/nova/values.yaml#L562-L563","commit_id":"6e2a2919d80257f98c5f186e14a5b7731f4f3727"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"734c9591dc2a552d0e72e359c0de7f93b9826958","unresolved":true,"context_lines":[{"line_number":883,"context_line":"  oslo_db:"},{"line_number":884,"context_line":"    admin: manila-db-admin"},{"line_number":885,"context_line":"    manila: manila-db-user"},{"line_number":886,"context_line":"  rbd: manila-keyring"},{"line_number":887,"context_line":"  oslo_messaging:"},{"line_number":888,"context_line":"    admin: manila-rabbitmq-admin"},{"line_number":889,"context_line":"    manila: manila-rabbitmq-user"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f02f079e_ac966168","line":886,"updated":"2026-02-23 19:35:56.000000000","message":"I see secrets entries are typically map/dict in all charts, except for rbd which is unfortunately not consistent as it is the only one using string in some places:\n- glance (string): https://opendev.org/openstack/openstack-helm/src/tag/2025.2.0/glance/values.yaml#L550\n- gnocchi (string): https://opendev.org/openstack/openstack-helm/src/tag/2025.2.0/gnocchi/values.yaml#L484\n- cinder (map): https://opendev.org/openstack/openstack-helm/src/tag/2025.2.0/cinder/values.yaml#L1252-L1255\n\nThis is not a blocker (to me) but would like to point out the rbd key can be seen as inconsistent with other values. I\u0027ll let other reviewers sharing their point of view.","commit_id":"6e2a2919d80257f98c5f186e14a5b7731f4f3727"},{"author":{"_account_id":37622,"name":"saeed padari","display_name":"Saeed Padari","email":"sam137115@gmail.com","username":"saeedpadari"},"change_message_id":"16940ba8c898f273dfaafeb914ea868ece4d210d","unresolved":false,"context_lines":[{"line_number":883,"context_line":"  oslo_db:"},{"line_number":884,"context_line":"    admin: manila-db-admin"},{"line_number":885,"context_line":"    manila: manila-db-user"},{"line_number":886,"context_line":"  rbd: manila-keyring"},{"line_number":887,"context_line":"  oslo_messaging:"},{"line_number":888,"context_line":"    admin: manila-rabbitmq-admin"},{"line_number":889,"context_line":"    manila: manila-rabbitmq-user"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3afab940_02b148ab","line":886,"in_reply_to":"f02f079e_ac966168","updated":"2026-02-23 23:05:30.000000000","message":"Acknowledged","commit_id":"6e2a2919d80257f98c5f186e14a5b7731f4f3727"}]}