)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"afd496b00da0c32a5c426d7db1fa42d4c5abf170","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"388365e1_8224055b","updated":"2026-04-10 22:39:03.000000000","message":"Please do the updates suggested.","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"f8b1e9bda9f444a9a4c0d120ef36b48f9fa9b945","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a308b1dc_82005614","updated":"2026-04-10 16:23:09.000000000","message":"Thanks for working on this, added few minor comments","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"ff4ba514e66d972de40cb9e0f15e2b1174f72b2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ad7fb55_e3ac52c3","in_reply_to":"388365e1_8224055b","updated":"2026-04-11 01:18:37.000000000","message":"Done","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"470dbeb6e077281773d968f271032d227e86d5ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d8e1ffc_ac88f836","updated":"2026-04-13 15:42:16.000000000","message":"thanks for addressing","commit_id":"bb6f67d2fe686d8779325da73644e15bc4006bcb"}],"ironic/templates/bin/_ironic-novncproxy.sh.tpl":[{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"f8b1e9bda9f444a9a4c0d120ef36b48f9fa9b945","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -ex"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"exec ironic-novncproxy --config-file /etc/ironic/ironic.conf"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"c4e03bee_ccca744b","line":19,"updated":"2026-04-10 16:23:09.000000000","message":"This also needs the `--config-dir /etc/ironic/ironic.conf.d/`","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"5af932cd42b2a82d65f856e2fe70e18afcbd702e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e3dde78_b91d5880","in_reply_to":"c4e03bee_ccca744b","updated":"2026-04-11 01:16:02.000000000","message":"Done. Added --config-dir /etc/ironic/ironic.conf.d to the exec command.","commit_id":"bb6f67d2fe686d8779325da73644e15bc4006bcb"}],"ironic/templates/role-console-pods.yaml":[{"author":{"_account_id":37208,"name":"Marek Skrobacki","display_name":"Marek Skrobacki","email":"skrobul@skrobul.com","username":"skrobul"},"change_message_id":"f8b1e9bda9f444a9a4c0d120ef36b48f9fa9b945","unresolved":true,"context_lines":[{"line_number":21,"context_line":"rules:"},{"line_number":22,"context_line":"  - apiGroups: [\"\"]"},{"line_number":23,"context_line":"    resources: [\"pods\", \"secrets\"]"},{"line_number":24,"context_line":"    verbs: [\"create\", \"delete\", \"get\", \"list\", \"watch\"]"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"33b460bf_c61d635a","line":24,"updated":"2026-04-10 16:23:09.000000000","message":"`pods`: requires `create/delete/patch`\n`secrets`: requires `create/delete/list/get/patch`\n\n\nSo `patch` is missing on both and `pods` is getting potentially too much.","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"5af932cd42b2a82d65f856e2fe70e18afcbd702e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"498b7fba_13f1c71a","in_reply_to":"33b460bf_c61d635a","updated":"2026-04-11 01:16:02.000000000","message":"Done. Split into separate rules:\n- pods: create, delete, patch\n- secrets: create, delete, get, list, patch","commit_id":"bb6f67d2fe686d8779325da73644e15bc4006bcb"}],"ironic/values.yaml":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"dbd68aca91ad3365e4e60baea73cef995f8f6592","unresolved":true,"context_lines":[{"line_number":955,"context_line":"  service_api: true"},{"line_number":956,"context_line":"  service_ingress_api: true"},{"line_number":957,"context_line":"  statefulset_conductor: true"},{"line_number":958,"context_line":"  deployment_novncproxy: false"},{"line_number":959,"context_line":"  service_novncproxy: false"},{"line_number":960,"context_line":"  role_console_pods: false"},{"line_number":961,"context_line":"  rolebinding_console_pods: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1eed7d34_81dd2f28","line":958,"updated":"2026-04-10 17:27:21.000000000","message":"List seems to be (mostly) sorted. I suggest sorting your additions as well.","commit_id":"502caddc19fec6ad2ad2cd07d394e3a690b8bdde"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"5af932cd42b2a82d65f856e2fe70e18afcbd702e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08e502d2_11089486","in_reply_to":"1eed7d34_81dd2f28","updated":"2026-04-11 01:16:02.000000000","message":"Done. All manifest entries are now sorted alphabetically.","commit_id":"bb6f67d2fe686d8779325da73644e15bc4006bcb"}]}