)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"026aa484dbe16ee76ba410f0b0910ee177b0c243","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"95980168_eee8b382","updated":"2026-05-01 15:13:25.000000000","message":"recheck","commit_id":"df5664dc24a87325992cc8c993cd6f6098b12692"}],"helm-toolkit/templates/snippets/_kubernetes_pod_rbac_serviceaccount.tpl":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"c4c68c8ff1b9379cceff8074bc8a8faba5aa999d","unresolved":true,"context_lines":[{"line_number":43,"context_line":"metadata:"},{"line_number":44,"context_line":"  name: {{ $saName }}"},{"line_number":45,"context_line":"  namespace: {{ $saNamespace }}"},{"line_number":46,"context_line":"{{- if $envAll.Values.manifests.secret_registry }}"},{"line_number":47,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":48,"context_line":"imagePullSecrets:"},{"line_number":49,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry $envAll.Chart.Name }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"383ec126_35a0d44b","side":"PARENT","line":46,"updated":"2026-04-21 16:27:57.000000000","message":"I think the main issue is that `imagePullSecrets` is guarded by 2 conditions:\n- $envAll.Values.manifests.secret_registry\n- $envAll.Values.endpoints.oci_image_registry.auth.enabled\n\nOnly 1 should be required. If the `$envAll.Values.manifests.secret_registry` condition is removed, you should able be able to not generate the Secret while being able to use yours, as defined in `.Values.secrets.oci_image_registry`","commit_id":"7e8f26de0ac3ecc437dae913672a1d163b1f470d"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"bde2ddb16a6032ceb38b1503dda38e9f62bd5169","unresolved":false,"context_lines":[{"line_number":43,"context_line":"metadata:"},{"line_number":44,"context_line":"  name: {{ $saName }}"},{"line_number":45,"context_line":"  namespace: {{ $saNamespace }}"},{"line_number":46,"context_line":"{{- if $envAll.Values.manifests.secret_registry }}"},{"line_number":47,"context_line":"{{- if $envAll.Values.endpoints.oci_image_registry.auth.enabled }}"},{"line_number":48,"context_line":"imagePullSecrets:"},{"line_number":49,"context_line":"  - name: {{ index $envAll.Values.secrets.oci_image_registry $envAll.Chart.Name }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"525c33ac_0ecb5820","side":"PARENT","line":46,"in_reply_to":"383ec126_35a0d44b","updated":"2026-05-01 06:45:16.000000000","message":"Thanks for the review! Addressed both comments:\n1. Removed the double condition on imagePullSecrets. It is now guarded\n   solely by endpoints.oci_image_registry.auth.enabled, while Secret\n   creation remains controlled by manifests.secret_registry as before.\n2. Removed manifests.secret_registry_existing and\n   secret_registry_existing_name entirely. To use an existing secret,\n   users can now set manifests.secret_registry: false and specify the\n   existing secret name via secrets.oci_image_registry.\u003cchart-name\u003e,\n   which is the existing mechanism for secret naming.","commit_id":"7e8f26de0ac3ecc437dae913672a1d163b1f470d"}],"releasenotes/notes/helm-toolkit-existing-registry-secret-a1b2c3d4e5f6g7h8.yaml":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"c4c68c8ff1b9379cceff8074bc8a8faba5aa999d","unresolved":true,"context_lines":[{"line_number":26,"context_line":"      # Case 3: Attach existing secret with custom name"},{"line_number":27,"context_line":"      manifests:"},{"line_number":28,"context_line":"        secret_registry_existing: true"},{"line_number":29,"context_line":"        secret_registry_existing_name: \"my-shared-registry-secret\""},{"line_number":30,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"364a9a81_e9f58f20","line":29,"updated":"2026-04-21 16:27:57.000000000","message":"manifests is used to enable/disable manifests and are therefore only boolean.\nThis value should be provided by secrets.oci_image_registry like it current is as that\u0027s where secret names are defined.","commit_id":"0b2f8cd0200e1fc54a926be6f4bc10899b687a2a"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"bde2ddb16a6032ceb38b1503dda38e9f62bd5169","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      # Case 3: Attach existing secret with custom name"},{"line_number":27,"context_line":"      manifests:"},{"line_number":28,"context_line":"        secret_registry_existing: true"},{"line_number":29,"context_line":"        secret_registry_existing_name: \"my-shared-registry-secret\""},{"line_number":30,"context_line":"..."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f5725bb_ee10170e","line":29,"in_reply_to":"364a9a81_e9f58f20","updated":"2026-05-01 06:45:16.000000000","message":"Acknowledged","commit_id":"0b2f8cd0200e1fc54a926be6f4bc10899b687a2a"}]}